-
Notifications
You must be signed in to change notification settings - Fork 151
Implement Serverless Service Representation (SSR) in AWS Lambda #7850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7850) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (76ms) : 69, 82
master - mean (76ms) : 70, 81
section Bailout
This PR (7850) - mean (81ms) : 74, 87
master - mean (80ms) : 74, 86
section CallTarget+Inlining+NGEN
This PR (7850) - mean (1,064ms) : 979, 1149
master - mean (1,063ms) : 977, 1149
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (118ms) : 109, 127
master - mean (119ms) : 108, 129
section Bailout
This PR (7850) - mean (121ms) : 113, 129
master - mean (119ms) : 110, 128
section CallTarget+Inlining+NGEN
This PR (7850) - mean (760ms) : 703, 818
master - mean (767ms) : 705, 828
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (107ms) : 100, 114
master - mean (106ms) : 98, 115
section Bailout
This PR (7850) - mean (107ms) : 100, 113
master - mean (105ms) : 98, 112
section CallTarget+Inlining+NGEN
This PR (7850) - mean (710ms) : 670, 750
master - mean (718ms) : 676, 760
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (105ms) : 95, 116
master - mean (104ms) : 96, 113
section Bailout
This PR (7850) - mean (106ms) : 99, 113
master - mean (105ms) : 96, 113
section CallTarget+Inlining+NGEN
This PR (7850) - mean (685ms) : 648, 722
master - mean (687ms) : 655, 718
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (193ms) : 190, 196
master - mean (193ms) : 189, 196
section Bailout
This PR (7850) - mean (196ms) : 193, 199
master - mean (197ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (7850) - mean (1,111ms) : 1054, 1168
master - mean (1,115ms) : 1045, 1185
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (277ms) : 273, 282
master - mean (277ms) : 271, 283
section Bailout
This PR (7850) - mean (278ms) : 274, 282
master - mean (278ms) : 273, 283
section CallTarget+Inlining+NGEN
This PR (7850) - mean (903ms) : 859, 947
master - mean (905ms) : 854, 956
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (272ms) : 266, 278
master - mean (270ms) : 266, 274
section Bailout
This PR (7850) - mean (271ms) : 267, 274
master - mean (272ms) : 265, 279
section CallTarget+Inlining+NGEN
This PR (7850) - mean (891ms) : 837, 945
master - mean (884ms) : 844, 924
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7850) - mean (271ms) : 263, 279
master - mean (269ms) : 265, 273
section Bailout
This PR (7850) - mean (269ms) : 267, 272
master - mean (270ms) : 265, 275
section CallTarget+Inlining+NGEN
This PR (7850) - mean (827ms) : 804, 849
master - mean (829ms) : 812, 847
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7850 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 | 6.01 KB | 6.05 KB | 38 B | 0.63% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 11.2μs | 50.8ns | 203ns | 0 | 0 | 0 | 5.5 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 13.6μs | 69.1ns | 317ns | 0 | 0 | 0 | 5.68 KB |
| master | StartStopWithChild |
net472 | 22.3μs | 123ns | 776ns | 0.97 | 0.431 | 0.108 | 6.01 KB |
| #7850 | StartStopWithChild |
net6.0 | 10.7μs | 60ns | 384ns | 0 | 0 | 0 | 5.52 KB |
| #7850 | StartStopWithChild |
netcoreapp3.1 | 13.7μs | 72.1ns | 360ns | 0 | 0 | 0 | 5.71 KB |
| #7850 | StartStopWithChild |
net472 | 22.5μs | 115ns | 550ns | 1.04 | 0.311 | 0.104 | 6.05 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 926μs | 53.1ns | 199ns | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.05ms | 2.65μs | 9.9μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.2ms | 61.9ns | 240ns | 0 | 0 | 0 | 3.31 KB |
| #7850 | WriteAndFlushEnrichedTraces |
net6.0 | 935μs | 64.7ns | 242ns | 0 | 0 | 0 | 2.7 KB |
| #7850 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.04ms | 168ns | 652ns | 0 | 0 | 0 | 2.7 KB |
| #7850 | WriteAndFlushEnrichedTraces |
net472 | 1.24ms | 397ns | 1.54μs | 0 | 0 | 0 | 3.31 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 1.08μs | 5.6ns | 26.8ns | 0 | 0 | 0 | 1.22 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 1.37μs | 6.78ns | 28.8ns | 0 | 0 | 0 | 1.2 KB |
| master | AllCycleSimpleBody |
net472 | 1.01μs | 0.574ns | 2.22ns | 0.192 | 0 | 0 | 1.23 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 7.2μs | 7.78ns | 30.2ns | 0 | 0 | 0 | 4.72 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 9.01μs | 33.1ns | 128ns | 0 | 0 | 0 | 4.62 KB |
| master | AllCycleMoreComplexBody |
net472 | 7.58μs | 5.15ns | 19.9ns | 0.721 | 0 | 0 | 4.74 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 321ns | 1.8ns | 11ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 402ns | 2.07ns | 10.2ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 297ns | 0.084ns | 0.303ns | 0.0433 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.34μs | 33.3ns | 163ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.94μs | 28.9ns | 112ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.75μs | 6.17ns | 23.9ns | 0.572 | 0 | 0 | 3.8 KB |
| #7850 | AllCycleSimpleBody |
net6.0 | 1.08μs | 0.444ns | 1.72ns | 0 | 0 | 0 | 1.22 KB |
| #7850 | AllCycleSimpleBody |
netcoreapp3.1 | 1.46μs | 7.94ns | 39.7ns | 0 | 0 | 0 | 1.2 KB |
| #7850 | AllCycleSimpleBody |
net472 | 1.02μs | 0.556ns | 1.93ns | 0.193 | 0 | 0 | 1.23 KB |
| #7850 | AllCycleMoreComplexBody |
net6.0 | 7.16μs | 36.2ns | 170ns | 0 | 0 | 0 | 4.72 KB |
| #7850 | AllCycleMoreComplexBody |
netcoreapp3.1 | 9.06μs | 26ns | 101ns | 0 | 0 | 0 | 4.62 KB |
| #7850 | AllCycleMoreComplexBody |
net472 | 7.67μs | 3.13ns | 12.1ns | 0.729 | 0 | 0 | 4.74 KB |
| #7850 | ObjectExtractorSimpleBody |
net6.0 | 318ns | 1.76ns | 10.6ns | 0 | 0 | 0 | 280 B |
| #7850 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 396ns | 2.21ns | 13.6ns | 0 | 0 | 0 | 272 B |
| #7850 | ObjectExtractorSimpleBody |
net472 | 293ns | 0.0286ns | 0.107ns | 0.0443 | 0 | 0 | 281 B |
| #7850 | ObjectExtractorMoreComplexBody |
net6.0 | 6.3μs | 29.7ns | 115ns | 0 | 0 | 0 | 3.78 KB |
| #7850 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.79μs | 36.1ns | 145ns | 0 | 0 | 0 | 3.69 KB |
| #7850 | ObjectExtractorMoreComplexBody |
net472 | 6.72μs | 3.08ns | 11.9ns | 0.602 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 75.4μs | 343ns | 1.33μs | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 96.9μs | 220ns | 823ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 109μs | 11.6ns | 43.5ns | 4.88 | 0 | 0 | 32.51 KB |
| master | EncodeLegacyArgs |
net6.0 | 146μs | 218ns | 844ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 199μs | 170ns | 659ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
net472 | 263μs | 23.8ns | 92.2ns | 0 | 0 | 0 | 2.17 KB |
| #7850 | EncodeArgs |
net6.0 | 77.9μs | 168ns | 649ns | 0 | 0 | 0 | 32.4 KB |
| #7850 | EncodeArgs |
netcoreapp3.1 | 97.9μs | 226ns | 875ns | 0 | 0 | 0 | 32.4 KB |
| #7850 | EncodeArgs |
net472 | 109μs | 24.7ns | 95.5ns | 4.89 | 0 | 0 | 32.51 KB |
| #7850 | EncodeLegacyArgs |
net6.0 | 142μs | 36.6ns | 137ns | 0 | 0 | 0 | 2.15 KB |
| #7850 | EncodeLegacyArgs |
netcoreapp3.1 | 196μs | 287ns | 1.11μs | 0 | 0 | 0 | 2.14 KB |
| #7850 | EncodeLegacyArgs |
net472 | 262μs | 34ns | 132ns | 0 | 0 | 0 | 2.17 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #7850
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1
2.137
408,796.27
873,560.31
Faster 🎉 in #7850
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1
2.352
704,899.48
299,726.49
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 | 2.137 | 408,796.27 | 873,560.31 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 | 2.352 | 704,899.48 | 299,726.49 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 393μs | 118ns | 427ns | 0 | 0 | 0 | 4.56 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 409μs | 112ns | 404ns | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 428μs | 56.9ns | 220ns | 0 | 0 | 0 | 4.68 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 285μs | 48.4ns | 187ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 678μs | 11.1μs | 111μs | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 310μs | 35.7ns | 138ns | 0 | 0 | 0 | 2.29 KB |
| #7850 | RunWafRealisticBenchmark |
net6.0 | 396μs | 72.3ns | 270ns | 0 | 0 | 0 | 4.55 KB |
| #7850 | RunWafRealisticBenchmark |
netcoreapp3.1 | 818μs | 14.8μs | 148μs | 0 | 0 | 0 | 4.48 KB |
| #7850 | RunWafRealisticBenchmark |
net472 | 429μs | 56.7ns | 220ns | 0 | 0 | 0 | 4.66 KB |
| #7850 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 291μs | 74.3ns | 288ns | 0 | 0 | 0 | 2.24 KB |
| #7850 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 300μs | 38.9ns | 140ns | 0 | 0 | 0 | 2.22 KB |
| #7850 | RunWafRealisticBenchmarkWithAttack |
net472 | 308μs | 27.4ns | 106ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 61.3μs | 127ns | 491ns | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 71.5μs | 317ns | 1.55μs | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.00768ns | 0.00289ns | 0.0112ns | 0 | 0 | 0 | 0 b |
| #7850 | SendRequest |
net6.0 | 60.4μs | 69.3ns | 250ns | 0 | 0 | 0 | 14.52 KB |
| #7850 | SendRequest |
netcoreapp3.1 | 71.2μs | 375ns | 1.95μs | 0 | 0 | 0 | 17.42 KB |
| #7850 | SendRequest |
net472 | 0.00624ns | 0.00185ns | 0.00718ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7850
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1
0 b
1 B
1 B
∞
Fewer allocations 🎉 in #7850
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0
7 B
4 B
-3 B
-42.86%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472
73 B
0 b
-73 B
-100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472
48 B
0 b
-48 B
-100.00%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 | 0 b | 1 B | 1 B | ∞ |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 | 7 B | 4 B | -3 B | -42.86% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 | 73 B | 0 b | -73 B | -100.00% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 | 48 B | 0 b | -48 B | -100.00% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.91ms | 5.91μs | 22.1μs | 0 | 0 | 0 | 640.01 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.05ms | 8.75μs | 32.7μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.66ms | 629ns | 2.27μs | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.41ms | 221ns | 854ns | 0 | 0 | 0 | 7 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.73ms | 245ns | 850ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 1.98ms | 422ns | 1.58μs | 0 | 0 | 0 | 73 B |
| master | OptimizedCharSliceWithPool |
net6.0 | 822μs | 67.2ns | 260ns | 0 | 0 | 0 | 3 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 827μs | 63.5ns | 229ns | 0 | 0 | 0 | 0 b |
| master | OptimizedCharSliceWithPool |
net472 | 1.14ms | 130ns | 488ns | 0 | 0 | 0 | 48 B |
| #7850 | OriginalCharSlice |
net6.0 | 1.91ms | 1.37μs | 5.11μs | 0 | 0 | 0 | 640.01 KB |
| #7850 | OriginalCharSlice |
netcoreapp3.1 | 2.11ms | 1.71μs | 6.63μs | 0 | 0 | 0 | 640 KB |
| #7850 | OriginalCharSlice |
net472 | 2.6ms | 121ns | 469ns | 100 | 0 | 0 | 641.95 KB |
| #7850 | OptimizedCharSlice |
net6.0 | 1.41ms | 70.2ns | 272ns | 0 | 0 | 0 | 4 B |
| #7850 | OptimizedCharSlice |
netcoreapp3.1 | 1.65ms | 471ns | 1.82μs | 0 | 0 | 0 | 1 B |
| #7850 | OptimizedCharSlice |
net472 | 1.91ms | 400ns | 1.55μs | 0 | 0 | 0 | 0 b |
| #7850 | OptimizedCharSliceWithPool |
net6.0 | 878μs | 45.2ns | 169ns | 0 | 0 | 0 | 3 B |
| #7850 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 812μs | 124ns | 482ns | 0 | 0 | 0 | 1 B |
| #7850 | OptimizedCharSliceWithPool |
net472 | 1.15ms | 168ns | 651ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7850
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
41.77 KB
42.78 KB
1.01 KB
2.41%
Fewer allocations 🎉 in #7850
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
56.32 KB
55.87 KB
-452 B
-0.80%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.77 KB | 42.78 KB | 1.01 KB | 2.41% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 56.32 KB | 55.87 KB | -452 B | -0.80% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 719μs | 4.05μs | 28.9μs | 0 | 0 | 0 | 41.77 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 692μs | 3.85μs | 24.4μs | 0 | 0 | 0 | 41.89 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 895μs | 2.42μs | 9.05μs | 8.33 | 0 | 0 | 56.32 KB |
| #7850 | WriteAndFlushEnrichedTraces |
net6.0 | 693μs | 3.26μs | 12.6μs | 0 | 0 | 0 | 42.78 KB |
| #7850 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 718μs | 4.02μs | 25.1μs | 0 | 0 | 0 | 41.77 KB |
| #7850 | WriteAndFlushEnrichedTraces |
net472 | 908μs | 2.74μs | 10.6μs | 4.46 | 0 | 0 | 55.87 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.87μs | 9.43ns | 43.2ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.62μs | 8.37ns | 32.4ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.74μs | 3.82ns | 14.8ns | 0.15 | 0.0137 | 0 | 987 B |
| #7850 | ExecuteNonQuery |
net6.0 | 1.84μs | 1.6ns | 6.19ns | 0 | 0 | 0 | 1.02 KB |
| #7850 | ExecuteNonQuery |
netcoreapp3.1 | 2.64μs | 10.8ns | 41.7ns | 0 | 0 | 0 | 1.02 KB |
| #7850 | ExecuteNonQuery |
net472 | 2.79μs | 4.41ns | 17.1ns | 0.152 | 0.0138 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.74μs | 7.62ns | 29.5ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.23μs | 10.9ns | 47.5ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.68μs | 4.13ns | 16ns | 0.165 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.75μs | 8.79ns | 39.3ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.47μs | 8.41ns | 32.6ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.85μs | 3.8ns | 14.7ns | 0.172 | 0 | 0 | 1.1 KB |
| #7850 | CallElasticsearch |
net6.0 | 1.7μs | 8.34ns | 33.4ns | 0 | 0 | 0 | 1.03 KB |
| #7850 | CallElasticsearch |
netcoreapp3.1 | 2.43μs | 6.45ns | 25ns | 0 | 0 | 0 | 1.03 KB |
| #7850 | CallElasticsearch |
net472 | 3.49μs | 1.38ns | 5.18ns | 0.158 | 0 | 0 | 1.04 KB |
| #7850 | CallElasticsearchAsync |
net6.0 | 1.84μs | 4.82ns | 18.7ns | 0 | 0 | 0 | 1.01 KB |
| #7850 | CallElasticsearchAsync |
netcoreapp3.1 | 2.4μs | 11.7ns | 49.6ns | 0 | 0 | 0 | 1.08 KB |
| #7850 | CallElasticsearchAsync |
net472 | 3.75μs | 2.96ns | 11.1ns | 0.167 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.93μs | 6.13ns | 23.7ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.49μs | 9ns | 34.9ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.65μs | 1.75ns | 6.78ns | 0.133 | 0 | 0 | 915 B |
| #7850 | ExecuteAsync |
net6.0 | 1.89μs | 6.23ns | 24.1ns | 0 | 0 | 0 | 952 B |
| #7850 | ExecuteAsync |
netcoreapp3.1 | 2.41μs | 9.08ns | 35.2ns | 0 | 0 | 0 | 952 B |
| #7850 | ExecuteAsync |
net472 | 2.58μs | 7.53ns | 29.2ns | 0.141 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 6.91μs | 20.1ns | 75.3ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 8.64μs | 26ns | 101ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.1μs | 8.02ns | 31.1ns | 0.483 | 0 | 0 | 3.18 KB |
| #7850 | SendAsync |
net6.0 | 6.89μs | 3.67ns | 14.2ns | 0 | 0 | 0 | 2.36 KB |
| #7850 | SendAsync |
netcoreapp3.1 | 8.64μs | 32.9ns | 123ns | 0 | 0 | 0 | 2.9 KB |
| #7850 | SendAsync |
net472 | 12μs | 9.41ns | 36.5ns | 0.481 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7850
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472
57.34 KB
65.54 KB
8.19 KB
14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
278.53 KB
286.72 KB
8.19 KB
2.94%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0
43.64 KB
44.9 KB
1.26 KB
2.88%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
255.46 KB
258.18 KB
2.73 KB
1.07%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
278.04 KB
280.36 KB
2.32 KB
0.83%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 | 57.34 KB | 65.54 KB | 8.19 KB | 14.29% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 278.53 KB | 286.72 KB | 8.19 KB | 2.94% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 43.64 KB | 44.9 KB | 1.26 KB | 2.88% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 255.46 KB | 258.18 KB | 2.73 KB | 1.07% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 278.04 KB | 280.36 KB | 2.32 KB | 0.83% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 46.1μs | 270ns | 2.22μs | 0 | 0 | 0 | 43.64 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 50.1μs | 291ns | 2.29μs | 0 | 0 | 0 | 42.7 KB |
| master | StringConcatBenchmark |
net472 | 56.7μs | 297ns | 1.39μs | 0 | 0 | 0 | 57.34 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 490μs | 2.3μs | 9.22μs | 0 | 0 | 0 | 278.04 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 506μs | 2.28μs | 8.54μs | 0 | 0 | 0 | 255.46 KB |
| master | StringConcatAspectBenchmark |
net472 | 410μs | 2.31μs | 15μs | 0 | 0 | 0 | 278.53 KB |
| #7850 | StringConcatBenchmark |
net6.0 | 48μs | 274ns | 2.31μs | 0 | 0 | 0 | 44.9 KB |
| #7850 | StringConcatBenchmark |
netcoreapp3.1 | 48.7μs | 295ns | 2.84μs | 0 | 0 | 0 | 42.9 KB |
| #7850 | StringConcatBenchmark |
net472 | 56.8μs | 252ns | 1.16μs | 0 | 0 | 0 | 65.54 KB |
| #7850 | StringConcatAspectBenchmark |
net6.0 | 490μs | 2.04μs | 7.35μs | 0 | 0 | 0 | 280.36 KB |
| #7850 | StringConcatAspectBenchmark |
netcoreapp3.1 | 533μs | 1.55μs | 5.79μs | 0 | 0 | 0 | 258.18 KB |
| #7850 | StringConcatAspectBenchmark |
net472 | 412μs | 2.18μs | 10.7μs | 0 | 0 | 0 | 286.72 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.59μs | 14.1ns | 68.9ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.65μs | 14.7ns | 56.9ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
net472 | 4.19μs | 3.84ns | 14.9ns | 0.248 | 0 | 0 | 1.64 KB |
| #7850 | EnrichedLog |
net6.0 | 2.75μs | 4.45ns | 15.4ns | 0 | 0 | 0 | 1.7 KB |
| #7850 | EnrichedLog |
netcoreapp3.1 | 3.6μs | 1.88ns | 7.03ns | 0 | 0 | 0 | 1.7 KB |
| #7850 | EnrichedLog |
net472 | 3.83μs | 5.93ns | 23ns | 0.251 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 124μs | 55.1ns | 199ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 129μs | 208ns | 807ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 169μs | 296ns | 1.14μs | 0 | 0 | 0 | 4.52 KB |
| #7850 | EnrichedLog |
net6.0 | 122μs | 73.8ns | 256ns | 0 | 0 | 0 | 4.31 KB |
| #7850 | EnrichedLog |
netcoreapp3.1 | 127μs | 332ns | 1.24μs | 0 | 0 | 0 | 4.31 KB |
| #7850 | EnrichedLog |
net472 | 167μs | 255ns | 987ns | 0 | 0 | 0 | 4.51 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 5.16μs | 21.6ns | 80.7ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.77μs | 15.2ns | 58.7ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.55μs | 7.72ns | 29.9ns | 0.301 | 0 | 0 | 2.08 KB |
| #7850 | EnrichedLog |
net6.0 | 4.97μs | 9.68ns | 37.5ns | 0 | 0 | 0 | 2.26 KB |
| #7850 | EnrichedLog |
netcoreapp3.1 | 6.86μs | 26.9ns | 104ns | 0 | 0 | 0 | 2.26 KB |
| #7850 | EnrichedLog |
net472 | 7.66μs | 4.35ns | 16.3ns | 0.302 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.93μs | 9.28ns | 35.9ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.61μs | 4.31ns | 16.7ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.11μs | 1.28ns | 4.62ns | 0.185 | 0 | 0 | 1.2 KB |
| #7850 | SendReceive |
net6.0 | 1.91μs | 8.94ns | 34.6ns | 0 | 0 | 0 | 1.2 KB |
| #7850 | SendReceive |
netcoreapp3.1 | 2.56μs | 13.3ns | 61ns | 0 | 0 | 0 | 1.2 KB |
| #7850 | SendReceive |
net472 | 3.01μs | 2.53ns | 9.79ns | 0.181 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.33μs | 10.9ns | 42.3ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.75μs | 8.04ns | 30.1ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.96μs | 6.28ns | 24.3ns | 0.313 | 0 | 0 | 2.03 KB |
| #7850 | EnrichedLog |
net6.0 | 4.38μs | 1.9ns | 7.37ns | 0 | 0 | 0 | 1.58 KB |
| #7850 | EnrichedLog |
netcoreapp3.1 | 5.64μs | 6.79ns | 25.4ns | 0 | 0 | 0 | 1.63 KB |
| #7850 | EnrichedLog |
net472 | 6.48μs | 10.1ns | 39.2ns | 0.294 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 786ns | 3.71ns | 14.4ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 1.01μs | 4.75ns | 18.4ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 943ns | 0.246ns | 0.92ns | 0.09 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 906ns | 4.96ns | 30.6ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.19μs | 6.13ns | 31.8ns | 0 | 0 | 0 | 697 B |
| master | StartFinishScope |
net472 | 1.16μs | 0.86ns | 3.33ns | 0.104 | 0 | 0 | 658 B |
| #7850 | StartFinishSpan |
net6.0 | 789ns | 1.62ns | 6.27ns | 0 | 0 | 0 | 576 B |
| #7850 | StartFinishSpan |
netcoreapp3.1 | 963ns | 4.92ns | 22ns | 0 | 0 | 0 | 576 B |
| #7850 | StartFinishSpan |
net472 | 951ns | 0.152ns | 0.569ns | 0.0906 | 0 | 0 | 578 B |
| #7850 | StartFinishScope |
net6.0 | 955ns | 4.54ns | 17.6ns | 0 | 0 | 0 | 696 B |
| #7850 | StartFinishScope |
netcoreapp3.1 | 1.2μs | 5.3ns | 19.8ns | 0 | 0 | 0 | 696 B |
| #7850 | StartFinishScope |
net472 | 1.15μs | 2.5ns | 9.67ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.06μs | 5.65ns | 28.2ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.47μs | 6.59ns | 23.8ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.46μs | 0.443ns | 1.6ns | 0.102 | 0 | 0 | 658 B |
| #7850 | RunOnMethodBegin |
net6.0 | 1.03μs | 5.46ns | 28.3ns | 0 | 0 | 0 | 696 B |
| #7850 | RunOnMethodBegin |
netcoreapp3.1 | 1.42μs | 6.02ns | 23.3ns | 0 | 0 | 0 | 696 B |
| #7850 | RunOnMethodBegin |
net472 | 1.44μs | 0.617ns | 2.31ns | 0.101 | 0 | 0 | 658 B |
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 7 occurrences of : + peer.service: MyTableName,
[...]
+ _dd.peer.service.source: tablename
1 occurrences of : + peer.service: MyEventBus,
[...]
+ _dd.peer.service.source: rulename
2 occurrences of : + peer.service: MyStreamName,
[...]
+ _dd.peer.service.source: streamname
4 occurrences of : + peer.service: MyTopic,
[...]
+ _dd.peer.service.source: topicname
16 occurrences of : + peer.service: MyAsyncSQSQueue,
[...]
+ _dd.peer.service.source: queuename
16 occurrences of : + peer.service: MyAsyncSQSQueue2,
[...]
+ _dd.peer.service.source: queuename
2 occurrences of : + peer.service: StepFunction,
[...]
+ _dd.peer.service.source: statemachinename
|
Summary of changes
Fixes the Serverless Service Representation (SSR) for Dotnet.
In serverless environments, sets peer.service tag for outbound AWS managed service spans to {service type}.{region}.amazonaws.com:
SQS: sqs.us-east-1.amazonaws.com
SNS: sns.us-east-1.amazonaws.com
Kinesis: kinesis.us-east-1.amazonaws.com
Eventbridge: events.us-east-1.amazonaws.com
s3: bucket-name.s3.us-east-1.amazonaws.com
Dynamodb: dynamodb.us-east-1.amazonaws.com
Sets peer.service.source to peer.service for these serverless cases.
Adds DerivePeerService function in Util/PeerServiceHelpers to do the above assignment.
Reason for change
Before SSR implementation:

After SSR implementation:
Implementation details
Test coverage
Other details