Skip to content

Add testing for latest Microsoft.Extensions.Telemetry version #7817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

Add testing for latest Microsoft.Extensions.Telemetry version #7817

merged 1 commit into from
Nov 21, 2025

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Nov 14, 2025

Summary of changes

Adds testing for 10.x.x of Microsoft.Extensions.Telemetry

Reason for change

We don't test it currently, though we do instrument it

Implementation details

Update the generated versions to make sure we test it

Test coverage

More now

@andrewlock andrewlock added area:tests unit tests, integration tests area:integrations labels Nov 14, 2025
@andrewlock andrewlock requested review from a team as code owners November 14, 2025 12:34
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 14, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7817) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration74.26 ± (74.13 - 74.77) ms74.93 ± (74.83 - 75.40) ms+0.9%✅⬆️
.NET Framework 4.8 - Bailout
duration79.17 ± (78.96 - 79.70) ms80.33 ± (79.90 - 80.70) ms+1.5%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1107.89 ± (1114.89 - 1125.86) ms1106.44 ± (1106.83 - 1116.06) ms-0.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.59 ± (22.52 - 22.67) ms22.92 ± (22.85 - 22.99) ms+1.4%✅⬆️
process.time_to_main_ms85.70 ± (85.32 - 86.08) ms88.14 ± (87.75 - 88.54) ms+2.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.92) MB10.92 ± (10.92 - 10.92) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.65 ± (22.58 - 22.71) ms22.78 ± (22.72 - 22.85) ms+0.6%✅⬆️
process.time_to_main_ms88.50 ± (88.12 - 88.89) ms87.13 ± (86.82 - 87.44) ms-1.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.96 ± (10.95 - 10.96) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms219.65 ± (218.35 - 220.94) ms219.48 ± (218.23 - 220.74) ms-0.1%✅
process.time_to_main_ms544.30 ± (543.17 - 545.44) ms542.52 ± (541.38 - 543.66) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.64 ± (52.63 - 52.66) MB52.51 ± (52.49 - 52.52) MB-0.3%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.5%✅
.NET 6 - Baseline
process.internal_duration_ms21.64 ± (21.57 - 21.71) ms21.70 ± (21.63 - 21.77) ms+0.3%✅⬆️
process.time_to_main_ms75.54 ± (75.15 - 75.94) ms75.49 ± (75.12 - 75.87) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.60) MB10.63 ± (10.63 - 10.63) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.48 ± (21.42 - 21.54) ms21.84 ± (21.75 - 21.92) ms+1.6%✅⬆️
process.time_to_main_ms75.67 ± (75.38 - 75.96) ms78.13 ± (77.75 - 78.51) ms+3.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.65) MB10.66 ± (10.66 - 10.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms204.49 ± (203.24 - 205.74) ms204.74 ± (203.38 - 206.09) ms+0.1%✅⬆️
process.time_to_main_ms510.25 ± (509.14 - 511.35) ms505.78 ± (504.75 - 506.82) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.81 ± (51.78 - 51.85) MB51.53 ± (51.49 - 51.57) MB-0.5%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%✅
.NET 8 - Baseline
process.internal_duration_ms19.97 ± (19.90 - 20.04) ms19.70 ± (19.63 - 19.76) ms-1.4%✅
process.time_to_main_ms74.49 ± (74.15 - 74.84) ms73.87 ± (73.56 - 74.19) ms-0.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.65 ± (7.65 - 7.65) MB7.65 ± (7.64 - 7.65) MB-0.0%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.79 ± (19.73 - 19.85) ms19.74 ± (19.66 - 19.81) ms-0.3%✅
process.time_to_main_ms75.58 ± (75.28 - 75.88) ms75.63 ± (75.24 - 76.02) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.72) MB7.71 ± (7.70 - 7.72) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms191.13 ± (190.12 - 192.14) ms189.67 ± (188.67 - 190.67) ms-0.8%✅
process.time_to_main_ms493.09 ± (492.05 - 494.13) ms483.90 ± (482.74 - 485.07) ms-1.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed39.07 ± (39.03 - 39.11) MB38.91 ± (38.87 - 38.95) MB-0.4%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration191.86 ± (191.84 - 192.60) ms192.11 ± (192.03 - 192.87) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration195.95 ± (195.91 - 196.60) ms195.95 ± (195.71 - 196.29) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1164.92 ± (1169.57 - 1179.23) ms1165.58 ± (1169.01 - 1177.86) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.82 ± (187.44 - 188.19) ms188.21 ± (187.83 - 188.59) ms+0.2%✅⬆️
process.time_to_main_ms80.30 ± (80.10 - 80.50) ms80.69 ± (80.46 - 80.91) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.10) MB16.05 ± (16.02 - 16.08) MB-0.2%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms187.13 ± (186.84 - 187.42) ms187.54 ± (187.23 - 187.85) ms+0.2%✅⬆️
process.time_to_main_ms81.25 ± (81.14 - 81.36) ms81.89 ± (81.74 - 82.03) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.15 ± (16.12 - 16.18) MB16.15 ± (16.12 - 16.18) MB-0.0%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.1%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms391.47 ± (388.78 - 394.15) ms392.66 ± (390.26 - 395.07) ms+0.3%✅⬆️
process.time_to_main_ms516.96 ± (516.32 - 517.61) ms517.13 ± (516.48 - 517.78) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed62.67 ± (62.52 - 62.82) MB62.74 ± (62.58 - 62.89) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.78 ± (192.33 - 193.24) ms191.80 ± (191.48 - 192.12) ms-0.5%✅
process.time_to_main_ms69.82 ± (69.63 - 70.00) ms69.57 ± (69.43 - 69.72) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.16 ± (16.03 - 16.28) MB16.09 ± (15.95 - 16.23) MB-0.4%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.6%✅
.NET 6 - Bailout
process.internal_duration_ms191.11 ± (190.86 - 191.36) ms191.51 ± (191.18 - 191.84) ms+0.2%✅⬆️
process.time_to_main_ms70.54 ± (70.45 - 70.63) ms70.62 ± (70.50 - 70.75) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.03 ± (15.88 - 16.19) MB16.07 ± (15.92 - 16.22) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.0%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms410.84 ± (407.72 - 413.97) ms407.14 ± (404.72 - 409.56) ms-0.9%✅
process.time_to_main_ms487.25 ± (486.64 - 487.86) ms482.62 ± (481.97 - 483.28) ms-0.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.17 ± (62.02 - 62.32) MB62.39 ± (62.26 - 62.51) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms189.80 ± (189.45 - 190.15) ms189.84 ± (189.52 - 190.16) ms+0.0%✅⬆️
process.time_to_main_ms69.12 ± (68.91 - 69.32) ms68.93 ± (68.78 - 69.09) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.76 ± (11.73 - 11.78) MB11.75 ± (11.72 - 11.78) MB-0.0%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.4%✅
.NET 8 - Bailout
process.internal_duration_ms189.01 ± (188.69 - 189.32) ms189.34 ± (189.02 - 189.67) ms+0.2%✅⬆️
process.time_to_main_ms70.03 ± (69.90 - 70.17) ms70.25 ± (70.15 - 70.35) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.83 ± (11.78 - 11.88) MB11.79 ± (11.76 - 11.82) MB-0.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.2%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms362.56 ± (361.02 - 364.10) ms361.19 ± (359.56 - 362.81) ms-0.4%✅
process.time_to_main_ms465.61 ± (464.81 - 466.41) ms457.51 ± (456.99 - 458.02) ms-1.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.50 ± (50.46 - 50.54) MB50.30 ± (50.28 - 50.33) MB-0.4%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (75ms)  : 71, 79
    master - mean (74ms)  : 70, 79

    section Bailout
    This PR (7817) - mean (80ms)  : 75, 86
    master - mean (79ms)  : 74, 85

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (1,111ms)  : 1046, 1177
    master - mean (1,120ms)  : 1042, 1199
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (118ms)  : 111, 125
    master - mean (116ms)  : 109, 122

    section Bailout
    This PR (7817) - mean (117ms)  : 112, 122
    master - mean (118ms)  : 112, 125

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (790ms)  : 757, 823
    master - mean (796ms)  : 758, 835
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (104ms)  : 97, 112
    master - mean (104ms)  : 97, 111

    section Bailout
    This PR (7817) - mean (107ms)  : 98, 115
    master - mean (104ms)  : 99, 109

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (742ms)  : 700, 785
    master - mean (752ms)  : 698, 806
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (102ms)  : 95, 110
    master - mean (103ms)  : 95, 110

    section Bailout
    This PR (7817) - mean (104ms)  : 95, 113
    master - mean (104ms)  : 98, 109

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (704ms)  : 671, 737
    master - mean (714ms)  : 685, 743
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (192ms)  : 188, 197
    master - mean (192ms)  : 188, 196

    section Bailout
    This PR (7817) - mean (196ms)  : 193, 199
    master - mean (196ms)  : 193, 200

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (1,173ms)  : 1111, 1236
    master - mean (1,174ms)  : 1100, 1249
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (277ms)  : 272, 282
    master - mean (277ms)  : 269, 284

    section Bailout
    This PR (7817) - mean (277ms)  : 273, 282
    master - mean (276ms)  : 273, 280

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (939ms)  : 900, 979
    master - mean (938ms)  : 896, 981
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (270ms)  : 265, 275
    master - mean (271ms)  : 265, 277

    section Bailout
    This PR (7817) - mean (270ms)  : 266, 275
    master - mean (270ms)  : 267, 272

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (922ms)  : 874, 970
    master - mean (930ms)  : 870, 991
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7817) - mean (269ms)  : 264, 273
    master - mean (269ms)  : 264, 273

    section Bailout
    This PR (7817) - mean (269ms)  : 266, 272
    master - mean (268ms)  : 264, 272

    section CallTarget+Inlining+NGEN
    This PR (7817) - mean (851ms)  : 829, 873
    master - mean (858ms)  : 840, 877
Loading

@andrewlock andrewlock merged commit 5b8194a into master Nov 21, 2025
69 checks passed
@andrewlock andrewlock deleted the andrew/testing-extendedlogger branch November 21, 2025 12:28
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:integrations area:tests unit tests, integration tests

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @NachoEchevarria