Skip to content

Fix GRPC flaky tests. #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2025
Merged

Fix GRPC flaky tests. #7800

merged 3 commits into from
Nov 12, 2025
+9 −9

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Nov 11, 2025 •
edited
Loading

Summary of changes

The GrpcHttpTests.SubmitTraces test was failing intermittently with exit code 134 (SIGABRT) due to a known race condition in gRPC.Net.Client versions < 2.43.0. The test had existing skip logic to handle this condition, but it wasn't working.

When the test application crashed with ObjectDisposedException, the exception handling flow was:

  1. RunSampleAndWaitForExit called WaitForProcessResult
  2. WaitForProcessResult threw ExitCodeException at line 212 before returning
  3. The assignment processResult = await RunSampleAndWaitForExit(...) never completed
  4. processResult remained null in the catch block
  5. The skip condition checked processResult is not null → false
  6. Test failed instead of being skipped

The StandardError containing "ObjectDisposedException" was collected but never made available to the catch block for evaluation.

As a solution, now we pass standardError as the message parameter when throwing ExitCodeException, making it accessible via ex.Message in catch blocks.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:tests unit tests, integration tests label Nov 11, 2025
@NachoEchevarria NachoEchevarria changed the title Fix tests Fix GRPC flaky tests Nov 11, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 11, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7800) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration76.01 ± (75.91 - 76.54) ms74.66 ± (74.64 - 75.16) ms-1.8%✅
.NET Framework 4.8 - Bailout
duration81.16 ± (80.88 - 81.52) ms79.49 ± (79.43 - 80.03) ms-2.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1115.67 ± (1118.53 - 1129.48) ms1116.98 ± (1115.95 - 1125.31) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms23.18 ± (23.07 - 23.29) ms23.09 ± (23.01 - 23.16) ms-0.4%✅
process.time_to_main_ms89.02 ± (88.62 - 89.42) ms87.84 ± (87.53 - 88.16) ms-1.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.90 ± (10.89 - 10.90) MB-0.1%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.98 ± (22.89 - 23.07) ms22.74 ± (22.68 - 22.79) ms-1.0%✅
process.time_to_main_ms89.07 ± (88.63 - 89.52) ms88.87 ± (88.54 - 89.20) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.94 ± (10.94 - 10.94) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms221.69 ± (220.39 - 222.98) ms219.50 ± (218.13 - 220.86) ms-1.0%✅
process.time_to_main_ms554.33 ± (553.23 - 555.42) ms547.95 ± (546.74 - 549.16) ms-1.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.74 ± (52.72 - 52.77) MB52.52 ± (52.50 - 52.54) MB-0.4%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms21.71 ± (21.65 - 21.77) ms21.64 ± (21.59 - 21.70) ms-0.3%✅
process.time_to_main_ms76.13 ± (75.83 - 76.44) ms75.17 ± (74.91 - 75.42) ms-1.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.59 ± (10.59 - 10.59) MB10.62 ± (10.62 - 10.62) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.65 ± (21.60 - 21.71) ms21.61 ± (21.55 - 21.68) ms-0.2%✅
process.time_to_main_ms78.17 ± (77.85 - 78.48) ms76.83 ± (76.50 - 77.16) ms-1.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.64 ± (10.64 - 10.64) MB10.66 ± (10.66 - 10.67) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.22 ± (210.53 - 215.91) ms207.39 ± (205.99 - 208.79) ms-2.7%✅
process.time_to_main_ms516.32 ± (515.25 - 517.38) ms513.79 ± (512.75 - 514.82) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.81 ± (51.78 - 51.83) MB51.65 ± (51.62 - 51.68) MB-0.3%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.80 ± (19.74 - 19.85) ms19.81 ± (19.74 - 19.87) ms+0.1%✅⬆️
process.time_to_main_ms75.20 ± (74.93 - 75.46) ms75.02 ± (74.71 - 75.33) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.64 ± (7.64 - 7.65) MB7.65 ± (7.64 - 7.65) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.86 ± (19.81 - 19.92) ms19.66 ± (19.61 - 19.72) ms-1.0%✅
process.time_to_main_ms76.63 ± (76.34 - 76.92) ms75.53 ± (75.25 - 75.82) ms-1.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.69 - 7.70) MB7.70 ± (7.69 - 7.71) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms190.55 ± (189.68 - 191.41) ms192.20 ± (191.20 - 193.19) ms+0.9%✅⬆️
process.time_to_main_ms490.93 ± (490.03 - 491.82) ms487.72 ± (486.42 - 489.02) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed39.12 ± (39.09 - 39.16) MB38.79 ± (38.76 - 38.83) MB-0.8%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.91 ± (192.80 - 193.64) ms191.80 ± (191.95 - 192.73) ms-0.6%✅
.NET Framework 4.8 - Bailout
duration196.21 ± (196.07 - 196.78) ms196.15 ± (195.98 - 196.58) ms-0.0%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1158.48 ± (1166.13 - 1176.14) ms1164.45 ± (1172.35 - 1183.88) ms+0.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms188.15 ± (187.77 - 188.53) ms187.81 ± (187.40 - 188.22) ms-0.2%✅
process.time_to_main_ms80.88 ± (80.64 - 81.12) ms80.60 ± (80.39 - 80.82) ms-0.3%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.03 ± (16.00 - 16.05) MB16.03 ± (16.01 - 16.06) MB+0.0%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms187.06 ± (186.75 - 187.37) ms186.81 ± (186.46 - 187.15) ms-0.1%✅
process.time_to_main_ms81.83 ± (81.69 - 81.96) ms81.86 ± (81.71 - 82.01) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.12 ± (16.10 - 16.15) MB16.16 ± (16.13 - 16.18) MB+0.2%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.6%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms391.50 ± (388.85 - 394.14) ms394.07 ± (391.49 - 396.65) ms+0.7%✅⬆️
process.time_to_main_ms515.07 ± (514.44 - 515.70) ms516.67 ± (516.09 - 517.25) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed62.68 ± (62.53 - 62.83) MB62.64 ± (62.48 - 62.80) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms191.20 ± (190.88 - 191.52) ms190.81 ± (190.50 - 191.11) ms-0.2%✅
process.time_to_main_ms69.95 ± (69.77 - 70.14) ms69.74 ± (69.55 - 69.93) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.90 ± (15.75 - 16.06) MB16.10 ± (15.97 - 16.24) MB+1.3%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)19 ± (18 - 19)+3.4%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms190.34 ± (190.04 - 190.64) ms189.79 ± (189.58 - 189.99) ms-0.3%✅
process.time_to_main_ms70.70 ± (70.60 - 70.80) ms70.60 ± (70.53 - 70.67) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.69 ± (15.52 - 15.86) MB16.22 ± (16.08 - 16.36) MB+3.4%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 19)19 ± (19 - 19)+3.5%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms406.09 ± (403.14 - 409.03) ms412.36 ± (409.28 - 415.44) ms+1.5%✅⬆️
process.time_to_main_ms485.90 ± (485.25 - 486.54) ms487.83 ± (487.00 - 488.66) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.07 ± (61.89 - 62.25) MB62.05 ± (61.91 - 62.20) MB-0.0%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.37 ± (189.92 - 190.81) ms189.39 ± (189.09 - 189.69) ms-0.5%✅
process.time_to_main_ms69.51 ± (69.31 - 69.70) ms69.01 ± (68.89 - 69.14) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.71 ± (11.68 - 11.73) MB11.72 ± (11.69 - 11.74) MB+0.1%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.0%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms189.13 ± (188.92 - 189.35) ms188.48 ± (188.27 - 188.69) ms-0.3%✅
process.time_to_main_ms70.50 ± (70.40 - 70.60) ms70.03 ± (69.93 - 70.12) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.67 ± (11.58 - 11.76) MB11.73 ± (11.66 - 11.81) MB+0.5%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms359.15 ± (357.69 - 360.60) ms358.56 ± (357.18 - 359.94) ms-0.2%✅
process.time_to_main_ms465.60 ± (465.02 - 466.18) ms460.40 ± (459.73 - 461.08) ms-1.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.67 ± (50.63 - 50.71) MB50.26 ± (50.22 - 50.30) MB-0.8%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.3%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (75ms)  : 71, 79
    master - mean (76ms)  : 72, 81

    section Bailout
    This PR (7800) - mean (80ms)  : 75, 84
    master - mean (81ms)  : 77, 86

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (1,121ms)  : 1057, 1185
    master - mean (1,124ms)  : 1038, 1210
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (119ms)  : 112, 126
    master - mean (120ms)  : 112, 128

    section Bailout
    This PR (7800) - mean (119ms)  : 113, 125
    master - mean (120ms)  : 112, 128

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (809ms)  : 770, 847
    master - mean (816ms)  : 782, 849
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (104ms)  : 99, 109
    master - mean (105ms)  : 100, 110

    section Bailout
    This PR (7800) - mean (105ms)  : 99, 112
    master - mean (107ms)  : 101, 112

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (757ms)  : 718, 797
    master - mean (764ms)  : 710, 819
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (104ms)  : 98, 109
    master - mean (103ms)  : 98, 108

    section Bailout
    This PR (7800) - mean (104ms)  : 99, 109
    master - mean (105ms)  : 100, 110

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (723ms)  : 695, 752
    master - mean (720ms)  : 693, 747
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (192ms)  : 189, 196
    master - mean (193ms)  : 189, 197

    section Bailout
    This PR (7800) - mean (196ms)  : 193, 199
    master - mean (196ms)  : 193, 200

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (1,178ms)  : 1087, 1269
    master - mean (1,171ms)  : 1093, 1249
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (277ms)  : 271, 283
    master - mean (277ms)  : 272, 283

    section Bailout
    This PR (7800) - mean (277ms)  : 273, 282
    master - mean (277ms)  : 274, 280

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (951ms)  : 903, 999
    master - mean (948ms)  : 905, 991
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (269ms)  : 265, 273
    master - mean (269ms)  : 264, 275

    section Bailout
    This PR (7800) - mean (269ms)  : 265, 272
    master - mean (269ms)  : 266, 272

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (934ms)  : 874, 994
    master - mean (928ms)  : 884, 973
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7800) - mean (268ms)  : 264, 272
    master - mean (270ms)  : 263, 276

    section Bailout
    This PR (7800) - mean (268ms)  : 264, 271
    master - mean (269ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (7800) - mean (850ms)  : 827, 873
    master - mean (856ms)  : 837, 874
Loading

@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7800 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.133
  • 2 benchmarks are slower, with geometric mean 1.150
  • 1 benchmarks have fewer allocations
  • 6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.7μs 60ns 365ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 13.6μs 69.5ns 311ns 0 0 0 5.67 KB
master StartStopWithChild net472 21.7μs 115ns 619ns 0.994 0.331 0.11 6.06 KB
#7800 StartStopWithChild net6.0 11μs 59ns 306ns 0 0 0 5.52 KB
#7800 StartStopWithChild netcoreapp3.1 13.8μs 60.6ns 235ns 0 0 0 5.7 KB
#7800 StartStopWithChild net472 22.2μs 117ns 583ns 0.896 0.224 0 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7800

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.35 KB 46 B 1.39%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 935μs 70.9ns 256ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 214ns 831ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.21ms 68ns 263ns 0 0 0 3.31 KB
#7800 WriteAndFlushEnrichedTraces net6.0 952μs 109ns 410ns 0 0 0 2.71 KB
#7800 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 61.4ns 213ns 0 0 0 2.7 KB
#7800 WriteAndFlushEnrichedTraces net472 1.2ms 714ns 2.67μs 0 0 0 3.35 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.12μs 1.56ns 6.06ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.43μs 7.91ns 49.4ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.03μs 0.786ns 2.94ns 0.195 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7.21μs 36.9ns 169ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 9.22μs 36ns 139ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.67μs 4.4ns 17ns 0.726 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 326ns 1.41ns 5.82ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 406ns 1.98ns 8.17ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 298ns 0.0502ns 0.194ns 0.0434 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.35μs 3.3ns 12.8ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.85μs 4.37ns 16.9ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.7μs 2.97ns 11.5ns 0.603 0 0 3.8 KB
#7800 AllCycleSimpleBody net6.0 1.06μs 5.95ns 40.3ns 0 0 0 1.22 KB
#7800 AllCycleSimpleBody netcoreapp3.1 1.44μs 2.47ns 9.58ns 0 0 0 1.2 KB
#7800 AllCycleSimpleBody net472 1.02μs 0.361ns 1.35ns 0.195 0 0 1.23 KB
#7800 AllCycleMoreComplexBody net6.0 7.16μs 4.6ns 17.8ns 0 0 0 4.72 KB
#7800 AllCycleMoreComplexBody netcoreapp3.1 8.91μs 44.9ns 190ns 0 0 0 4.62 KB
#7800 AllCycleMoreComplexBody net472 7.62μs 2.99ns 11.6ns 0.727 0 0 4.74 KB
#7800 ObjectExtractorSimpleBody net6.0 323ns 0.661ns 2.56ns 0 0 0 280 B
#7800 ObjectExtractorSimpleBody netcoreapp3.1 402ns 1.93ns 7.96ns 0 0 0 272 B
#7800 ObjectExtractorSimpleBody net472 302ns 0.0216ns 0.0808ns 0.0438 0 0 281 B
#7800 ObjectExtractorMoreComplexBody net6.0 6.27μs 26.9ns 101ns 0 0 0 3.78 KB
#7800 ObjectExtractorMoreComplexBody netcoreapp3.1 7.85μs 21.9ns 82ns 0 0 0 3.69 KB
#7800 ObjectExtractorMoreComplexBody net472 6.72μs 2.52ns 9.77ns 0.573 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 78.7μs 223ns 865ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.9μs 208ns 805ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 44ns 170ns 4.9 0 0 32.51 KB
master EncodeLegacyArgs net6.0 144μs 19.2ns 74.2ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 328ns 1.27μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 267μs 39.7ns 154ns 0 0 0 2.16 KB
#7800 EncodeArgs net6.0 77.8μs 301ns 1.12μs 0 0 0 32.4 KB
#7800 EncodeArgs netcoreapp3.1 97.5μs 234ns 908ns 0 0 0 32.4 KB
#7800 EncodeArgs net472 109μs 16.6ns 64.2ns 4.92 0 0 32.5 KB
#7800 EncodeLegacyArgs net6.0 156μs 22.2ns 79.9ns 0 0 0 2.15 KB
#7800 EncodeLegacyArgs netcoreapp3.1 197μs 145ns 560ns 0 0 0 2.14 KB
#7800 EncodeLegacyArgs net472 262μs 35.3ns 137ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 393μs 60.6ns 227ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 413μs 343ns 1.33μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 431μs 35.5ns 138ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 284μs 35.2ns 132ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 696μs 11μs 104μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 310μs 47.2ns 177ns 0 0 0 2.29 KB
#7800 RunWafRealisticBenchmark net6.0 398μs 78.7ns 284ns 0 0 0 4.55 KB
#7800 RunWafRealisticBenchmark netcoreapp3.1 412μs 111ns 416ns 0 0 0 4.48 KB
#7800 RunWafRealisticBenchmark net472 429μs 63.7ns 238ns 0 0 0 4.66 KB
#7800 RunWafRealisticBenchmarkWithAttack net6.0 288μs 25.5ns 98.6ns 0 0 0 2.24 KB
#7800 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 679μs 12.4μs 124μs 0 0 0 2.22 KB
#7800 RunWafRealisticBenchmarkWithAttack net472 309μs 26ns 93.8ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 83.3ns 300ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 72.8μs 215ns 774ns 0 0 0 17.42 KB
master SendRequest net472 0.00198ns 0.000924ns 0.00358ns 0 0 0 0 b
#7800 SendRequest net6.0 61.7μs 84.7ns 317ns 0 0 0 14.52 KB
#7800 SendRequest netcoreapp3.1 72.6μs 89.2ns 334ns 0 0 0 17.42 KB
#7800 SendRequest net472 0.00691ns 0.00189ns 0.00731ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7800

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 4 B 7 B 3 B 75.00%

Fewer allocations 🎉 in #7800

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 3 B -1 B -25.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 2.03ms 1.6μs 5.98μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.11ms 6.93μs 25.9μs 0 0 0 640 KB
master OriginalCharSlice net472 2.68ms 103ns 400ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.34ms 360ns 1.39μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.72ms 392ns 1.52μs 0 0 0 1 B
master OptimizedCharSlice net472 1.9ms 243ns 940ns 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 799μs 16.9ns 63.2ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 813μs 200ns 776ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.14ms 78.4ns 304ns 0 0 0 0 b
#7800 OriginalCharSlice net6.0 1.93ms 6.92μs 26.8μs 0 0 0 640.01 KB
#7800 OriginalCharSlice netcoreapp3.1 2.1ms 787ns 2.94μs 0 0 0 640 KB
#7800 OriginalCharSlice net472 2.61ms 235ns 910ns 100 0 0 641.95 KB
#7800 OptimizedCharSlice net6.0 1.42ms 218ns 845ns 0 0 0 7 B
#7800 OptimizedCharSlice netcoreapp3.1 1.66ms 565ns 2.12μs 0 0 0 1 B
#7800 OptimizedCharSlice net472 1.97ms 248ns 961ns 0 0 0 0 b
#7800 OptimizedCharSliceWithPool net6.0 799μs 184ns 665ns 0 0 0 3 B
#7800 OptimizedCharSliceWithPool netcoreapp3.1 891μs 36.2ns 136ns 0 0 0 1 B
#7800 OptimizedCharSliceWithPool net472 1.15ms 95.2ns 356ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7800

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.158 848,694.38 982,529.46

Faster 🎉 in #7800

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.139 745,576.84 654,774.31

More allocations ⚠️ in #7800

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.63 KB 41.94 KB 313 B 0.75%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 655μs 1.39μs 5.4μs 0 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 745μs 457ns 1.77μs 0 0 0 42.01 KB
master WriteAndFlushEnrichedTraces net472 848μs 1.13μs 4.08μs 8.33 0 0 56.22 KB
#7800 WriteAndFlushEnrichedTraces net6.0 635μs 2.15μs 8.05μs 0 0 0 41.94 KB
#7800 WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 2.03μs 7.86μs 0 0 0 41.84 KB
#7800 WriteAndFlushEnrichedTraces net472 986μs 3.08μs 11.9μs 8.93 4.46 0 56.39 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.89μs 9.34ns 41.8ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.62μs 13.1ns 57.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.86μs 4.43ns 17.1ns 0.144 0.0144 0 987 B
#7800 ExecuteNonQuery net6.0 1.88μs 2.59ns 10ns 0 0 0 1.02 KB
#7800 ExecuteNonQuery netcoreapp3.1 2.6μs 10.2ns 38.1ns 0 0 0 1.02 KB
#7800 ExecuteNonQuery net472 2.96μs 15.6ns 76.4ns 0.154 0.014 0 988 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.73μs 7.87ns 31.5ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.2μs 11ns 49.3ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.5μs 4.32ns 16.7ns 0.157 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.86μs 1.32ns 5.12ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.46μs 11.1ns 42.9ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.65μs 3.41ns 13.2ns 0.164 0 0 1.1 KB
#7800 CallElasticsearch net6.0 1.72μs 9.13ns 47.5ns 0 0 0 1.03 KB
#7800 CallElasticsearch netcoreapp3.1 2.22μs 10.2ns 39.4ns 0 0 0 1.03 KB
#7800 CallElasticsearch net472 3.59μs 4.61ns 17.9ns 0.162 0 0 1.04 KB
#7800 CallElasticsearchAsync net6.0 1.84μs 9.44ns 46.2ns 0 0 0 1.01 KB
#7800 CallElasticsearchAsync netcoreapp3.1 2.51μs 8.96ns 33.5ns 0 0 0 1.08 KB
#7800 CallElasticsearchAsync net472 3.74μs 7.28ns 28.2ns 0.168 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.92μs 9.41ns 41ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.46μs 8.3ns 32.2ns 0 0 0 952 B
master ExecuteAsync net472 2.58μs 1.44ns 5.58ns 0.142 0 0 915 B
#7800 ExecuteAsync net6.0 1.9μs 9.21ns 39.1ns 0 0 0 952 B
#7800 ExecuteAsync netcoreapp3.1 2.49μs 2.47ns 9.55ns 0 0 0 952 B
#7800 ExecuteAsync net472 2.59μs 1.2ns 4.32ns 0.143 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.74μs 21ns 78.4ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.69μs 19.8ns 76.8ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 12.1ns 46.7ns 0.491 0 0 3.18 KB
#7800 SendAsync net6.0 6.97μs 6.05ns 22.6ns 0 0 0 2.36 KB
#7800 SendAsync netcoreapp3.1 8.8μs 9.97ns 38.6ns 0 0 0 2.9 KB
#7800 SendAsync net472 12.3μs 8.6ns 32.2ns 0.491 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7800

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.128 500,500.00 443,700.00 several?

More allocations ⚠️ in #7800

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 247.29 KB 271.94 KB 24.65 KB 9.97%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.81 KB 45.5 KB 2.7 KB 6.30%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 44.22 KB 44.5 KB 288 B 0.65%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 50.5μs 713ns 7.05μs 0 0 0 44.22 KB
master StringConcatBenchmark netcoreapp3.1 50.1μs 283ns 2.68μs 0 0 0 42.81 KB
master StringConcatBenchmark net472 56.1μs 271ns 1.12μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 461μs 1.99μs 6.89μs 0 0 0 257.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 505μs 2.6μs 11.6μs 0 0 0 247.29 KB
master StringConcatAspectBenchmark net472 412μs 2.25μs 12.9μs 0 0 0 278.36 KB
#7800 StringConcatBenchmark net6.0 41.4μs 171ns 617ns 0 0 0 44.5 KB
#7800 StringConcatBenchmark netcoreapp3.1 52.1μs 502ns 4.82μs 0 0 0 45.5 KB
#7800 StringConcatBenchmark net472 56μs 275ns 1.1μs 0 0 0 57.34 KB
#7800 StringConcatAspectBenchmark net6.0 458μs 2.28μs 9.41μs 0 0 0 259.16 KB
#7800 StringConcatAspectBenchmark netcoreapp3.1 462μs 5.54μs 54.6μs 0 0 0 271.94 KB
#7800 StringConcatAspectBenchmark net472 404μs 2.04μs 9.79μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7800

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.142 3,852.54 4,399.83

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 13.3ns 61ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.61μs 16ns 61.8ns 0 0 0 1.7 KB
master EnrichedLog net472 3.85μs 3.41ns 13.2ns 0.249 0 0 1.64 KB
#7800 EnrichedLog net6.0 2.69μs 12.5ns 49.9ns 0 0 0 1.7 KB
#7800 EnrichedLog netcoreapp3.1 3.65μs 1.77ns 6.61ns 0 0 0 1.7 KB
#7800 EnrichedLog net472 4.4μs 3.06ns 11.4ns 0.242 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 64.1ns 248ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 551ns 2.59μs 0 0 0 4.31 KB
master EnrichedLog net472 168μs 192ns 744ns 0 0 0 4.52 KB
#7800 EnrichedLog net6.0 125μs 370ns 1.43μs 0 0 0 4.31 KB
#7800 EnrichedLog netcoreapp3.1 129μs 306ns 1.14μs 0 0 0 4.31 KB
#7800 EnrichedLog net472 170μs 853ns 4μs 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.08μs 4.77ns 18.5ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.84μs 24.1ns 93.5ns 0 0 0 2.26 KB
master EnrichedLog net472 7.57μs 6.05ns 23.4ns 0.302 0 0 2.08 KB
#7800 EnrichedLog net6.0 5.24μs 12.8ns 49.5ns 0 0 0 2.26 KB
#7800 EnrichedLog netcoreapp3.1 6.86μs 29.5ns 114ns 0 0 0 2.26 KB
#7800 EnrichedLog net472 7.73μs 8.94ns 34.6ns 0.31 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.03μs 3.98ns 15.4ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.62μs 12.8ns 52.8ns 0 0 0 1.2 KB
master SendReceive net472 3.12μs 4.36ns 16.9ns 0.187 0 0 1.2 KB
#7800 SendReceive net6.0 2μs 1.72ns 6.45ns 0 0 0 1.2 KB
#7800 SendReceive netcoreapp3.1 2.62μs 11.1ns 43.2ns 0 0 0 1.2 KB
#7800 SendReceive net472 3.14μs 6.19ns 24ns 0.188 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.29μs 4.33ns 16.8ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.49μs 21.5ns 83.1ns 0 0 0 1.63 KB
master EnrichedLog net472 6.66μs 6.95ns 26.9ns 0.298 0 0 2.03 KB
#7800 EnrichedLog net6.0 4.24μs 7.51ns 29.1ns 0 0 0 1.58 KB
#7800 EnrichedLog netcoreapp3.1 5.58μs 20.7ns 80.3ns 0 0 0 1.63 KB
#7800 EnrichedLog net472 6.65μs 10.4ns 40.3ns 0.3 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 806ns 0.171ns 0.638ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 971ns 5.31ns 29.5ns 0 0 0 576 B
master StartFinishSpan net472 944ns 0.26ns 0.974ns 0.0904 0 0 578 B
master StartFinishScope net6.0 907ns 4.53ns 21.3ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.17μs 5.44ns 21.1ns 0 0 0 696 B
master StartFinishScope net472 1.14μs 0.437ns 1.69ns 0.103 0 0 658 B
#7800 StartFinishSpan net6.0 770ns 4.16ns 23.9ns 0 0 0 576 B
#7800 StartFinishSpan netcoreapp3.1 1μs 4.84ns 20.5ns 0 0 0 576 B
#7800 StartFinishSpan net472 939ns 0.626ns 2.43ns 0.09 0 0 578 B
#7800 StartFinishScope net6.0 915ns 5.11ns 34.7ns 0 0 0 696 B
#7800 StartFinishScope netcoreapp3.1 1.22μs 5.68ns 22.7ns 0 0 0 696 B
#7800 StartFinishScope net472 1.15μs 1.05ns 4.05ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.06μs 4.48ns 17.3ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.45μs 6.68ns 25.9ns 0 0 0 696 B
master RunOnMethodBegin net472 1.44μs 0.428ns 1.6ns 0.101 0 0 658 B
#7800 RunOnMethodBegin net6.0 1.09μs 5.77ns 29.4ns 0 0 0 696 B
#7800 RunOnMethodBegin netcoreapp3.1 1.43μs 5.37ns 20.8ns 0 0 0 696 B
#7800 RunOnMethodBegin net472 1.44μs 0.889ns 3.44ns 0.101 0 0 658 B

@NachoEchevarria NachoEchevarria changed the title Fix GRPC flaky tests Fix GRPC flaky tests. LANGPLAT-816 Nov 11, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 11, 2025 •
edited
Loading

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

DetectAgentUrl from Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.AgentConnectivityCheckTests (Datadog) 
Expected errorOutput "Running checks on process 8184 Process name: Samples.Console  ---- STARTING TRACER SETUP CHECKS ----- Target process is running with .NET Framework 1. Checking Modules Needed so the Tracer Loads:  [SUCCESS]: The native library version 3.31.0.0 is loaded into the process. Error: System.IO.FileNotFoundException: C:\Windows\Microsoft.NET\assembly\GAC_MSIL\Datadog.Trace\v4.0_3.31.0.0__def86d06 1d0d2eeb\Datadog.Trace.dll    at System.Diagnostics.FileVersionInfo.GetVersionInfo(String fileName) + 0x72    at System.Linq.Enumerable.SelectEnumerableIterator\`2.MoveNext() + 0x74    at System.Linq.Enumerable.<DistinctByIterator>d__85\`2.MoveNext() + 0x70    at System.Collections.Generic.LargeArrayBuilder\`1.AddRange(IEnumerable\`1) + 0x48    at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable\`1) + 0xa6    at Datadog.Trace.Tools.dd_dotnet.Checks.ProcessBasicCheck.Run(ProcessInfo, IRegistryService) + 0x37f    at Datadog.Trace.Tools.dd_dotnet.CheckProcessCommand.<ExecuteAsync>d__2.MoveNext() + 0x142 --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Invocation.AnonymousCommandHandler.<InvokeAsync>d__6.MoveNext () + 0x1ca --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Invocation.AnonymousCommandHandler.SyncUsingAsync(InvocationC ontext) + 0x2b    at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInv ocationChain>b__0>d.MoveNext() + 0x100 --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<< UseParseErrorReporting>b__0>d.MoveNext() + 0xf2 --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<< UseHelp>b__0>d.MoveNext() + 0xbf --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<CancelOnProcessTer mination>b__1_0>d.MoveNext() + 0x14d --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Invocation.InvocationPipeline.<Invoke>g__FullInvocationChain| 3_0(InvocationContext) + 0x77    at Datadog.Trace.Tools.dd_dotnet.Program.Main(String[] args) + 0x2dc " to contain "Detected agent url: http://fakeurl:7777/. Note: this url may be incorrect if you configured the application through a configuration file.".

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 100601d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@NachoEchevarria NachoEchevarria changed the title Fix GRPC flaky tests. LANGPLAT-816 Fix GRPC flaky tests. Nov 12, 2025
@NachoEchevarria NachoEchevarria marked this pull request as ready for review November 12, 2025 11:00
@NachoEchevarria NachoEchevarria requested review from a team as code owners November 12, 2025 11:00
andrewlock
andrewlock approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! 👍

@NachoEchevarria NachoEchevarria merged commit 44e08b7 into master Nov 12, 2025
152 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/FixGRPCFlakyTests branch November 12, 2025 16:37
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.31.0

Development

Successfully merging this pull request may close these issues.

4 participants

@NachoEchevarria @bouwkast @andrewlock