-
Notifications
You must be signed in to change notification settings - Fork 151
Removing V1 tags class from AWS integrations #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
737c29c
Removed V1 tags from AWS integrations
rithikanarayan ccb7ac0
Fixing references to v1 in unit tests
rithikanarayan 9ead277
delete auto-generated files for removed types
lucaspimentel 9de777c
restore most file deleted in last commit
lucaspimentel c8badc3
Removing references to peer.service in integration tests
rithikanarayan 0740179
Merge branch 'rithika.narayan/removing-v1-aws' of github.com:DataDog/…
rithikanarayan 401e1e1
Removing v1 from integration tests and snapshots
rithikanarayan 2ad7712
Merge branch 'master' into rithika.narayan/removing-v1-aws
rithikanarayan 34f35ab
Keeping peer service scrubbers
rithikanarayan bc1dd57
Cleaning up integration tests further, removing isExternalSpan and re…
rithikanarayan a6bf286
typo
rithikanarayan 9462084
nits
rithikanarayan ca936ba
fixing expected span kinds:
rithikanarayan 748d9bf
adding expected span kinds
rithikanarayan 805ec23
adding expected span kind consumer
rithikanarayan ef11f12
updating snapshots with span kind
rithikanarayan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 0 additions & 82 deletions
82
...e/Generated/net461/Datadog.Trace.SourceGenerators/TagListGenerator/AwsDynamoDbV1Tags.g.cs
This file was deleted.
Oops, something went wrong.
82 changes: 0 additions & 82 deletions
82
...enerated/net461/Datadog.Trace.SourceGenerators/TagListGenerator/AwsEventBridgeV1Tags.g.cs
This file was deleted.
Oops, something went wrong.
82 changes: 0 additions & 82 deletions
82
...ce/Generated/net461/Datadog.Trace.SourceGenerators/TagListGenerator/AwsKinesisV1Tags.g.cs
This file was deleted.
Oops, something went wrong.
82 changes: 0 additions & 82 deletions
82
...g.Trace/Generated/net461/Datadog.Trace.SourceGenerators/TagListGenerator/AwsS3V1Tags.g.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types all have constructors that take a
spanKind, so we should pass that long.You already did this with
AwsKinesisTagsandAwsStepFunctionsTagsbelow.