[Code Origin] Disable code origin for exit spans #7610

dudikeleti · 2025-10-02T21:24:12Z

Summary of changes

Disabled code origin for exit spans while preserving the functionality for entry spans.

Test coverage

SetCodeOrigin_WhenEnabled_SetsCorrectTags
SetCodeOrigin_WithMaxFramesLimit_RespectsLimit

datadog-datadog-prod-us1 · 2025-10-02T22:07:46Z

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

❄️ Known flaky: RedirectInput from Datadog.Trace.Tools.dd_dotnet.ArtifactTests.RunCommandTests (Datadog) (✨ Fix with BitsAI)
Cannot process request because the process (7524) has exited.

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9b943d5 | Docs | Was this helpful? Give us feedback!}

github-actions · 2025-10-02T23:54:20Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

13 occurrences of :

-      version: 1.0.0,
-      _dd.code_origin.type: exit
+      version: 1.0.0

14 occurrences of :

-      _dd.code_origin.type: exit,

bouwkast

Just some comment nits, but also wondering why we are disabling it and whether or not this will cause any issues if customers needed it?

tracer/src/Datadog.Trace/Debugger/SpanCodeOrigin/SpanCodeOrigin.cs

tracer/test/Datadog.Trace.Tests/Debugger/SpanCodeOriginTests.cs

Co-authored-by: Steven Bouwkamp <[email protected]>

…n.cs Co-authored-by: Steven Bouwkamp <[email protected]>

dudikeleti · 2025-10-03T00:21:56Z

Just some comment nits, but also wondering why we are disabling it and whether or not this will cause any issues if customers needed it?

@bouwkast Thanks for the version fix.
We specify only entry span on the public docs

dd-trace-dotnet-ci-bot · 2025-10-03T01:10:12Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7610) - mean (68ms)  : 67, 70
     .   : milestone, 68,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (1,048ms)  : 997, 1100
     .   : milestone, 1048,
    master - mean (1,050ms)  : 996, 1105
     .   : milestone, 1050,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7610) - mean (105ms)  : 103, 107
     .   : milestone, 105,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (743ms)  : 720, 766
     .   : milestone, 743,
    master - mean (743ms)  : 718, 768
     .   : milestone, 743,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7610) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (703ms)  : 685, 721
     .   : milestone, 703,
    master - mean (702ms)  : 682, 723
     .   : milestone, 702,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7610) - mean (92ms)  : 90, 93
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (661ms)  : 647, 675
     .   : milestone, 661,
    master - mean (662ms)  : 648, 677
     .   : milestone, 662,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (201ms)  : 198, 203
     .   : milestone, 201,
    master - mean (199ms)  : 196, 202
     .   : milestone, 199,

    section Baseline
    This PR (7610) - mean (196ms)  : 191, 201
     .   : milestone, 196,
    master - mean (196ms)  : 192, 200
     .   : milestone, 196,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (1,191ms)  : 1123, 1260
     .   : milestone, 1191,
    master - mean (1,177ms)  : 1116, 1237
     .   : milestone, 1177,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (282ms)  : 277, 287
     .   : milestone, 282,
    master - mean (283ms)  : 279, 286
     .   : milestone, 283,

    section Baseline
    This PR (7610) - mean (282ms)  : 276, 288
     .   : milestone, 282,
    master - mean (282ms)  : 275, 288
     .   : milestone, 282,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (946ms)  : 907, 985
     .   : milestone, 946,
    master - mean (944ms)  : 903, 986
     .   : milestone, 944,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (276ms)  : 269, 283
     .   : milestone, 276,
    master - mean (276ms)  : 266, 285
     .   : milestone, 276,

    section Baseline
    This PR (7610) - mean (275ms)  : 269, 281
     .   : milestone, 275,
    master - mean (275ms)  : 268, 281
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (936ms)  : 898, 973
     .   : milestone, 936,
    master - mean (937ms)  : 888, 985
     .   : milestone, 937,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7610) - mean (274ms)  : 268, 280
     .   : milestone, 274,
    master - mean (274ms)  : 267, 281
     .   : milestone, 274,

    section Baseline
    This PR (7610) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (273ms)  : 269, 278
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7610) - mean (873ms)  : 847, 899
     .   : milestone, 873,
    master - mean (868ms)  : 840, 896
     .   : milestone, 868,

dudikeleti requested a review from a team as a code owner October 2, 2025 21:24

dudikeleti changed the title ~~Disable code origin for exit spans~~ [Code Origin] Disable code origin for exit spans Oct 2, 2025

tylfin approved these changes Oct 2, 2025

View reviewed changes

dudikeleti enabled auto-merge (squash) October 2, 2025 21:32

dudikeleti disabled auto-merge October 2, 2025 22:12

dudikeleti added 2 commits October 3, 2025 01:52

Disable code origin for exit spans

1412581

Update approvals

f4295ac

dudikeleti force-pushed the duidk/co/disable-for-exit-spans branch from cb69277 to f4295ac Compare October 2, 2025 23:53

bouwkast approved these changes Oct 3, 2025

View reviewed changes

dudikeleti and others added 3 commits October 3, 2025 02:07

Update tracer/test/Datadog.Trace.Tests/Debugger/SpanCodeOriginTests.cs

32721a7

Co-authored-by: Steven Bouwkamp <[email protected]>

Update tracer/test/Datadog.Trace.Tests/Debugger/SpanCodeOriginTests.cs

380fc95

Co-authored-by: Steven Bouwkamp <[email protected]>

Update tracer/src/Datadog.Trace/Debugger/SpanCodeOrigin/SpanCodeOrigi…

9b943d5

…n.cs Co-authored-by: Steven Bouwkamp <[email protected]>

dudikeleti merged commit dbcb5fa into master Oct 3, 2025
155 of 156 checks passed

dudikeleti deleted the duidk/co/disable-for-exit-spans branch October 3, 2025 01:53

github-actions bot added this to the vNext-v3 milestone Oct 3, 2025

bouwkast added area:debugger type:bug labels Oct 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Code Origin] Disable code origin for exit spans #7610

[Code Origin] Disable code origin for exit spans #7610

Uh oh!

dudikeleti commented Oct 2, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

bouwkast left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dudikeleti commented Oct 3, 2025 •

edited

Loading

Uh oh!

dd-trace-dotnet-ci-bot bot commented Oct 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

[Code Origin] Disable code origin for exit spans #7610

[Code Origin] Disable code origin for exit spans #7610

Uh oh!

Conversation

dudikeleti commented Oct 2, 2025

Summary of changes

Test coverage

Uh oh!

datadog-datadog-prod-us1 bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

github-actions bot commented Oct 2, 2025

Snapshots difference summary

Uh oh!

bouwkast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dudikeleti commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-trace-dotnet-ci-bot bot commented Oct 3, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

datadog-datadog-prod-us1 bot commented Oct 2, 2025 •

edited

Loading

dudikeleti commented Oct 3, 2025 •

edited

Loading