Skip to content

Conversation

@igoragoli
Copy link
Contributor

@igoragoli igoragoli commented Oct 2, 2025

Summary of changes

Reverts #7571 since it introduces a bug preventing microbenchmarks to be run.

Reason for change

Implementation details

Test coverage

Other details

@igoragoli igoragoli marked this pull request as ready for review October 2, 2025 16:45
@igoragoli igoragoli requested a review from a team as a code owner October 2, 2025 16:45
@igoragoli igoragoli force-pushed the augusto/dd-trace-dotnet-micro-github-token branch from ca576a2 to dcc8587 Compare October 2, 2025 16:51
@igoragoli igoragoli changed the title Export GitHub token for run-windows-benchmarks.sh Revert "Improve and simplify the microbenchmarks CI setup" Oct 2, 2025
@igoragoli igoragoli enabled auto-merge (squash) October 2, 2025 17:13
@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7606) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (1,048ms)  : 1001, 1094
     .   : milestone, 1048,
    master - mean (1,052ms)  : 987, 1117
     .   : milestone, 1052,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 105, 108
     .   : milestone, 106,

    section Baseline
    This PR (7606) - mean (105ms)  : 102, 109
     .   : milestone, 105,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (744ms)  : 724, 764
     .   : milestone, 744,
    master - mean (742ms)  : 719, 766
     .   : milestone, 742,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7606) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (702ms)  : 683, 721
     .   : milestone, 702,
    master - mean (701ms)  : 684, 717
     .   : milestone, 701,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (92ms)  : 91, 94
     .   : milestone, 92,

    section Baseline
    This PR (7606) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (659ms)  : 645, 673
     .   : milestone, 659,
    master - mean (663ms)  : 647, 679
     .   : milestone, 663,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (211ms)  : 205, 216
     .   : milestone, 211,
    master - mean (203ms)  : 197, 209
     .   : milestone, 203,

    section Baseline
    This PR (7606) - mean (208ms)  : 202, 213
     .   : milestone, 208,
    master - mean (198ms)  : 192, 204
     .   : milestone, 198,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (1,215ms)  : 1155, 1275
     .   : milestone, 1215,
    master - mean (1,191ms)  : 1126, 1255
     .   : milestone, 1191,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (301ms)  : 295, 306
     .   : milestone, 301,
    master - mean (287ms)  : 279, 294
     .   : milestone, 287,

    section Baseline
    This PR (7606) - mean (299ms)  : 293, 304
     .   : milestone, 299,
    master - mean (285ms)  : 279, 292
     .   : milestone, 285,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (969ms)  : 915, 1022
     .   : milestone, 969,
    master - mean (964ms)  : 920, 1008
     .   : milestone, 964,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (280ms)  : 272, 288
     .   : milestone, 280,
    master - mean (280ms)  : 271, 290
     .   : milestone, 280,

    section Baseline
    This PR (7606) - mean (278ms)  : 270, 286
     .   : milestone, 278,
    master - mean (279ms)  : 270, 289
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (949ms)  : 906, 991
     .   : milestone, 949,
    master - mean (945ms)  : 903, 987
     .   : milestone, 945,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7606) - mean (281ms)  : 268, 294
     .   : milestone, 281,
    master - mean (278ms)  : 271, 285
     .   : milestone, 278,

    section Baseline
    This PR (7606) - mean (277ms)  : 270, 284
     .   : milestone, 277,
    master - mean (278ms)  : 268, 287
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (7606) - mean (883ms)  : 835, 931
     .   : milestone, 883,
    master - mean (870ms)  : 849, 891
     .   : milestone, 870,

Loading

@igoragoli igoragoli merged commit d16c3b0 into master Oct 2, 2025
129 of 147 checks passed
@igoragoli igoragoli deleted the augusto/dd-trace-dotnet-micro-github-token branch October 2, 2025 18:01
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 2, 2025
@bouwkast bouwkast added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants