Skip to content

Mark FlakyRetriesWithExceptionReplay as flaky #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

Mark FlakyRetriesWithExceptionReplay as flaky #7603

merged 2 commits into from
Oct 2, 2025

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Oct 2, 2025 •
edited
Loading

Summary of changes

FlakyRetriesWithExceptionReplay are failing recently in master. The reason is under investigation. In the meantime, we will marke these tests as flaky.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:tests unit tests, integration tests label Oct 2, 2025
@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 2, 2025 10:28
@NachoEchevarria NachoEchevarria requested review from a team as code owners October 2, 2025 10:28
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 2, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7603) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (1,047ms)  : 1000, 1094
     .   : milestone, 1047,
    master - mean (1,043ms)  : 1007, 1079
     .   : milestone, 1043,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7603) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (741ms)  : 715, 767
     .   : milestone, 741,
    master - mean (743ms)  : 722, 764
     .   : milestone, 743,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (100ms)  : 99, 101
     .   : milestone, 100,

    section Baseline
    This PR (7603) - mean (93ms)  : 92, 95
     .   : milestone, 93,
    master - mean (99ms)  : 97, 101
     .   : milestone, 99,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (698ms)  : 678, 719
     .   : milestone, 698,
    master - mean (772ms)  : 725, 819
     .   : milestone, 772,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section Baseline
    This PR (7603) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (656ms)  : 642, 670
     .   : milestone, 656,
    master - mean (660ms)  : 646, 674
     .   : milestone, 660,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (201ms)  : 198, 204
     .   : milestone, 201,
    master - mean (207ms)  : 201, 213
     .   : milestone, 207,

    section Baseline
    This PR (7603) - mean (198ms)  : 193, 202
     .   : milestone, 198,
    master - mean (202ms)  : 196, 208
     .   : milestone, 202,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (1,180ms)  : 1112, 1248
     .   : milestone, 1180,
    master - mean (1,192ms)  : 1129, 1256
     .   : milestone, 1192,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (285ms)  : 277, 292
     .   : milestone, 285,
    master - mean (288ms)  : 279, 297
     .   : milestone, 288,

    section Baseline
    This PR (7603) - mean (283ms)  : 278, 288
     .   : milestone, 283,
    master - mean (287ms)  : 277, 296
     .   : milestone, 287,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (945ms)  : 908, 982
     .   : milestone, 945,
    master - mean (963ms)  : 920, 1005
     .   : milestone, 963,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (279ms)  : 272, 286
     .   : milestone, 279,
    master - mean (291ms)  : 282, 300
     .   : milestone, 291,

    section Baseline
    This PR (7603) - mean (277ms)  : 270, 284
     .   : milestone, 277,
    master - mean (291ms)  : 281, 301
     .   : milestone, 291,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (930ms)  : 891, 968
     .   : milestone, 930,
    master - mean (1,017ms)  : 967, 1066
     .   : milestone, 1017,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7603) - mean (276ms)  : 270, 282
     .   : milestone, 276,
    master - mean (279ms)  : 273, 286
     .   : milestone, 279,

    section Baseline
    This PR (7603) - mean (276ms)  : 270, 282
     .   : milestone, 276,
    master - mean (280ms)  : 271, 290
     .   : milestone, 280,

    section CallTarget+Inlining+NGEN
    This PR (7603) - mean (861ms)  : 841, 881
     .   : milestone, 861,
    master - mean (882ms)  : 858, 906
     .   : milestone, 882,
Loading

@NachoEchevarria NachoEchevarria merged commit e3a8419 into master Oct 2, 2025
146 of 148 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/FlakyExceptionReplayTests branch October 2, 2025 13:14
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoEchevarria @tonyredondo