Skip to content

Conversation

@dudikeleti
Copy link
Contributor

Summary of changes

We don't want to trigger error in case symbol upload has canceled

@dudikeleti dudikeleti requested a review from a team as a code owner September 29, 2025 08:58
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Sep 29, 2025
@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (72ms)  : 70, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7572) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (1,049ms)  : 1000, 1097
     .   : milestone, 1049,
    master - mean (1,051ms)  : 999, 1103
     .   : milestone, 1051,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 104, 107
     .   : milestone, 106,

    section Baseline
    This PR (7572) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (105ms)  : 103, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (743ms)  : 720, 765
     .   : milestone, 743,
    master - mean (742ms)  : 721, 762
     .   : milestone, 742,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (101ms)  : 99, 102
     .   : milestone, 101,
    master - mean (100ms)  : 99, 101
     .   : milestone, 100,

    section Baseline
    This PR (7572) - mean (100ms)  : 98, 101
     .   : milestone, 100,
    master - mean (99ms)  : 97, 101
     .   : milestone, 99,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (774ms)  : 723, 826
     .   : milestone, 774,
    master - mean (776ms)  : 732, 820
     .   : milestone, 776,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section Baseline
    This PR (7572) - mean (92ms)  : 89, 96
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (664ms)  : 647, 681
     .   : milestone, 664,
    master - mean (664ms)  : 649, 679
     .   : milestone, 664,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (200ms)  : 197, 204
     .   : milestone, 200,
    master - mean (199ms)  : 195, 204
     .   : milestone, 199,

    section Baseline
    This PR (7572) - mean (198ms)  : 192, 203
     .   : milestone, 198,
    master - mean (197ms)  : 190, 203
     .   : milestone, 197,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (1,178ms)  : 1124, 1232
     .   : milestone, 1178,
    master - mean (1,168ms)  : 1110, 1227
     .   : milestone, 1168,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (285ms)  : 278, 293
     .   : milestone, 285,
    master - mean (281ms)  : 277, 285
     .   : milestone, 281,

    section Baseline
    This PR (7572) - mean (287ms)  : 277, 298
     .   : milestone, 287,
    master - mean (282ms)  : 275, 289
     .   : milestone, 282,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (951ms)  : 903, 999
     .   : milestone, 951,
    master - mean (953ms)  : 908, 997
     .   : milestone, 953,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (290ms)  : 282, 297
     .   : milestone, 290,
    master - mean (285ms)  : 281, 289
     .   : milestone, 285,

    section Baseline
    This PR (7572) - mean (289ms)  : 279, 299
     .   : milestone, 289,
    master - mean (284ms)  : 278, 290
     .   : milestone, 284,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (1,010ms)  : 969, 1050
     .   : milestone, 1010,
    master - mean (1,003ms)  : 969, 1036
     .   : milestone, 1003,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7572) - mean (277ms)  : 271, 284
     .   : milestone, 277,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section Baseline
    This PR (7572) - mean (276ms)  : 269, 283
     .   : milestone, 276,
    master - mean (273ms)  : 267, 278
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7572) - mean (862ms)  : 836, 887
     .   : milestone, 862,
    master - mean (862ms)  : 840, 883
     .   : milestone, 862,

Loading

@dudikeleti dudikeleti merged commit 1b25f92 into master Oct 3, 2025
70 of 75 checks passed
@dudikeleti dudikeleti deleted the dudik/symdb/ignore-cancelled-exception branch October 3, 2025 07:12
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 3, 2025
igoragoli pushed a commit that referenced this pull request Oct 6, 2025
## Summary of changes
We don't want to trigger error in case symbol upload has canceled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants