-
Couldn't load subscription status.
- Fork 150
[Test Package Versions Bump] Updating package versions #7515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (80ms) : crit, 75, 85
. : crit, milestone, 80,
master - mean (72ms) : 71, 73
. : milestone, 72,
section Baseline
This PR (7515) - mean (75ms) : 71, 78
. : milestone, 75,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (1,109ms) : crit, 1057, 1162
. : crit, milestone, 1109,
master - mean (1,047ms) : 997, 1097
. : milestone, 1047,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (118ms) : crit, 114, 122
. : crit, milestone, 118,
master - mean (106ms) : 105, 107
. : milestone, 106,
section Baseline
This PR (7515) - mean (117ms) : 112, 122
. : milestone, 117,
master - mean (106ms) : 103, 108
. : milestone, 106,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (789ms) : crit, 766, 813
. : crit, milestone, 789,
master - mean (741ms) : 719, 764
. : milestone, 741,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (112ms) : crit, 108, 116
. : crit, milestone, 112,
master - mean (94ms) : 93, 95
. : milestone, 94,
section Baseline
This PR (7515) - mean (110ms) : 105, 116
. : milestone, 110,
master - mean (94ms) : 91, 96
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (822ms) : crit, 760, 884
. : crit, milestone, 822,
master - mean (701ms) : 684, 719
. : milestone, 701,
gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (104ms) : crit, 100, 108
. : crit, milestone, 104,
master - mean (92ms) : 91, 94
. : milestone, 92,
section Baseline
This PR (7515) - mean (103ms) : 96, 110
. : milestone, 103,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (707ms) : crit, 686, 728
. : crit, milestone, 707,
master - mean (666ms) : 648, 683
. : milestone, 666,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (209ms) : 203, 215
. : milestone, 209,
master - mean (199ms) : 195, 202
. : milestone, 199,
section Baseline
This PR (7515) - mean (202ms) : 190, 215
. : milestone, 202,
master - mean (196ms) : 191, 201
. : milestone, 196,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (1,194ms) : 1129, 1259
. : milestone, 1194,
master - mean (1,180ms) : 1114, 1246
. : milestone, 1180,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (288ms) : 279, 297
. : milestone, 288,
master - mean (282ms) : 276, 287
. : milestone, 282,
section Baseline
This PR (7515) - mean (286ms) : 278, 295
. : milestone, 286,
master - mean (282ms) : 277, 286
. : milestone, 282,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (959ms) : 920, 998
. : milestone, 959,
master - mean (943ms) : 905, 982
. : milestone, 943,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (289ms) : 280, 299
. : milestone, 289,
master - mean (275ms) : 270, 280
. : milestone, 275,
section Baseline
This PR (7515) - mean (290ms) : 283, 297
. : milestone, 290,
master - mean (276ms) : 270, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (1,009ms) : crit, 970, 1047
. : crit, milestone, 1009,
master - mean (931ms) : 891, 971
. : milestone, 931,
gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7515) - mean (279ms) : 269, 289
. : milestone, 279,
master - mean (276ms) : 269, 282
. : milestone, 276,
section Baseline
This PR (7515) - mean (275ms) : 268, 281
. : milestone, 275,
master - mean (273ms) : 268, 278
. : milestone, 273,
section CallTarget+Inlining+NGEN
This PR (7515) - mean (861ms) : 839, 882
. : milestone, 861,
master - mean (863ms) : 843, 883
. : milestone, 863,
|
This comment has been minimized.
This comment has been minimized.
| <!-- Latest package https://www.nuget.org/packages/MongoDB.Driver/3.5.0 --> | ||
| <PackageReference Include="MongoDB.Driver" Version="3.5.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is failing because it requires a newer version of the mongodb itself. That means we definitely need to update the mongodb image (and so update all the VMs), but it may also mean that we actually need to run both old and new versions of mongodb, and split which one we talk to based on the package version 🙁
01:25:04 [DBG] Unhandled exception. MongoDB.Driver.MongoIncompatibleDriverException: Server at mongo:27017 reports wire version 7, but this version of the driver requires at least 8 (MongoDB 4.2.0).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://datadoghq.atlassian.net/browse/LANGPLAT-860 -> work item to bump the docker image and update the VMs
I will go and cap the version to less than 3.5.0 for CI and then test this out locally I have that here
https://datadoghq.atlassian.net/browse/LANGPLAT-861
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capped it in 787ff19
Will need to test locally to make sure it works and prepare a PR for that to get it updated.
e645e2c to
4b239dc
Compare
4b239dc to
12b0247
Compare
| <!-- Latest package https://www.nuget.org/packages/MSTest.TestAdapter/3.10.4 --> | ||
| <PackageReference Include="MSTest.TestAdapter" Version="3.10.4" /> | ||
| <!-- Latest package https://www.nuget.org/packages/MSTest.TestAdapter/3.11.0 --> | ||
| <PackageReference Include="MSTest.TestAdapter" Version="3.11.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to not work 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so 3.10.4 works, 3.10.5 has some failures, 3.11.0 has a lot of failures
Just re-ran GeneratePackageVersions I tried to limit it to just MongoDB.Driver, but that didn't work.
Tests are failing in 3.11.0 which just released
1d83a2a to
802957d
Compare
5377599 to
aaa929d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving
We have some follow ups here though
- Test against MongoDB.Driver
3.5.0locally, fix if necessary - PR to get support for that new docker version
- Fix the MSTest.TestFramework instrumentation
Dismissing as I've pinned the version to below 3.5.0 for MongoDB.Driver and have scheduled work to remediate
Updates the package versions for integration tests. --------- Co-authored-by: andrewlock <[email protected]> Co-authored-by: Steven Bouwkamp <[email protected]>
Updates the package versions for integration tests.