Build and run tests against .NET 10 RC 1 #7499

bouwkast · 2025-09-10T19:38:20Z

Summary of changes

This updates our build and testing to work with .NET 10 RC 1, updating from .NET 10 Preview 7 to it.

Reason for change

https://devblogs.microsoft.com/dotnet/dotnet-10-rc-1/
https://github.com/dotnet/core/blob/main/release-notes/10.0/preview/rc1/libraries.md

Implementation details

Ctrl + F and replace
Fixed a few compilation issues due to some LINQ extension methods getting swapped to newer MemoryExtensions public static void Reverse<T>(this Span<T> span) - I just did a AsEnumerable for the time being
Had to ignore ASPDEPR008 in which the WebHostBuilder is now deprecated in one of the test files

Test coverage

Ran some locally and seem to work, but will need to rely on CI for most

Other details

I don't have permissions to do most of the stuff with the managed pools :(
I initially had more instances of NU1510, but I am only getting those in VS 22, they don't show up in VS 26 🤷

https://datadoghq.atlassian.net/browse/LANGPLAT-758

tracer/build/_build/docker/gitlab/gitlab.windows.dockerfile

andrewlock

Looking good so far - I would expect there to be find+replace changes we need to NuGet packages in the samples too though?

bouwkast

Did a find all / replace with the wrong value for NuGet versions

tracer/build/_build/_build.csproj

tracer/test/Datadog.Trace.IntegrationTests/Datadog.Trace.IntegrationTests.csproj

.../test-applications/security/Samples.Security.AspNetCore5/Samples.Security.AspNetCore5.csproj

profiler/src/Demos/Samples.Computer01/Samples.Computer01.csproj

dd-trace-dotnet-ci-bot · 2025-09-11T19:27:51Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7499) - mean (68ms)  : 65, 72
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (1,001ms)  : 968, 1034
     .   : milestone, 1001,
    master - mean (998ms)  : 970, 1026
     .   : milestone, 998,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (106ms)  : 105, 107
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7499) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (105ms)  : 102, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (703ms)  : 682, 724
     .   : milestone, 703,
    master - mean (704ms)  : 685, 723
     .   : milestone, 704,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7499) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (661ms)  : 640, 683
     .   : milestone, 661,
    master - mean (665ms)  : 649, 681
     .   : milestone, 665,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (92ms)  : 91, 94
     .   : milestone, 92,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section Baseline
    This PR (7499) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (592ms)  : 582, 602
     .   : milestone, 592,
    master - mean (599ms)  : 587, 610
     .   : milestone, 599,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (193ms)  : 190, 197
     .   : milestone, 193,
    master - mean (194ms)  : 190, 199
     .   : milestone, 194,

    section Baseline
    This PR (7499) - mean (192ms)  : 187, 197
     .   : milestone, 192,
    master - mean (192ms)  : 184, 200
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (1,101ms)  : 1059, 1144
     .   : milestone, 1101,
    master - mean (1,095ms)  : 1059, 1130
     .   : milestone, 1095,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (281ms)  : 276, 286
     .   : milestone, 281,
    master - mean (274ms)  : 268, 280
     .   : milestone, 274,

    section Baseline
    This PR (7499) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (273ms)  : 266, 280
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (902ms)  : 869, 935
     .   : milestone, 902,
    master - mean (890ms)  : 852, 929
     .   : milestone, 890,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (269ms)  : 265, 274
     .   : milestone, 269,
    master - mean (267ms)  : 259, 275
     .   : milestone, 267,

    section Baseline
    This PR (7499) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (266ms)  : 259, 273
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (875ms)  : 834, 915
     .   : milestone, 875,
    master - mean (876ms)  : 833, 919
     .   : milestone, 876,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7499) - mean (268ms)  : 265, 271
     .   : milestone, 268,
    master - mean (265ms)  : 260, 271
     .   : milestone, 265,

    section Baseline
    This PR (7499) - mean (269ms)  : 263, 275
     .   : milestone, 269,
    master - mean (265ms)  : 259, 271
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (7499) - mean (790ms)  : 770, 810
     .   : milestone, 790,
    master - mean (786ms)  : 762, 811
     .   : milestone, 786,

bouwkast · 2025-09-11T21:07:02Z

@codex review

chatgpt-codex-connector · 2025-09-11T21:07:06Z

To use Codex here, create a Codex account and connect to github.

bouwkast · 2025-09-11T21:08:50Z

@codex review

chatgpt-codex-connector · 2025-09-11T21:11:00Z

Codex Review: Didn't find any major issues. Delightful!

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@bouwkast

## Summary of changes Fix issues that cause failure to compile if you try to use RC1 ## Reason for change @bouwkast found these issues in #7499, but some people have already installed RC1 and are getting local failures, so this should unblock them ## Implementation details Copy the fixes from #7499 ## Test coverage Covered by existing (hopefully) ## Other details

datadog-datadog-prod-us1 · 2025-09-15T20:43:35Z

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

NoTraceContextAttachedIfFeatureDeactivated from Datadog.Profiler.IntegrationTests.CodeHotspot.CodeHotspotTest (Datadog) (✨ Fix with BitsAI)
Actual:   Falsemples.BuggyBits.exe" should be 0 instead of 255 (= 0xFF)

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 77edcf8 | Docs | Was this helpful? Give us feedback!}

andrewlock · 2025-09-16T16:44:19Z

...test/Datadog.Trace.IntegrationTests/DiagnosticListeners/AspNetCoreDiagnosticObserverTests.cs

            bool expandRouteParameters = false)
            where T : class
        {
+#pragma warning disable ASPDEPR004 // WebHostBuilder is deprecated but we need it for net core 2.1 FIXME


meh, don't actually need to FIXME 😄

andrewlock

LGTM, thanks!

chatgpt-codex-connector

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

tracer/build/_build/Build.VariableGenerations.cs

WebHostBuilder is deprecated but we need it for net core 2.1 seems to only be in this one case where we use it so just ignoring for the time being. New to .NET 10

Was trying to resolve a NU1510 error, but went away with VS 26

Can't get any other means to disable them.

This reverts commit 32d9d64. Caused different issues

We will need to re-update the VMs after pushing new docker images for them. Planning on doing that at a later point

## Summary of changes Fixes the nuget tool smoke tests ## Reason for change The nuget tool smoke tests runs in the _sdk_ image, which means we need an sdk version number (10.0.100) not a runtime version number (10.0.0) ## Implementation details Simple typo fix ## Test coverage Will do a full test to make sure ## Other details Related to #7499

andrewlock reviewed Sep 11, 2025

View reviewed changes

tracer/build/_build/docker/gitlab/gitlab.windows.dockerfile Show resolved Hide resolved

andrewlock reviewed Sep 11, 2025

View reviewed changes

bouwkast changed the title ~~Add support .NET 10 RC 1~~ Add support for .NET 10 RC 1 Sep 11, 2025

bouwkast commented Sep 11, 2025

View reviewed changes

bouwkast force-pushed the steven/update-net-10-rc1 branch from b073a00 to 816f2ce Compare September 11, 2025 18:36

andrewlock mentioned this pull request Sep 12, 2025

Fix .NET 10 RC1 bugs #7506

Merged

andrewlock reviewed Sep 16, 2025

View reviewed changes

andrewlock approved these changes Sep 16, 2025

View reviewed changes

bouwkast marked this pull request as ready for review September 17, 2025 11:18

bouwkast requested review from a team as code owners September 17, 2025 11:18

chatgpt-codex-connector bot reviewed Sep 17, 2025

View reviewed changes

tracer/build/_build/Build.VariableGenerations.cs Outdated Show resolved Hide resolved

bouwkast added 7 commits September 17, 2025 07:49

Update to .NET 10 RC 1 in code files

603fd4d

Ignore ASPDEPR004 for now

5a46d28

WebHostBuilder is deprecated but we need it for net core 2.1 seems to only be in this one case where we use it so just ignoring for the time being. New to .NET 10

Swap to the managed pools with .NET 10 RC 1

9dad1ac

Find and replace NuGets with .NET 10 RC 1 Version

0d261e1

Undo ItemGroup condition change in Manual csproj

6563093

Was trying to resolve a NU1510 error, but went away with VS 26

Fix NuGet Versions

bd1e027

Copy paste prgama to disable new warnings / errors

0f74415

Can't get any other means to disable them.

bouwkast added 9 commits September 17, 2025 07:49

Point to RC1 image

78d6159

Attempt to use C#13 as using C#14 causes issues

022217a

Revert "Attempt to use C#13 as using C#14 causes issues"

601881e

This reverts commit 32d9d64. Caused different issues

Just comment out automapper tests

271ad61

Missed a spot to stop doing the automapper test

13210cf

Find / replace .NET 10 docker images

bfdcaf1

Point to new GitLab image

b9b4d85

Temporarily skip the Trixie tests for .NET 10 RC1

bf2e3b5

We will need to re-update the VMs after pushing new docker images for them. Planning on doing that at a later point

Fix double hyphen

2db1fc6

bouwkast force-pushed the steven/update-net-10-rc1 branch from 4adbcc2 to 2db1fc6 Compare September 17, 2025 11:49

Bump benchmarking platform images

77edcf8

bouwkast changed the title ~~Add support for .NET 10 RC 1~~ Build and run tests against .NET 10 RC 1 Sep 19, 2025

lucaspimentel approved these changes Sep 23, 2025

View reviewed changes

bouwkast merged commit c73a5f9 into master Sep 25, 2025
160 checks passed

bouwkast deleted the steven/update-net-10-rc1 branch September 25, 2025 12:01

github-actions bot added this to the vNext-v3 milestone Sep 25, 2025

andrewlock mentioned this pull request Sep 25, 2025

Fix smoke tests for nuget tool #7564

Merged

bouwkast added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 6, 2025

Build and run tests against .NET 10 RC 1 #7499

Build and run tests against .NET 10 RC 1 #7499

Uh oh!

Conversation

bouwkast commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

bouwkast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dd-trace-dotnet-ci-bot bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

bouwkast commented Sep 11, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 11, 2025

Uh oh!

bouwkast commented Sep 11, 2025

Uh oh!

chatgpt-codex-connector bot commented Sep 11, 2025

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

andrewlock Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bouwkast commented Sep 10, 2025 •

edited

Loading

dd-trace-dotnet-ci-bot bot commented Sep 11, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Sep 15, 2025 •

edited

Loading