Skip to content

[Profiler] Try fixing TSAN job #7452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

[Profiler] Try fixing TSAN job #7452

merged 1 commit into from
Sep 2, 2025

Conversation

gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Aug 29, 2025 •
edited
Loading

Summary of changes

Fix the TSAN job by changing the configuration of ASLR on the machine. This seems related to https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2056762

Reason for change

TSAN did not keep up with recent changes in the linux kernel and an update of the kernel (6.6+) messes up with TSAN.

Implementation details

Changing the entropy of ASLR (first command) and enabling it partially fix the job.

Test coverage

  • TSAN job must not fail.

Other details

@github-actions github-actions bot added area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler labels Aug 29, 2025
@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7452 compared to master:

  • 1 benchmarks are faster, with geometric mean 2.064
  • 9 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7452

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.04 KB 6.09 KB 48 B 0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.3μs 57.2ns 362ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 13.7μs 72ns 353ns 0 0 0 5.71 KB
master StartStopWithChild net472 21.9μs 122ns 779ns 0.962 0.321 0.107 6.04 KB
#7452 StartStopWithChild net6.0 10.8μs 59.4ns 366ns 0 0 0 5.5 KB
#7452 StartStopWithChild netcoreapp3.1 13.7μs 66.6ns 290ns 0 0 0 5.7 KB
#7452 StartStopWithChild net472 21.9μs 113ns 678ns 0.877 0.219 0 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 942μs 897ns 3.47μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 2.06μs 8μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 24.5ns 91.7ns 0 0 0 3.31 KB
#7452 WriteAndFlushEnrichedTraces net6.0 934μs 260ns 972ns 0 0 0 2.71 KB
#7452 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 208ns 751ns 0 0 0 2.7 KB
#7452 WriteAndFlushEnrichedTraces net472 1.2ms 744ns 2.88μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 328μs 1.6μs 6.62μs 0 0 0 172.07 KB
master AllCycleSimpleBody netcoreapp3.1 481μs 2.14μs 8.3μs 0 0 0 174.18 KB
master AllCycleSimpleBody net472 428μs 195ns 755ns 29.2 0 0 194.24 KB
master AllCycleMoreComplexBody net6.0 329μs 234ns 905ns 0 0 0 175.58 KB
master AllCycleMoreComplexBody netcoreapp3.1 482μs 1.44μs 5.57μs 0 0 0 177.6 KB
master AllCycleMoreComplexBody net472 433μs 133ns 515ns 30.2 0 0 197.76 KB
master ObjectExtractorSimpleBody net6.0 322ns 0.092ns 0.356ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 400ns 2.14ns 11.3ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 299ns 0.0285ns 0.107ns 0.0435 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.33μs 28.9ns 112ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 3.08ns 11.9ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.78μs 4.44ns 16ns 0.579 0 0 3.8 KB
#7452 AllCycleSimpleBody net6.0 319μs 1.19μs 4.59μs 0 0 0 172.07 KB
#7452 AllCycleSimpleBody netcoreapp3.1 468μs 1.08μs 4.03μs 0 0 0 174.18 KB
#7452 AllCycleSimpleBody net472 429μs 94.5ns 366ns 29.2 0 0 194.24 KB
#7452 AllCycleMoreComplexBody net6.0 329μs 1.4μs 5.43μs 0 0 0 175.58 KB
#7452 AllCycleMoreComplexBody netcoreapp3.1 468μs 1.21μs 4.67μs 0 0 0 177.6 KB
#7452 AllCycleMoreComplexBody net472 432μs 153ns 593ns 30.2 0 0 197.76 KB
#7452 ObjectExtractorSimpleBody net6.0 321ns 0.405ns 1.57ns 0 0 0 280 B
#7452 ObjectExtractorSimpleBody netcoreapp3.1 407ns 0.0939ns 0.339ns 0 0 0 272 B
#7452 ObjectExtractorSimpleBody net472 305ns 0.0216ns 0.081ns 0.0445 0 0 281 B
#7452 ObjectExtractorMoreComplexBody net6.0 6.34μs 4.8ns 18.6ns 0 0 0 3.78 KB
#7452 ObjectExtractorMoreComplexBody netcoreapp3.1 7.88μs 32.1ns 125ns 0 0 0 3.69 KB
#7452 ObjectExtractorMoreComplexBody net472 6.71μs 3.83ns 14.8ns 0.57 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 80μs 32.8ns 118ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.5μs 211ns 788ns 0 0 0 32.4 KB
master EncodeArgs net472 111μs 8.64ns 32.3ns 4.99 0 0 32.51 KB
master EncodeLegacyArgs net6.0 149μs 7.54ns 28.2ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 198μs 168ns 650ns 0 0 0 2.15 KB
master EncodeLegacyArgs net472 265μs 27.2ns 105ns 0 0 0 2.16 KB
#7452 EncodeArgs net6.0 77.2μs 12.4ns 44.6ns 0 0 0 32.4 KB
#7452 EncodeArgs netcoreapp3.1 97.1μs 253ns 979ns 0 0 0 32.4 KB
#7452 EncodeArgs net472 109μs 8.2ns 30.7ns 4.91 0 0 32.51 KB
#7452 EncodeLegacyArgs net6.0 144μs 77.7ns 301ns 0 0 0 2.14 KB
#7452 EncodeLegacyArgs netcoreapp3.1 197μs 227ns 879ns 0 0 0 2.14 KB
#7452 EncodeLegacyArgs net472 264μs 31.9ns 119ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7452

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 2.064 855,001.88 414,215.83

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 396μs 44ns 159ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 851μs 3.51μs 13.1μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 435μs 57.6ns 223ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 290μs 57.5ns 223ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 300μs 177ns 684ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 312μs 68.4ns 256ns 0 0 0 2.29 KB
#7452 RunWafRealisticBenchmark net6.0 396μs 117ns 439ns 0 0 0 4.55 KB
#7452 RunWafRealisticBenchmark netcoreapp3.1 414μs 91ns 328ns 0 0 0 4.48 KB
#7452 RunWafRealisticBenchmark net472 433μs 74ns 287ns 0 0 0 4.66 KB
#7452 RunWafRealisticBenchmarkWithAttack net6.0 289μs 92.6ns 359ns 0 0 0 2.24 KB
#7452 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 303μs 139ns 537ns 0 0 0 2.22 KB
#7452 RunWafRealisticBenchmarkWithAttack net472 317μs 32.9ns 123ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.7μs 131ns 471ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 70.8μs 63.1ns 236ns 0 0 0 17.42 KB
master SendRequest net472 0.0108ns 0.00341ns 0.0128ns 0 0 0 0 b
#7452 SendRequest net6.0 60.9μs 50.5ns 196ns 0 0 0 14.52 KB
#7452 SendRequest netcoreapp3.1 71.6μs 147ns 529ns 0 0 0 17.42 KB
#7452 SendRequest net472 0.00737ns 0.0018ns 0.00697ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7452

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 6 B 4 B -2 B -33.33%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 3 B 1 B -2 B -66.67%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 0 b -47 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 2.02ms 292ns 1.13μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 2.09ms 6.27μs 24.3μs 0 0 0 640 KB
master OriginalCharSlice net472 2.63ms 265ns 991ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.46ms 432ns 1.68μs 0 0 0 6 B
master OptimizedCharSlice netcoreapp3.1 1.73ms 282ns 1.06μs 0 0 0 1 B
master OptimizedCharSlice net472 2ms 358ns 1.39μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 800μs 74.6ns 289ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 815μs 150ns 579ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.2ms 58.1ns 217ns 0 0 0 47 B
#7452 OriginalCharSlice net6.0 2.01ms 577ns 2.23μs 0 0 0 640.01 KB
#7452 OriginalCharSlice netcoreapp3.1 2.09ms 7.79μs 29.1μs 0 0 0 640 KB
#7452 OriginalCharSlice net472 2.71ms 268ns 1.04μs 100 0 0 641.95 KB
#7452 OptimizedCharSlice net6.0 1.4ms 292ns 1.09μs 0 0 0 4 B
#7452 OptimizedCharSlice netcoreapp3.1 1.69ms 188ns 730ns 0 0 0 1 B
#7452 OptimizedCharSlice net472 1.96ms 454ns 1.7μs 0 0 0 0 b
#7452 OptimizedCharSliceWithPool net6.0 799μs 31.1ns 117ns 0 0 0 1 B
#7452 OptimizedCharSliceWithPool netcoreapp3.1 812μs 67.7ns 244ns 0 0 0 1 B
#7452 OptimizedCharSliceWithPool net472 1.18ms 76.8ns 287ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7452

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.09 KB 55.78 KB -310 B -0.55%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.44 KB 41.88 KB -554 B -1.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 667μs 3.77μs 26.4μs 0 0 0 41.96 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 697μs 4.02μs 32.9μs 0 0 0 42.44 KB
master WriteAndFlushEnrichedTraces net472 950μs 2.96μs 13.6μs 4.81 0 0 56.09 KB
#7452 WriteAndFlushEnrichedTraces net6.0 673μs 432ns 1.67μs 0 0 0 41.81 KB
#7452 WriteAndFlushEnrichedTraces netcoreapp3.1 699μs 4.06μs 37.2μs 0 0 0 41.88 KB
#7452 WriteAndFlushEnrichedTraces net472 850μs 2.79μs 10.4μs 4.46 0 0 55.78 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.82μs 9.04ns 36.2ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.56μs 7.74ns 29ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.74μs 2.94ns 11.4ns 0.151 0.0137 0 987 B
#7452 ExecuteNonQuery net6.0 1.91μs 2.72ns 10.5ns 0 0 0 1.02 KB
#7452 ExecuteNonQuery netcoreapp3.1 2.54μs 8.07ns 31.3ns 0 0 0 1.02 KB
#7452 ExecuteNonQuery net472 2.72μs 2.84ns 11ns 0.15 0.0137 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.72μs 8.5ns 31.8ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.28μs 4.97ns 19.2ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.64μs 1.35ns 4.86ns 0.164 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.84μs 8.87ns 37.6ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.33μs 7.56ns 28.3ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.82μs 1.49ns 5.75ns 0.172 0 0 1.1 KB
#7452 CallElasticsearch net6.0 1.72μs 7.62ns 29.5ns 0 0 0 1.03 KB
#7452 CallElasticsearch netcoreapp3.1 2.26μs 10.9ns 45.1ns 0 0 0 1.03 KB
#7452 CallElasticsearch net472 3.53μs 1.94ns 7.28ns 0.16 0 0 1.04 KB
#7452 CallElasticsearchAsync net6.0 1.81μs 7.43ns 28.8ns 0 0 0 1.01 KB
#7452 CallElasticsearchAsync netcoreapp3.1 2.34μs 11.3ns 43.6ns 0 0 0 1.08 KB
#7452 CallElasticsearchAsync net472 3.84μs 8.64ns 33.5ns 0.173 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.82μs 6.36ns 24.6ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.25μs 7.98ns 30.9ns 0 0 0 952 B
master ExecuteAsync net472 2.52μs 2.81ns 10.5ns 0.14 0 0 915 B
#7452 ExecuteAsync net6.0 1.81μs 0.62ns 2.32ns 0 0 0 952 B
#7452 ExecuteAsync netcoreapp3.1 2.24μs 10.8ns 45.9ns 0 0 0 952 B
#7452 ExecuteAsync net472 2.59μs 1.17ns 4.52ns 0.142 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.98μs 7.97ns 28.7ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.26μs 24.8ns 95.9ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 7.03ns 27.2ns 0.489 0 0 3.18 KB
#7452 SendAsync net6.0 6.93μs 12.4ns 47.9ns 0 0 0 2.36 KB
#7452 SendAsync netcoreapp3.1 8.35μs 21.3ns 82.4ns 0 0 0 2.9 KB
#7452 SendAsync net472 12.4μs 6.8ns 25.5ns 0.496 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7452

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 260 KB 274.74 KB 14.74 KB 5.67%

Fewer allocations 🎉 in #7452

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 275.52 KB 273.91 KB -1.61 KB -0.58%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 43.28 KB 42.89 KB -392 B -0.91%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 289.12 KB 276.62 KB -12.5 KB -4.32%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 46.3μs 266ns 1.94μs 0 0 0 44.03 KB
master StringConcatBenchmark netcoreapp3.1 49.2μs 264ns 1.81μs 0 0 0 43.28 KB
master StringConcatBenchmark net472 57.5μs 155ns 580ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 467μs 1.22μs 4.23μs 0 0 0 260 KB
master StringConcatAspectBenchmark netcoreapp3.1 525μs 2.63μs 11.2μs 0 0 0 275.52 KB
master StringConcatAspectBenchmark net472 411μs 2.09μs 9.59μs 0 0 0 289.12 KB
#7452 StringConcatBenchmark net6.0 48.5μs 264ns 1.42μs 0 0 0 44.07 KB
#7452 StringConcatBenchmark netcoreapp3.1 51.1μs 376ns 3.65μs 0 0 0 42.89 KB
#7452 StringConcatBenchmark net472 57.6μs 192ns 743ns 0 0 0 65.54 KB
#7452 StringConcatAspectBenchmark net6.0 494μs 2.3μs 9.5μs 0 0 0 274.74 KB
#7452 StringConcatAspectBenchmark netcoreapp3.1 531μs 1.95μs 7.05μs 0 0 0 273.91 KB
#7452 StringConcatAspectBenchmark net472 402μs 2.28μs 16.9μs 0 0 0 276.62 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.57μs 12.1ns 47ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.4μs 13.3ns 51.4ns 0 0 0 1.7 KB
master EnrichedLog net472 4.05μs 2.42ns 9.36ns 0.242 0 0 1.64 KB
#7452 EnrichedLog net6.0 2.52μs 1.97ns 7.61ns 0 0 0 1.7 KB
#7452 EnrichedLog netcoreapp3.1 3.31μs 16.7ns 72.6ns 0 0 0 1.7 KB
#7452 EnrichedLog net472 4.06μs 6.51ns 25.2ns 0.243 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 59.5ns 223ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 126μs 226ns 876ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 33.6ns 130ns 0 0 0 4.52 KB
#7452 EnrichedLog net6.0 124μs 108ns 405ns 0 0 0 4.31 KB
#7452 EnrichedLog netcoreapp3.1 128μs 63.8ns 230ns 0 0 0 4.31 KB
#7452 EnrichedLog net472 168μs 63.1ns 236ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.91μs 4.38ns 16.4ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.72μs 13ns 45ns 0 0 0 2.26 KB
master EnrichedLog net472 7.3μs 6.92ns 26.8ns 0.329 0 0 2.08 KB
#7452 EnrichedLog net6.0 5μs 10.6ns 39.8ns 0 0 0 2.26 KB
#7452 EnrichedLog netcoreapp3.1 6.63μs 13.9ns 53.8ns 0 0 0 2.26 KB
#7452 EnrichedLog net472 7.53μs 11.2ns 43.5ns 0.298 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 1.69ns 6.54ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.57μs 12.5ns 50ns 0 0 0 1.2 KB
master SendReceive net472 3.14μs 2.79ns 10.8ns 0.19 0 0 1.2 KB
#7452 SendReceive net6.0 2.04μs 9.5ns 38ns 0 0 0 1.2 KB
#7452 SendReceive netcoreapp3.1 2.6μs 10.2ns 39.6ns 0 0 0 1.2 KB
#7452 SendReceive net472 3.1μs 5.29ns 20.5ns 0.187 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.25μs 6.68ns 25.9ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.65μs 10.4ns 40.2ns 0 0 0 1.63 KB
master EnrichedLog net472 6.65μs 7.42ns 28.7ns 0.298 0 0 2.03 KB
#7452 EnrichedLog net6.0 4.09μs 6.25ns 24.2ns 0 0 0 1.58 KB
#7452 EnrichedLog netcoreapp3.1 5.51μs 8.51ns 33ns 0 0 0 1.63 KB
#7452 EnrichedLog net472 6.64μs 13.3ns 49.9ns 0.297 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 739ns 3.71ns 17ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 914ns 4.79ns 23.5ns 0 0 0 576 B
master StartFinishSpan net472 909ns 0.0989ns 0.37ns 0.0909 0 0 578 B
master StartFinishScope net6.0 876ns 4.66ns 23.3ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.12μs 5.37ns 21.5ns 0 0 0 696 B
master StartFinishScope net472 1.14μs 0.813ns 3.04ns 0.103 0 0 658 B
#7452 StartFinishSpan net6.0 730ns 3.82ns 20.2ns 0 0 0 576 B
#7452 StartFinishSpan netcoreapp3.1 937ns 4.58ns 18.3ns 0 0 0 576 B
#7452 StartFinishSpan net472 900ns 0.0427ns 0.154ns 0.0901 0 0 578 B
#7452 StartFinishScope net6.0 884ns 4.11ns 15.9ns 0 0 0 696 B
#7452 StartFinishScope netcoreapp3.1 1.12μs 5.37ns 21.5ns 0 0 0 696 B
#7452 StartFinishScope net472 1.11μs 1.63ns 6.32ns 0.101 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 1.58ns 6.1ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.35μs 4.97ns 19.2ns 0 0 0 696 B
master RunOnMethodBegin net472 1.38μs 0.146ns 0.545ns 0.103 0 0 658 B
#7452 RunOnMethodBegin net6.0 1.04μs 2.08ns 8.04ns 0 0 0 696 B
#7452 RunOnMethodBegin netcoreapp3.1 1.4μs 6.77ns 26.2ns 0 0 0 696 B
#7452 RunOnMethodBegin net472 1.36μs 1.22ns 4.73ns 0.102 0 0 658 B

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Aug 29, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (73ms)  : 72, 74
     .   : milestone, 73,
    master - mean (73ms)  : 72, 75
     .   : milestone, 73,

    section Baseline
    This PR (7452) - mean (70ms)  : 65, 76
     .   : milestone, 70,
    master - mean (70ms)  : 65, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (1,000ms)  : 968, 1032
     .   : milestone, 1000,
    master - mean (996ms)  : 972, 1019
     .   : milestone, 996,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (110ms)  : 108, 112
     .   : milestone, 110,
    master - mean (110ms)  : 108, 112
     .   : milestone, 110,

    section Baseline
    This PR (7452) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (708ms)  : 688, 728
     .   : milestone, 708,
    master - mean (707ms)  : 681, 733
     .   : milestone, 707,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (97ms)  : 95, 98
     .   : milestone, 97,
    master - mean (96ms)  : 94, 97
     .   : milestone, 96,

    section Baseline
    This PR (7452) - mean (96ms)  : 93, 99
     .   : milestone, 96,
    master - mean (95ms)  : 93, 97
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (661ms)  : 641, 682
     .   : milestone, 661,
    master - mean (662ms)  : 638, 685
     .   : milestone, 662,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (96ms)  : 94, 97
     .   : milestone, 96,
    master - mean (95ms)  : 94, 96
     .   : milestone, 95,

    section Baseline
    This PR (7452) - mean (95ms)  : 92, 98
     .   : milestone, 95,
    master - mean (94ms)  : 92, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (595ms)  : 582, 607
     .   : milestone, 595,
    master - mean (599ms)  : 584, 614
     .   : milestone, 599,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (193ms)  : 190, 196
     .   : milestone, 193,
    master - mean (195ms)  : 192, 198
     .   : milestone, 195,

    section Baseline
    This PR (7452) - mean (190ms)  : 184, 196
     .   : milestone, 190,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (1,099ms)  : 1070, 1128
     .   : milestone, 1099,
    master - mean (1,101ms)  : 1058, 1144
     .   : milestone, 1101,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (275ms)  : 270, 279
     .   : milestone, 275,
    master - mean (274ms)  : 271, 277
     .   : milestone, 274,

    section Baseline
    This PR (7452) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (273ms)  : 269, 277
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (924ms)  : 835, 1014
     .   : milestone, 924,
    master - mean (893ms)  : 853, 933
     .   : milestone, 893,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section Baseline
    This PR (7452) - mean (329ms)  : 324, 334
     .   : milestone, 329,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (875ms)  : 837, 912
     .   : milestone, 875,
    master - mean (871ms)  : 838, 904
     .   : milestone, 871,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7452) - mean (267ms)  : 262, 273
     .   : milestone, 267,
    master - mean (266ms)  : 263, 270
     .   : milestone, 266,

    section Baseline
    This PR (7452) - mean (266ms)  : 261, 272
     .   : milestone, 266,
    master - mean (266ms)  : 261, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7452) - mean (785ms)  : 756, 814
     .   : milestone, 785,
    master - mean (791ms)  : 763, 819
     .   : milestone, 791,
Loading

@gleocadie gleocadie force-pushed the gleocadie/try-fixing-tsan-job branch from 048a1e8 to f3fc260 Compare September 2, 2025 12:04
andrewlock
andrewlock approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it fixes the issue!

@gleocadie gleocadie marked this pull request as ready for review September 2, 2025 14:31
@gleocadie gleocadie requested a review from a team as a code owner September 2, 2025 14:31
@gleocadie gleocadie merged commit f4d5bcb into master Sep 2, 2025
167 checks passed
@gleocadie gleocadie deleted the gleocadie/try-fixing-tsan-job branch September 2, 2025 14:31
@github-actions github-actions bot added this to the vNext-v3 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler
Projects
None yet
Milestone
vNext-v3
Development

Successfully merging this pull request may close these issues.
2 participants
@gleocadie @andrewlock