Skip to content

[ASM] Fix IAST Grpc DotNet flaky test #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

[ASM] Fix IAST Grpc DotNet flaky test #6772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tracer/test/Datadog.Trace.Security.IntegrationTests/IAST/Grpc/GrpcDotNetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ public async Task SubmitsTraces()

const int expectedSpanCount = 24;
const string filename = "Iast.GrpcDotNetTests.BodyPropagation.SubmitsTraces";

// No meta structs support for this test as vulnerabilities can be triggered at the start of the app
// The tracer could possibly not have the time to load the mock agent configuration
using var agent = EnvironmentHelper.GetMockAgent();
agent.Configuration.SpanMetaStructs = false;
using var process = await RunSampleAndWaitForExit(agent);

var spans = agent.WaitForSpans(expectedSpanCount);
var spansFiltered = spans.Where(x => x.Type == SpanTypes.Web).ToList();

Expand Down
12 changes: 0 additions & 12 deletions tracer/test/snapshots/Iast.GrpcDotNetTests.BodyPropagation.SubmitsTraces.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@
_dd.top_level: 1.0,
_dd.tracer_kr: 1.0,
_sampling_priority_v1: 2.0
},
MetaStruct: {
iast:
}
},
{
Expand Down Expand Up @@ -116,9 +113,6 @@
_dd.top_level: 1.0,
_dd.tracer_kr: 1.0,
_sampling_priority_v1: 2.0
},
MetaStruct: {
iast:
}
},
{
Expand Down Expand Up @@ -177,9 +171,6 @@
_dd.top_level: 1.0,
_dd.tracer_kr: 1.0,
_sampling_priority_v1: 2.0
},
MetaStruct: {
iast:
}
},
{
Expand Down Expand Up @@ -238,9 +229,6 @@
_dd.top_level: 1.0,
_dd.tracer_kr: 1.0,
_sampling_priority_v1: 2.0
},
MetaStruct: {
iast:
}
}
]
Loading