Set "component" tag for ASP.NET #6010

bouwkast · 2024-09-09T15:21:42Z

Summary of changes

Sets component tag for ASP.NET to aspnet

Reason for change

component tag was missing.

Implementation details

Add missing tag.

Test coverage

Lots of snapshots

Other details

lucaspimentel · 2024-09-09T15:46:30Z

tracer/src/Datadog.Trace/Tagging/AspNetTags.cs

        public string HttpRoute { get; set; }
+
+        [Tag(Trace.Tags.InstrumentationName)]
+        public string InstrumentationName { get; set; } = ComponentName;


This is used in pretty much every integration. Should we move it to InstrumentationTags? (not necessarily this PR, just something to think about)

andrewlock · 2024-09-09T15:48:58Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (6010) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (1,054ms)  : 993, 1115
     .   : milestone, 1054,
    master - mean (1,055ms)  : 991, 1120
     .   : milestone, 1055,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (106ms)  : 105, 107
     .   : milestone, 106,
    master - mean (106ms)  : 105, 108
     .   : milestone, 106,

    section Baseline
    This PR (6010) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (744ms)  : 721, 766
     .   : milestone, 744,
    master - mean (744ms)  : 722, 767
     .   : milestone, 744,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (100ms)  : 99, 101
     .   : milestone, 100,
    master - mean (100ms)  : 100, 101
     .   : milestone, 100,

    section Baseline
    This PR (6010) - mean (100ms)  : 97, 102
     .   : milestone, 100,
    master - mean (100ms)  : 97, 102
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (773ms)  : 723, 823
     .   : milestone, 773,
    master - mean (770ms)  : 719, 821
     .   : milestone, 770,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (92ms)  : 91, 93
     .   : milestone, 92,

    section Baseline
    This PR (6010) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (657ms)  : 644, 671
     .   : milestone, 657,
    master - mean (664ms)  : 649, 679
     .   : milestone, 664,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (201ms)  : 198, 205
     .   : milestone, 201,
    master - mean (202ms)  : 197, 207
     .   : milestone, 202,

    section Baseline
    This PR (6010) - mean (200ms)  : 193, 207
     .   : milestone, 200,
    master - mean (199ms)  : 192, 205
     .   : milestone, 199,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (1,190ms)  : 1123, 1257
     .   : milestone, 1190,
    master - mean (1,181ms)  : 1129, 1233
     .   : milestone, 1181,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (285ms)  : 279, 291
     .   : milestone, 285,
    master - mean (287ms)  : 277, 298
     .   : milestone, 287,

    section Baseline
    This PR (6010) - mean (285ms)  : 278, 292
     .   : milestone, 285,
    master - mean (286ms)  : 277, 294
     .   : milestone, 286,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (953ms)  : 913, 994
     .   : milestone, 953,
    master - mean (960ms)  : 921, 999
     .   : milestone, 960,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (288ms)  : 282, 293
     .   : milestone, 288,
    master - mean (289ms)  : 282, 296
     .   : milestone, 289,

    section Baseline
    This PR (6010) - mean (288ms)  : 280, 296
     .   : milestone, 288,
    master - mean (288ms)  : 280, 297
     .   : milestone, 288,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (998ms)  : 936, 1061
     .   : milestone, 998,
    master - mean (1,010ms)  : 956, 1064
     .   : milestone, 1010,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (278ms)  : 273, 282
     .   : milestone, 278,
    master - mean (279ms)  : 270, 288
     .   : milestone, 279,

    section Baseline
    This PR (6010) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (277ms)  : 269, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (867ms)  : 840, 895
     .   : milestone, 867,
    master - mean (873ms)  : 848, 898
     .   : milestone, 873,

datadog-ddstaging · 2024-09-09T15:50:14Z

Datadog Report

Branch report: steven/AIDM-312
Commit report: 4540146
Test service: dd-trace-dotnet

❌ 6 Failed (1 Known Flaky), 468894 Passed, 3265 Skipped, 28h 55m 43.35s Total Time

❌ Failed Tests (6)

This report shows up to 5 failed tests.

WriteAndFlushEnrichedTraces - Benchmarks.Trace.AgentWriterBenchmark - Details
SendRequest - Benchmarks.Trace.AspNetCoreBenchmark - Details
WriteAndFlushEnrichedTraces - Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Details
ExecuteNonQuery - Benchmarks.Trace.DbCommandBenchmark - Details
ManualAndAutomatic - Datadog.Trace.ClrProfiler.IntegrationTests.ManualInstrumentationTests - ❄️ Known flaky - Details
Expand for error
```
 Expected exit code: 0, actual exit code: -2146233082.
```

andrewlock · 2024-09-09T17:22:48Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (11.204M)   : 0, 11204202
    master (11.115M)   : 0, 11115307
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6010) (7.293M)   : 0, 7293026
    master (7.335M)   : 0, 7334625
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.700M)   : 0, 7700429

    section Manual
    master (10.990M)   : 0, 10989510

    section Manual + Automatic
    This PR (6010) (6.869M)   : 0, 6869215
    master (6.780M)   : 0, 6780487

    section DD_TRACE_ENABLED=0
    master (10.305M)   : 0, 10305060

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (9.531M)   : 0, 9530910
    master (9.774M)   : 0, 9773727
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6010) (6.474M)   : 0, 6474248
    master (6.463M)   : 0, 6462618

    section Trace stats
    master (6.907M)   : 0, 6906626

    section Manual
    master (9.697M)   : 0, 9697280

    section Manual + Automatic
    This PR (6010) (6.172M)   : 0, 6172072
    master (6.155M)   : 0, 6155472

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8867528

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (9.775M)   : 0, 9775351
    master (10.077M)   : 0, 10076675
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6010) (6.472M)   : 0, 6472450
    master (6.567M)   : 0, 6566975
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.314M)   : 0, 7314135

    section Manual
    master (10.073M)   : 0, 10073436

    section Manual + Automatic
    This PR (6010) (6.103M)   : 0, 6103152
    master (6.134M)   : 0, 6134127

    section DD_TRACE_ENABLED=0
    master (9.536M)   : 0, 9535909

andrewlock · 2024-09-09T17:33:30Z

Benchmarks Report for tracer 🐌

Benchmarks for #6010 compared to master:

2 benchmarks are faster, with geometric mean 1.198
1 benchmarks are slower, with geometric mean 1.134
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.86μs	37.4ns	191ns	0.0155	0.00777	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	53.3ns	277ns	0.0145	0.00483	0	5.8 KB
master	`StartStopWithChild`	net472	15.8μs	35.3ns	132ns	1.03	0.293	0.0952	6.21 KB
#6010	`StartStopWithChild`	net6.0	7.81μs	43.5ns	278ns	0.0204	0.0122	0.00407	5.61 KB
#6010	`StartStopWithChild`	netcoreapp3.1	10.2μs	47.2ns	216ns	0.0155	0.00516	0	5.8 KB
#6010	`StartStopWithChild`	net472	15.9μs	45.1ns	169ns	1.05	0.324	0.103	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	519μs	350ns	1.36μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	607ns	2.27μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	851μs	292ns	1.09μs	0.422	3.3 KB
#6010	`WriteAndFlushEnrichedTraces`	net6.0	491μs	599ns	2.24μs	0	2.7 KB
#6010	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	218ns	786ns	0	2.7 KB
#6010	`WriteAndFlushEnrichedTraces`	net472	845μs	461ns	1.79μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	131μs	529ns	2.05μs	0.132	14.47 KB
master	`SendRequest`	netcoreapp3.1	150μs	238ns	920ns	0.226	17.27 KB
master	`SendRequest`	net472	0.00515ns	0.00186ns	0.00721ns	0	0 b
#6010	`SendRequest`	net6.0	129μs	663ns	2.97μs	0.13	14.47 KB
#6010	`SendRequest`	netcoreapp3.1	145μs	357ns	1.38μs	0.216	17.27 KB
#6010	`SendRequest`	net472	0.0076ns	0.00206ns	0.008ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6010

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.75 KB	41.5 KB	-250 B	-0.60%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	591μs	3.09μs	16μs	0.631	0	0	41.46 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	3.12μs	11.7μs	0.355	0	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	net472	851μs	3.13μs	12.1μs	8.81	2.52	0.419	53.32 KB
#6010	`WriteAndFlushEnrichedTraces`	net6.0	581μs	3.13μs	18μs	0.551	0	0	41.66 KB
#6010	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	744μs	4.21μs	29.2μs	0.372	0	0	41.5 KB
#6010	`WriteAndFlushEnrichedTraces`	net472	832μs	2.49μs	9.3μs	8.39	2.52	0.419	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	2.62ns	10.1ns	0.0146	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	3.43ns	13.3ns	0.0129	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.15μs	2.1ns	7.84ns	0.156	0.00107	987 B
#6010	`ExecuteNonQuery`	net6.0	1.25μs	1.51ns	5.85ns	0.0144	0	1.02 KB
#6010	`ExecuteNonQuery`	netcoreapp3.1	1.72μs	1.76ns	6.6ns	0.0131	0	1.02 KB
#6010	`ExecuteNonQuery`	net472	2.15μs	1.88ns	7.03ns	0.156	0.00109	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6010

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.134	1,222.49	1,386.37

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.527ns	2.04ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.729ns	2.73ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.66μs	1.78ns	6.89ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.22μs	0.825ns	3.2ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	2.08ns	8.06ns	0.0138	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	1.2ns	4.48ns	0.166	1.05 KB
#6010	`CallElasticsearch`	net6.0	1.28μs	2.02ns	7.56ns	0.0135	976 B
#6010	`CallElasticsearch`	netcoreapp3.1	1.54μs	1.46ns	5.47ns	0.0131	976 B
#6010	`CallElasticsearch`	net472	2.47μs	1.77ns	6.84ns	0.158	995 B
#6010	`CallElasticsearchAsync`	net6.0	1.39μs	0.377ns	1.46ns	0.0132	952 B
#6010	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.889ns	3.44ns	0.0136	1.02 KB
#6010	`CallElasticsearchAsync`	net472	2.72μs	1.72ns	6.67ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.3μs	0.677ns	2.62ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.678ns	2.63ns	0.0123	952 B
master	`ExecuteAsync`	net472	1.87μs	0.755ns	2.93ns	0.145	915 B
#6010	`ExecuteAsync`	net6.0	1.36μs	0.614ns	2.3ns	0.013	952 B
#6010	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.65ns	2.34ns	0.0124	952 B
#6010	`ExecuteAsync`	net472	1.85μs	0.601ns	2.33ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.51μs	2.1ns	7.85ns	0.0312	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.35μs	1.63ns	6.33ns	0.0374	2.85 KB
master	`SendAsync`	net472	7.46μs	2.18ns	8.46ns	0.493	3.12 KB
#6010	`SendAsync`	net6.0	4.27μs	2.07ns	7.47ns	0.032	2.31 KB
#6010	`SendAsync`	netcoreapp3.1	5.26μs	2.5ns	9.67ns	0.0392	2.85 KB
#6010	`SendAsync`	net472	7.48μs	1.73ns	6.7ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	0.417ns	1.56ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	0.478ns	1.66ns	0.0227	1.64 KB
master	`EnrichedLog`	net472	2.54μs	1.02ns	3.97ns	0.249	1.57 KB
#6010	`EnrichedLog`	net6.0	1.62μs	0.918ns	3.44ns	0.0233	1.64 KB
#6010	`EnrichedLog`	netcoreapp3.1	2.13μs	1.47ns	5.49ns	0.0212	1.64 KB
#6010	`EnrichedLog`	net472	2.77μs	1.27ns	4.57ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	130ns	487ns	0.0559	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	116μs	191ns	741ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	84.5ns	327ns	0.674	0.225	4.46 KB
#6010	`EnrichedLog`	net6.0	113μs	139ns	521ns	0.056	0	4.28 KB
#6010	`EnrichedLog`	netcoreapp3.1	116μs	112ns	432ns	0	0	4.28 KB
#6010	`EnrichedLog`	net472	150μs	108ns	417ns	0.675	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3μs	1.37ns	5.32ns	0.0299	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.28μs	2.96ns	11.5ns	0.0297	2.2 KB
master	`EnrichedLog`	net472	4.97μs	1.79ns	6.92ns	0.32	2.02 KB
#6010	`EnrichedLog`	net6.0	2.89μs	1.15ns	3.97ns	0.0303	2.2 KB
#6010	`EnrichedLog`	netcoreapp3.1	4.26μs	1.2ns	4.49ns	0.0298	2.2 KB
#6010	`EnrichedLog`	net472	4.87μs	1.27ns	4.93ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.29μs	1.22ns	4.73ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.71μs	2.64ns	10.2ns	0.0155	1.14 KB
master	`SendReceive`	net472	1.98μs	1.68ns	6.49ns	0.183	1.16 KB
#6010	`SendReceive`	net6.0	1.37μs	0.826ns	3.09ns	0.0157	1.14 KB
#6010	`SendReceive`	netcoreapp3.1	1.8μs	1.22ns	4.58ns	0.0153	1.14 KB
#6010	`SendReceive`	net472	2.16μs	1.07ns	4.15ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	1.18ns	4.55ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.91μs	3.11ns	12.1ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.39μs	1.99ns	6.89ns	0.322	2.04 KB
#6010	`EnrichedLog`	net6.0	2.76μs	1.09ns	4.2ns	0.0222	1.6 KB
#6010	`EnrichedLog`	netcoreapp3.1	3.84μs	1.52ns	5.87ns	0.0211	1.65 KB
#6010	`EnrichedLog`	net472	4.26μs	3.21ns	12.4ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6010

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.198	575.79	480.44
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.197	481.69	402.50

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	482ns	0.868ns	3.36ns	0.00798	576 B
master	`StartFinishSpan`	netcoreapp3.1	547ns	0.762ns	2.85ns	0.00786	576 B
master	`StartFinishSpan`	net472	630ns	1.17ns	4.54ns	0.0918	578 B
master	`StartFinishScope`	net6.0	575ns	0.882ns	3.42ns	0.00966	696 B
master	`StartFinishScope`	netcoreapp3.1	669ns	0.458ns	1.71ns	0.0093	696 B
master	`StartFinishScope`	net472	805ns	1.48ns	5.75ns	0.105	658 B
#6010	`StartFinishSpan`	net6.0	402ns	0.395ns	1.53ns	0.00801	576 B
#6010	`StartFinishSpan`	netcoreapp3.1	546ns	0.755ns	2.92ns	0.00769	576 B
#6010	`StartFinishSpan`	net472	572ns	0.863ns	3.34ns	0.0916	578 B
#6010	`StartFinishScope`	net6.0	481ns	0.608ns	2.35ns	0.00968	696 B
#6010	`StartFinishScope`	netcoreapp3.1	741ns	0.992ns	3.84ns	0.00944	696 B
#6010	`StartFinishScope`	net472	812ns	1.45ns	5.63ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	650ns	0.737ns	2.85ns	0.00982	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	984ns	1.68ns	6.49ns	0.00924	696 B
master	`RunOnMethodBegin`	net472	1.01μs	2.88ns	11.2ns	0.105	658 B
#6010	`RunOnMethodBegin`	net6.0	663ns	0.67ns	2.6ns	0.0097	696 B
#6010	`RunOnMethodBegin`	netcoreapp3.1	943ns	1.23ns	4.62ns	0.00934	696 B
#6010	`RunOnMethodBegin`	net472	1.05μs	2.46ns	9.52ns	0.104	658 B

github-actions · 2024-09-09T18:02:06Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2351 occurrences of :

+      component: aspnet,

14 occurrences of :

-      language: dotnet,
[...]
-      _dd.base_service: Samples.CosmosDb
+      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
+      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet

14 occurrences of :

-      language: dotnet,
[...]
+      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
+      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet,

tracer/test/snapshots/CosmosTests.SubmitTraces_SchemaV0.verified.txt

tracer/test/snapshots/CosmosTests.SubmitTraces_SchemaV1.verified.txt

andrewlock

Looks like I started a review of this ages ago, and then GitHub hung and never submitted it because of all the snapshots 💀

andrewlock · 2024-09-27T10:00:51Z

tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs

                string httpMethod = httpRequest.HttpMethod.ToUpperInvariant();
                string url = httpContext.Request.GetUrlForSpan(tracer.TracerManager.QueryStringManager);
                var tags = new WebTags();
+                tags.SetTag("component", "aspnet"); // TODO unsure why this is using WebTags and not AspNetTags


Good question 🤔 my guess is because we don't set any of the additional tags that aspnettags has?

Right. This integration doesn't add any of the tags in AspNetTags (no route, controller, area) so WebTags is good enough.

I would probably just update this comment and add InstrumentationName to InstrumentationTags in a separate PR (which includes WebTags and AspNetTags), instead of trying to add InstrumentationName to WebTags now.

tracer/test/snapshots/CosmosTests.SubmitTraces_SchemaV0.verified.txt

tracer/test/snapshots/CosmosTests.SubmitTraces_SchemaV1.verified.txt

## Summary of changes Updates the CosmosDb snapshots. ## Reason for change These aren't updated on CI and were out of date. Were included in #6010, but it looked like the ones included were already out of date, these should be goo. ## Implementation details Ran integration tests locally against v3.45.0 of Cosmos. ## Test coverage ## Other details https://datadoghq.atlassian.net/browse/AIDM-361

datadog-ddstaging · 2025-02-11T16:17:42Z

Datadog Report

Branch report: steven/AIDM-312
Commit report: fedd41e
Test service: dd-trace-dotnet

❌ 35 Failed (0 Known Flaky), 553934 Passed, 4467 Skipped, 32h 7m 18.8s Total Time

❌ Failed Tests (35)

This report shows up to 5 failed tests.

HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Details

Expand for error

 
 Expected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:httpmessagehandler".

TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

Expand for error

 
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet-webapi.request,
     Resource: GET /api/route/{id},
     Service: sample,
     Type: web,
     ParentId: Id_3,
 ...

TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

Expand for error

 
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet-webapi.request,
     Resource: GET /api/route/{id},
     Service: sample,
     Type: web,
     ParentId: Id_3,
 ...

TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

Expand for error

 
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet-webapi.request,
     Resource: POST /api/home/{id},
     Service: sample,
     Type: web,
     ParentId: Id_3,
 ...

TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

Expand for error

 
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet-webapi.request,
     Resource: POST /api/home/{id},
     Service: sample,
     Type: web,
     ParentId: Id_3,
 ...

datadog-datadog-prod-us1 · 2025-05-08T12:22:55Z

Datadog Report

All test runs 67a9253 🔗

❌ 2 Total Test Services: 1 Failed, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
`dd-trace-dotnet`	110	0	0	567170	4291	31h 52m 25.6s	Link
`exploration_tests`	0	0	0	22085	3	2m 11.21s	Link