Suppress build warnings we don't care about #5096

andrewlock · 2024-01-22T11:57:54Z

Summary of changes

Adds <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> to test projects to avoid warnings

Reason for change

The warnings are annoying and pointless

Implementation details

Added SuppressTfmSupportBuildWarnings to a couple of Directory.Build.props files

Test coverage

No change

Other details

Add <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> to test projects and

datadog-ddstaging · 2024-01-22T12:12:44Z

Datadog Report

Branch report: andrew/ci/suppress-warnings
Commit report: 69d8af9
Test service: dd-trace-dotnet

✅ 0 Failed, 309311 Passed, 1507 Skipped, 1h 1m 2.5s Wall Time

andrewlock · 2024-01-22T12:21:15Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5096) - mean (71ms)  : 62, 80
     .   : milestone, 71,
    master - mean (71ms)  : 62, 80
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (5096) - mean (954ms)  : 924, 984
     .   : milestone, 954,
    master - mean (951ms)  : 928, 975
     .   : milestone, 951,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5096) - mean (106ms)  : 100, 111
     .   : milestone, 106,
    master - mean (106ms)  : 101, 111
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (5096) - mean (689ms)  : 667, 711
     .   : milestone, 689,
    master - mean (691ms)  : 673, 710
     .   : milestone, 691,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5096) - mean (89ms)  : 84, 94
     .   : milestone, 89,
    master - mean (89ms)  : 85, 93
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (5096) - mean (650ms)  : 634, 666
     .   : milestone, 650,
    master - mean (649ms)  : 630, 669
     .   : milestone, 649,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5096) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (188ms)  : 185, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5096) - mean (1,068ms)  : 1048, 1087
     .   : milestone, 1068,
    master - mean (1,066ms)  : 1041, 1090
     .   : milestone, 1066,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5096) - mean (272ms)  : 267, 277
     .   : milestone, 272,
    master - mean (271ms)  : 267, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5096) - mean (1,048ms)  : 1021, 1076
     .   : milestone, 1048,
    master - mean (1,049ms)  : 1026, 1071
     .   : milestone, 1049,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5096) - mean (260ms)  : 254, 265
     .   : milestone, 260,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (5096) - mean (1,015ms)  : 990, 1041
     .   : milestone, 1015,
    master - mean (1,014ms)  : 986, 1041
     .   : milestone, 1014,

andrewlock · 2024-01-23T02:27:47Z

Benchmarks Report 🐌

Benchmarks for #5096 compared to master:

1 benchmarks are slower, with geometric mean 1.122
4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.8μs	48.3ns	282ns	0.0225	0.009	0	7.48 KB
master	`StartStopWithChild`	netcoreapp3.1	10.7μs	56.8ns	341ns	0.0216	0.0054	0	7.58 KB
master	`StartStopWithChild`	net472	17.2μs	55.1ns	213ns	1.34	0.353	0.129	7.96 KB
#5096	`StartStopWithChild`	net6.0	8.67μs	42.8ns	181ns	0.0213	0.00425	0	7.49 KB
#5096	`StartStopWithChild`	netcoreapp3.1	10.6μs	56.9ns	332ns	0.0247	0.00989	0	7.57 KB
#5096	`StartStopWithChild`	net472	17.3μs	58.7ns	227ns	1.34	0.352	0.112	7.95 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	338ns	1.31μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	350ns	1.36μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	778μs	351ns	1.36μs	0.388	3.3 KB
#5096	`WriteAndFlushEnrichedTraces`	net6.0	458μs	206ns	771ns	0	2.7 KB
#5096	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	640μs	533ns	1.99μs	0	2.7 KB
#5096	`WriteAndFlushEnrichedTraces`	net472	788μs	274ns	988ns	0.393	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	39.5μs	71.5ns	267ns	0.0195	0	1.77 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	42.3μs	33.3ns	129ns	0.0211	0	1.74 KB
master	`AllCycleSimpleBody`	net472	45μs	21.3ns	82.5ns	0.271	0	1.81 KB
master	`AllCycleMoreComplexBody`	net6.0	204μs	72.9ns	282ns	0.1	0	9.25 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	211μs	290ns	1.12μs	0.105	0	9.14 KB
master	`AllCycleMoreComplexBody`	net472	226μs	79.7ns	309ns	1.46	0	9.32 KB
master	`ObjectExtractorSimpleBody`	net6.0	144ns	0.261ns	1.01ns	0.00396	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	207ns	0.128ns	0.48ns	0.00364	0	272 B
master	`ObjectExtractorSimpleBody`	net472	166ns	0.149ns	0.576ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.95μs	1.49ns	5.56ns	0.0533	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.05μs	1.57ns	6.06ns	0.0506	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.79μs	1.52ns	5.46ns	0.602	0.00567	3.8 KB
#5096	`AllCycleSimpleBody`	net6.0	39μs	47ns	182ns	0.0192	0	1.77 KB
#5096	`AllCycleSimpleBody`	netcoreapp3.1	42.3μs	114ns	442ns	0.021	0	1.74 KB
#5096	`AllCycleSimpleBody`	net472	44.4μs	15.8ns	61.2ns	0.266	0	1.81 KB
#5096	`AllCycleMoreComplexBody`	net6.0	200μs	168ns	649ns	0.1	0	9.25 KB
#5096	`AllCycleMoreComplexBody`	netcoreapp3.1	214μs	276ns	1.07μs	0.107	0	9.14 KB
#5096	`AllCycleMoreComplexBody`	net472	228μs	85.6ns	331ns	1.48	0	9.32 KB
#5096	`ObjectExtractorSimpleBody`	net6.0	143ns	0.12ns	0.45ns	0.00394	0	280 B
#5096	`ObjectExtractorSimpleBody`	netcoreapp3.1	198ns	0.209ns	0.723ns	0.00368	0	272 B
#5096	`ObjectExtractorSimpleBody`	net472	161ns	0.0437ns	0.157ns	0.0446	0	281 B
#5096	`ObjectExtractorMoreComplexBody`	net6.0	3.03μs	2.35ns	8.79ns	0.0529	0	3.78 KB
#5096	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.05μs	2.11ns	7.88ns	0.0507	0	3.69 KB
#5096	`ObjectExtractorMoreComplexBody`	net472	3.78μs	2.66ns	10.3ns	0.603	0.00567	3.8 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`RunWaf(args=NestedMap (10))`	net6.0	51.4μs	133ns	609ns	0.229	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	72.3μs	67.6ns	244ns	0.199	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	net472	96.7μs	53.4ns	207ns	2.56	0.0967	16.14 KB
master	`RunWafTwice(args=NestedMap (10))`	net6.0	54.8μs	21.8ns	81.7ns	0.218	0	16.6 KB
master	`RunWafTwice(args=NestedMap (10))`	netcoreapp3.1	72.8μs	404ns	2.49μs	0.227	0	16.58 KB
master	`RunWafTwice(args=NestedMap (10))`	net472	104μs	26.4ns	98.6ns	2.65	0.104	16.69 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	108μs	43.4ns	157ns	0.285	0	22.41 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	129μs	543ns	2.1μs	0.314	0	22.36 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	165μs	93.6ns	363ns	3.55	0.165	22.7 KB
master	`RunWaf(args=NestedMap (100))`	net6.0	109μs	37.8ns	141ns	0.423	0	32.76 KB
master	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	135μs	761ns	5.11μs	0.419	0	33.33 KB
master	`RunWaf(args=NestedMap (100))`	net472	186μs	127ns	493ns	5.29	0.371	33.67 KB
master	`RunWafTwice(args=NestedMap (100))`	net6.0	105μs	27.3ns	116ns	0.444	0	33.3 KB
master	`RunWafTwice(args=NestedMap (100))`	netcoreapp3.1	137μs	756ns	4.6μs	0.427	0	33.86 KB
master	`RunWafTwice(args=NestedMap (100))`	net472	198μs	735ns	2.85μs	5.43	0.388	34.23 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	168μs	120ns	463ns	0.503	0	39.1 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	196μs	911ns	3.53μs	0.481	0	39.63 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	260μs	114ns	428ns	6.38	0.51	40.23 KB
master	`RunWaf(args=NestedMap (20))`	net6.0	111μs	43.2ns	167ns	0.443	0	32.18 KB
master	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	130μs	453ns	1.75μs	0.386	0	32.3 KB
master	`RunWaf(args=NestedMap (20))`	net472	193μs	76.4ns	296ns	5.19	0.37	32.63 KB
master	`RunWafTwice(args=NestedMap (20))`	net6.0	109μs	120ns	433ns	0.433	0	32.72 KB
master	`RunWafTwice(args=NestedMap (20))`	netcoreapp3.1	138μs	489ns	1.89μs	0.421	0	32.82 KB
master	`RunWafTwice(args=NestedMap (20))`	net472	194μs	70.6ns	273ns	5.23	0.388	33.19 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	158μs	38.8ns	145ns	0.553	0	38.53 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	201μs	638ns	2.39μs	0.488	0	38.6 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	261μs	1.05μs	4.06μs	6.13	0.511	39.2 KB
#5096	`RunWaf(args=NestedMap (10))`	net6.0	50.8μs	17.8ns	69.1ns	0.22	0	16.06 KB
#5096	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	68.6μs	390ns	2.87μs	0.2	0	16.06 KB
#5096	`RunWaf(args=NestedMap (10))`	net472	96.1μs	69.3ns	268ns	2.53	0.0956	16.14 KB
#5096	`RunWafTwice(args=NestedMap (10))`	net6.0	58.8μs	196ns	733ns	0.221	0	16.6 KB
#5096	`RunWafTwice(args=NestedMap (10))`	netcoreapp3.1	74.7μs	410ns	2.53μs	0.226	0	16.58 KB
#5096	`RunWafTwice(args=NestedMap (10))`	net472	106μs	51.6ns	200ns	2.64	0.106	16.69 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	108μs	37.3ns	145ns	0.285	0	22.41 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	129μs	536ns	2μs	0.265	0	22.36 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	159μs	129ns	501ns	3.55	0.158	22.7 KB
#5096	`RunWaf(args=NestedMap (100))`	net6.0	106μs	35.6ns	133ns	0.48	0	32.76 KB
#5096	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	139μs	663ns	2.65μs	0.424	0	33.33 KB
#5096	`RunWaf(args=NestedMap (100))`	net472	187μs	97.9ns	379ns	5.31	0.373	33.67 KB
#5096	`RunWafTwice(args=NestedMap (100))`	net6.0	111μs	32.3ns	125ns	0.436	0	33.3 KB
#5096	`RunWafTwice(args=NestedMap (100))`	netcoreapp3.1	143μs	777ns	4.33μs	0.437	0	33.86 KB
#5096	`RunWafTwice(args=NestedMap (100))`	net472	195μs	118ns	440ns	5.43	0.388	34.23 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	166μs	921ns	5.6μs	0.551	0	39.1 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	202μs	1.06μs	5.17μs	0.485	0	39.63 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	252μs	152ns	567ns	6.28	0.502	40.23 KB
#5096	`RunWaf(args=NestedMap (20))`	net6.0	110μs	21.8ns	81.7ns	0.431	0	32.18 KB
#5096	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	135μs	762ns	5.23μs	0.408	0	32.3 KB
#5096	`RunWaf(args=NestedMap (20))`	net472	184μs	66.4ns	257ns	5.14	0.367	32.63 KB
#5096	`RunWafTwice(args=NestedMap (20))`	net6.0	112μs	40.3ns	156ns	0.443	0	32.72 KB
#5096	`RunWafTwice(args=NestedMap (20))`	netcoreapp3.1	137μs	652ns	2.69μs	0.411	0	32.82 KB
#5096	`RunWafTwice(args=NestedMap (20))`	net472	193μs	47.4ns	164ns	5.19	0.385	33.19 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	158μs	76.9ns	298ns	0.501	0	38.53 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	200μs	733ns	2.84μs	0.492	0	38.6 KB
#5096	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	254μs	104ns	404ns	6.2	0.506	39.2 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	139ns	536ns	0.172	18.25 KB
master	`SendRequest`	netcoreapp3.1	193μs	236ns	913ns	0.193	20.41 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#5096	`SendRequest`	net6.0	172μs	112ns	419ns	0.171	18.25 KB
#5096	`SendRequest`	netcoreapp3.1	193μs	252ns	941ns	0.193	20.41 KB
#5096	`SendRequest`	net472	0.00104ns	0.000325ns	0.00126ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5096

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.42 KB	41.81 KB	382 B	0.92%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	528μs	566ns	2.12μs	0.539	0	0	41.42 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	671μs	461ns	1.78μs	0.336	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	net472	840μs	2.99μs	11.6μs	8.22	2.47	0.411	53.21 KB
#5096	`WriteAndFlushEnrichedTraces`	net6.0	558μs	676ns	2.62μs	0.548	0	0	41.81 KB
#5096	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	1.11μs	4.3μs	0.331	0	0	41.78 KB
#5096	`WriteAndFlushEnrichedTraces`	net472	823μs	2.62μs	9.81μs	8.22	2.47	0.411	53.22 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.1μs	0.615ns	2.38ns	0.0105	768 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.53μs	0.721ns	2.79ns	0.0107	768 B
master	`ExecuteNonQuery`	net472	1.81μs	1.65ns	6.18ns	0.116	730 B
#5096	`ExecuteNonQuery`	net6.0	1.1μs	0.527ns	2.04ns	0.0109	768 B
#5096	`ExecuteNonQuery`	netcoreapp3.1	1.42μs	0.757ns	2.93ns	0.0106	768 B
#5096	`ExecuteNonQuery`	net472	1.75μs	4.15ns	16.1ns	0.115	730 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	0.904ns	3.38ns	0.0133	936 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.649ns	2.51ns	0.0129	936 B
master	`CallElasticsearch`	net472	2.54μs	0.765ns	2.96ns	0.151	955 B
master	`CallElasticsearchAsync`	net6.0	1.21μs	0.236ns	0.884ns	0.0126	912 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	1.97ns	7.63ns	0.0134	984 B
master	`CallElasticsearchAsync`	net472	2.68μs	3.03ns	11.3ns	0.16	1.01 KB
#5096	`CallElasticsearch`	net6.0	1.22μs	0.466ns	1.74ns	0.0134	936 B
#5096	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.435ns	1.68ns	0.0129	936 B
#5096	`CallElasticsearch`	net472	2.63μs	2.15ns	8.31ns	0.151	955 B
#5096	`CallElasticsearchAsync`	net6.0	1.32μs	0.474ns	1.84ns	0.0125	912 B
#5096	`CallElasticsearchAsync`	netcoreapp3.1	1.59μs	1.49ns	5.78ns	0.0136	984 B
#5096	`CallElasticsearchAsync`	net472	2.82μs	1.55ns	5.99ns	0.16	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5096

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.122	1,250.43	1,403.43

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.25μs	0.462ns	1.79ns	0.0125	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.968ns	3.62ns	0.0123	912 B
master	`ExecuteAsync`	net472	1.83μs	0.664ns	2.49ns	0.139	875 B
#5096	`ExecuteAsync`	net6.0	1.4μs	1.13ns	4.38ns	0.0126	912 B
#5096	`ExecuteAsync`	netcoreapp3.1	1.58μs	2.38ns	9.2ns	0.0119	912 B
#5096	`ExecuteAsync`	net472	1.81μs	0.39ns	1.41ns	0.139	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.01μs	1.94ns	6.99ns	0.028	2.1 KB
master	`SendAsync`	netcoreapp3.1	4.82μs	1.82ns	7.06ns	0.0338	2.63 KB
master	`SendAsync`	net472	7.71μs	3.53ns	13.7ns	0.524	3.31 KB
#5096	`SendAsync`	net6.0	4.14μs	1.83ns	7.07ns	0.029	2.1 KB
#5096	`SendAsync`	netcoreapp3.1	5.06μs	3.02ns	11.7ns	0.0328	2.63 KB
#5096	`SendAsync`	net472	7.84μs	2.51ns	9.06ns	0.525	3.31 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5096

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	204.17 KB	214.19 KB	10.02 KB	4.91%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	59.07 KB	61.7 KB	2.62 KB	4.44%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	201.17 KB	203.61 KB	2.44 KB	1.21%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	52.6μs	271ns	1.27μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	53.8μs	148ns	574ns	42.64 KB
master	`StringConcatBenchmark`	net472	38.3μs	172ns	619ns	59.07 KB
master	`StringConcatAspectBenchmark`	net6.0	272μs	7.55μs	71.6μs	204.17 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	268μs	2.03μs	18.7μs	201.17 KB
master	`StringConcatAspectBenchmark`	net472	242μs	3.28μs	31.3μs	221.18 KB
#5096	`StringConcatBenchmark`	net6.0	52.7μs	260ns	1.16μs	43.44 KB
#5096	`StringConcatBenchmark`	netcoreapp3.1	53.3μs	251ns	939ns	42.64 KB
#5096	`StringConcatBenchmark`	net472	37.4μs	77.6ns	291ns	61.7 KB
#5096	`StringConcatAspectBenchmark`	net6.0	299μs	5.07μs	47.8μs	214.19 KB
#5096	`StringConcatAspectBenchmark`	netcoreapp3.1	282μs	3.06μs	28μs	203.61 KB
#5096	`StringConcatAspectBenchmark`	net472	240μs	3.51μs	33.6μs	221.18 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.41μs	0.612ns	2.37ns	0.0219	1.57 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	0.926ns	3.46ns	0.021	1.57 KB
master	`EnrichedLog`	net472	2.73μs	1.76ns	6.82ns	0.237	1.5 KB
#5096	`EnrichedLog`	net6.0	1.4μs	0.468ns	1.69ns	0.0226	1.57 KB
#5096	`EnrichedLog`	netcoreapp3.1	2.21μs	1.17ns	4.36ns	0.0212	1.57 KB
#5096	`EnrichedLog`	net472	2.68μs	1.95ns	7.54ns	0.237	1.5 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	122ns	473ns	0.0577	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	133ns	514ns	0	0	4.21 KB
master	`EnrichedLog`	net472	150μs	168ns	650ns	0.672	0.224	4.39 KB
#5096	`EnrichedLog`	net6.0	112μs	114ns	442ns	0.0557	0	4.21 KB
#5096	`EnrichedLog`	netcoreapp3.1	117μs	115ns	447ns	0	0	4.21 KB
#5096	`EnrichedLog`	net472	148μs	80.1ns	310ns	0.664	0.221	4.39 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.96μs	0.936ns	3.63ns	0.0297	2.13 KB
master	`EnrichedLog`	netcoreapp3.1	4.24μs	2.27ns	8.51ns	0.0275	2.13 KB
master	`EnrichedLog`	net472	4.86μs	1.73ns	6.7ns	0.308	1.95 KB
#5096	`EnrichedLog`	net6.0	2.96μs	1.25ns	4.85ns	0.0297	2.13 KB
#5096	`EnrichedLog`	netcoreapp3.1	4.15μs	2.34ns	9.07ns	0.0271	2.13 KB
#5096	`EnrichedLog`	net472	4.79μs	2.41ns	9.33ns	0.308	1.95 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.37μs	0.67ns	2.6ns	0.0157	1.1 KB
master	`SendReceive`	netcoreapp3.1	1.67μs	1.71ns	6.64ns	0.0143	1.1 KB
master	`SendReceive`	net472	2.09μs	1.07ns	4ns	0.177	1.12 KB
#5096	`SendReceive`	net6.0	1.46μs	0.626ns	2.43ns	0.0153	1.1 KB
#5096	`SendReceive`	netcoreapp3.1	1.77μs	1.98ns	7.69ns	0.0142	1.1 KB
#5096	`SendReceive`	net472	2.24μs	1.39ns	5.2ns	0.177	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.73μs	1.07ns	3.99ns	0.0206	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.77μs	1.76ns	6.81ns	0.0207	1.58 KB
master	`EnrichedLog`	net472	4.46μs	2.18ns	8.45ns	0.311	1.97 KB
#5096	`EnrichedLog`	net6.0	2.74μs	0.748ns	2.8ns	0.0206	1.53 KB
#5096	`EnrichedLog`	netcoreapp3.1	3.81μs	2.36ns	9.14ns	0.0209	1.58 KB
#5096	`EnrichedLog`	net472	4.36μs	2.81ns	10.9ns	0.312	1.97 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	528ns	0.137ns	0.514ns	0.00741	536 B
master	`StartFinishSpan`	netcoreapp3.1	698ns	0.883ns	3.42ns	0.00699	536 B
master	`StartFinishSpan`	net472	728ns	0.312ns	1.21ns	0.0852	538 B
master	`StartFinishScope`	net6.0	563ns	0.167ns	0.625ns	0.00901	656 B
master	`StartFinishScope`	netcoreapp3.1	919ns	0.618ns	2.4ns	0.00901	656 B
master	`StartFinishScope`	net472	1.02μs	0.289ns	1.04ns	0.0979	618 B
#5096	`StartFinishSpan`	net6.0	555ns	0.176ns	0.682ns	0.00751	536 B
#5096	`StartFinishSpan`	netcoreapp3.1	717ns	0.73ns	2.83ns	0.00708	536 B
#5096	`StartFinishSpan`	net472	713ns	0.381ns	1.48ns	0.0852	538 B
#5096	`StartFinishScope`	net6.0	605ns	0.119ns	0.428ns	0.00907	656 B
#5096	`StartFinishScope`	netcoreapp3.1	854ns	0.475ns	1.84ns	0.00896	656 B
#5096	`StartFinishScope`	net472	1.05μs	0.521ns	2.02ns	0.0977	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	643ns	0.133ns	0.515ns	0.00905	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	940ns	0.317ns	1.23ns	0.00856	656 B
master	`RunOnMethodBegin`	net472	1.12μs	0.537ns	2.08ns	0.0979	618 B
#5096	`RunOnMethodBegin`	net6.0	682ns	0.19ns	0.736ns	0.00933	656 B
#5096	`RunOnMethodBegin`	netcoreapp3.1	986ns	2ns	7.23ns	0.00899	656 B
#5096	`RunOnMethodBegin`	net472	1.06μs	1.02ns	3.95ns	0.0981	618 B

Suppress build warnings we don't care about

69d8af9

Add <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> to test projects and

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 22, 2024

andrewlock requested a review from a team as a code owner January 22, 2024 11:57

github-actions bot added the area:tests unit tests, integration tests label Jan 22, 2024

zacharycmontoya approved these changes Jan 22, 2024

View reviewed changes

lucaspimentel approved these changes Jan 22, 2024

View reviewed changes

andrewlock merged commit 7594b9c into master Jan 23, 2024

andrewlock deleted the andrew/ci/suppress-warnings branch January 23, 2024 09:12

github-actions bot added this to the vNext milestone Jan 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Suppress build warnings we don't care about #5096

Suppress build warnings we don't care about #5096

Uh oh!

andrewlock commented Jan 22, 2024

Uh oh!

datadog-ddstaging bot commented Jan 22, 2024 •

edited

Loading

Uh oh!

andrewlock commented Jan 22, 2024

Uh oh!

andrewlock commented Jan 23, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #5096

Raw results

Raw results

Raw results

Slower ⚠️ in #5096

Raw results

Raw results

More allocations ⚠️ in #5096

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Uh oh!

Suppress build warnings we don't care about #5096

Suppress build warnings we don't care about #5096

Uh oh!

Conversation

andrewlock commented Jan 22, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-ddstaging bot commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock commented Jan 22, 2024

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock commented Jan 23, 2024

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #5096

Raw results

Raw results

Raw results

Slower ⚠️ in #5096

Raw results

Raw results

More allocations ⚠️ in #5096

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Uh oh!

datadog-ddstaging bot commented Jan 22, 2024 •

edited

Loading