Skip to content

Conversation

avangelillo
Copy link
Contributor

@avangelillo avangelillo commented Jul 10, 2025

What does this PR do?

Add the LLM observability env vars in line with their description.

Docs: https://docs.datadoghq.com/llm_observability/sdk/?tab=nodejs#command-line-setup

Motivation

Testing Guidelines

  1. Deployed the example stack to the sandbox account with no changes
  2. Implemented the change in datadog-lambda
  3. Saw no diff when I ran cdk diff
  4. Added the env vars to the datadog-lambda
  5. Reran cdk diff to see the following changes
Stack CdkTypeScriptStack-alexangelillo
Resources
[~] AWS::Lambda::Function hello-node hellonode2FDD99B8
 └─ [~] Environment
     └─ [~] .Variables:
         ├─ [+] Added: .DD_LLMOBS_AGENTLESS_ENABLED
         ├─ [+] Added: .DD_LLMOBS_ENABLED
         └─ [+] Added: .DD_LLMOBS_ML_APP
[~] AWS::Lambda::Function hello-python hellopython5270C3B7
 └─ [~] Environment
     └─ [~] .Variables:
         ├─ [+] Added: .DD_LLMOBS_AGENTLESS_ENABLED
         ├─ [+] Added: .DD_LLMOBS_ENABLED
         └─ [+] Added: .DD_LLMOBS_ML_APP
  1. Deployed and checked the env vars on the lambda
Screenshot 2025-07-10 at 9 17 41 AM

Additional Notes

The descriptions are copied directly from the other docs

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

Add the LLM observability env vars in line with their description.

Docs: https://docs.datadoghq.com/llm_observability/sdk/?tab=nodejs#command-line-setup
@avangelillo avangelillo changed the title Add LLM Observability env vars feat:Add LLM Observability env vars Jul 10, 2025
@avangelillo avangelillo changed the title feat:Add LLM Observability env vars feat: Add LLM Observability env vars Jul 10, 2025
@avangelillo avangelillo marked this pull request as ready for review July 10, 2025 14:42
@avangelillo avangelillo requested review from a team as code owners July 10, 2025 14:42
@avangelillo avangelillo requested a review from alexgallotta July 10, 2025 14:42
Copy link
Contributor

@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two points of feedback. Otherwise, lgtm!

avangelillo and others added 2 commits July 10, 2025 16:49
avangelillo and others added 2 commits July 14, 2025 09:02
@avangelillo avangelillo merged commit f0c12e0 into main Jul 14, 2025
9 checks passed
@avangelillo avangelillo deleted the alex.angelillo/addLLMObs branch July 14, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants