feat: ECS Fargate Profiling #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
May 23, 2025
| @@ -184,6 +184,7 @@ For more general information, reference the [Datadog ECS Fargate Docs](https://d | |||
| | `isEnabled` | `boolean` | Enables APM. | | |||
| | `isSocketEnabled` | `boolean` | Enables APM traces traffic over Unix Domain Socket. Falls back to TCP when false. | | |||
| | `traceInferredProxyServices` | `boolean` | Enables inferred spans for proxy services like AWS API Gateway. When enabled, the tracer will create spans for proxy services by using headers passed from the proxy service to the application. | | |||
| | `isProfilingEnabled` | `boolean` | Enables Profiling. (Requires APM SSI on application containers) | | |||
There was a problem hiding this comment.
Should this say APM instead of APM SSI?
I guess this works if the image contains the APM libraries even if they were not installed with APM SSI.
There was a problem hiding this comment.
From my understanding, on application containers that are simply configured with APM libraries natively do NOT support profiling by simply setting the envvar. Instead the user must manually setup the profiler.
For APM SSI, I think the way the tracers are loaded are different and they have a step for activating the profiler based on the DD_PROFILING_ENABLED envvar as mentioned here.
Additionally APM SSI will soon be supported in CDK so this is meant to reference that.
gabedos
force-pushed
the
gabedos/ecs-fargate-profiling
branch
from
3f22432 to
2e9097b
Compare
zhuminyi
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposes option to configure profiling for applications on ECS Fargate.
Motivation
Parity with onboarding CLI/CFN pages.
Testing Guidelines
Unit tests
Additional Notes
Depends on having APM SSI on the application container. That feature is coming soon via the CDK.
Types of Changes
Check all that apply