Skip to content

Conversation

gabedos
Copy link
Collaborator

@gabedos gabedos commented May 22, 2025

What does this PR do?

Wraps all of the ECS exports into 1 index within the src/ecs submodules. Then exports those into the package level src/index.ts.

This avoid needing to get reviews from src/index.ts file owners.

Testing Guidelines

yarn build and ensuring all samples still worked.

Note that yarn build fails if any of the needed sub-interfaces are not directly exported. We know we are exporting everything needed for the DatadogECSFargateTaskDefinition construct because the build suceeds.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@gabedos gabedos requested review from a team as code owners May 22, 2025 16:12
@gabedos gabedos requested a review from lym953 May 22, 2025 16:12
@gabedos gabedos force-pushed the gabedos/simplify-ecs-exports branch from c96578f to 4063f42 Compare May 22, 2025 16:17
Base automatically changed from gabedos/log-config-options to main May 22, 2025 21:58
@DataDog DataDog deleted a comment from datadog-datadog-prod-us1 bot May 22, 2025
@gabedos gabedos force-pushed the gabedos/simplify-ecs-exports branch from 8614234 to bba4df0 Compare May 22, 2025 22:24
Copy link
Contributor

@lym953 lym953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.ts LGTM

@gabedos gabedos merged commit 328254a into main May 23, 2025
8 checks passed
@gabedos gabedos deleted the gabedos/simplify-ecs-exports branch May 23, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants