chore: Refactor fargate fluentbit log config #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabedos
force-pushed
the
gabedos/log-router-props
branch
from
f7fb7e5 to
c9cabbd
Compare
gabedos
changed the title
gabedos
force-pushed
the
gabedos/log-router-props
branch
from
c9cabbd to
5559518
Compare
lym953
approved these changes
Apr 8, 2025
zhuminyi
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the fargate fluentbit log configuration.
Motivation
Creates a class specific for the fluentbit log configuration properties. This will make it easier if different logging methods are supported in the future (such as the aws lambda log forwarder).
Moves the location of the property to define the fluentbit container image/version to be closer to other related fluentbit container properties like cpu, memory, essential, dependencies, etc.
Testing Guidelines
N/A
Additional Notes
N/A
Types of Changes
Check all that apply