Add new APT and RPM signing keys #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
added
hold/no-merge
dependencies
chouetz
changed the title
chouetz
force-pushed
the
nschweitzer/signing
branch
from
d907526 to
ffff3b7
Compare
KevinFairise2
approved these changes
Jun 14, 2023
Member
KevinFairise2
left a comment
KevinFairise2
left a comment
There was a problem hiding this comment.
Just leave a small question, otherwise looks good to me!
|
|
||
| expect(chef_run.remote_file('remote_file_DATADOG_APT_KEY_CURRENT.public')).to notify( | ||
| 'execute[import apt datadog key DATADOG_APT_KEY_CURRENT.public]').to(:run).immediately | ||
| expect(chef_run.remote_file('remote_file_5F1E256061D813B125E156E8E6266D4AC0962C7D')).to notify( |
Member
There was a problem hiding this comment.
Just out of curiosity, shouldn't the new key become the current key ? Or we must wait before switching ?
There was a problem hiding this comment.
It will become the current key when we actually start using it (we're not using it yet).
bkabrda
reviewed
Jun 20, 2023
bkabrda
reviewed
Jun 20, 2023
bkabrda
approved these changes
Jun 21, 2023
chouetz
force-pushed
the
nschweitzer/signing
branch
from
a7a12be to
2086953
Compare
chouetz
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addition of the new key for signing rotation process
Motivation
Regular signing key rotation process
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Install the agent packages pushed on trial repository
Reviewer's Checklist