Ensure to check all pages of comments #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There's some docs here: https://buildsize.org/docs/development. Admittedly I haven't touched this project in a while either, but the docs should still be useful. |
Owner
|
If you'd like, I can try this out myself, if you don't get to it.
Sent from my phone.
…On Sat, Mar 16, 2019, 1:40 AM Daniel Tschinder ***@***.***> wrote:
Currently only the first page is checked. This PR in theory should check
all pages.
I noticed this in this PR (babel/babel#7646
<babel/babel#7646>), where BuildSize was
commenting over and over.
Please bear with me, because I haven't touched PHP in over a year so there
might be mistakes.
I was also not able to test, because I don't know how. I couldn't see
tests for this and I do not know how to run it locally.
Please let me know how I can continue.
------------------------------
You can view, comment on, or merge this pull request online at:
#44
Commit Summary
- Ensure to check all pages of comments
File Changes
- *M* app/Listeners/GitHubCommentListener.php
<https://github.com/Daniel15/BuildSize/pull/44/files#diff-0> (26)
Patch Links:
- https://github.com/Daniel15/BuildSize/pull/44.patch
- https://github.com/Daniel15/BuildSize/pull/44.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#44>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHbCtTYXN2QuO7R9lM8CC0ntFD5siks5vXK30gaJpZM4b3sJE>
.
|
Author
|
If you already have a development environment, app and repo setup, it would be nice if you could try. Otherwise I can spend some time next week to set everything up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the first page is checked. This PR in theory should check all pages.
I noticed this in this PR (babel/babel#7646), where BuildSize was commenting over and over.
Please bear with me, because I haven't touched PHP in over a year so there might be mistakes.
I was also not able to test, because I don't know how. I couldn't see tests for this and I do not know how to run it locally.
Please let me know how I can continue.