Fix 'sync-i18n' script source file access #4841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoMolinaro
changed the title
tdonohue
added
high priority
code task
1 APPROVAL
tdonohue
changed the title
tdonohue
approved these changes
Nov 21, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @FrancescoMolinaro ! I was able to verify that the sync-i18n script is currently broken and this PR fixes it. The code looks good to me too. I also verified this script is broken on all active branches, so this will be backported to 7.x, 8.x and 9.x as well.
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 10.0 Release
tdonohue
added
port to dspace-7_x
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 10.0 Release
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #4842
Description
Fixed access to source file in sync-i18n script
Instructions for Reviewers
adapt a label on en.json5 and run command:
npm run sync-i18n
List of changes in this PR:
Fixed sync-i18n script
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.