Update lru-cache #4834
Open
Update lru-cache #4834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ng update @angular/core@19 @angular/cli@19
ng update @angular/cdk@19 ng update @angular-eslint/schematics@19 ng update @ngtools/webpack@19 ng update @angular-builders/custom-webpack ng update @ngrx/store@19 ng update [email protected] ng update ngx-infinite-scroll@19 ng update ngx-matomo-client@7 ng update ngx-skeleton-loader ng update ngx-ui-switch ng update ng-mocks Also bumped @ng-bootstrap/ng-bootstrap to 12.1.2 since this version was already being used in the lock file
In the future this should be cleaned up by assigning a type to the item property in ChipsItem. But currently this prevents angular from building
- Cast the store.dispatch method in expect calls, because ngrx now has multiple methods with the same name and jest can't deal with it - Removed the APP_INITIALIZER tests since it can't be tested like that anymore with the new provider format
ng update @angular/core@20 @angular/cli@20
ng update @angular/cdk@20 ng update @angular-eslint/schematics@20 ng update @ngtools/webpack@20 ng update @angular-builders/custom-webpack@20 ng update @ngrx/store@20 ng update ng2-file-upload@9 ng update ngx-infinite-scroll@20 ng update ngx-matomo-client@8 ng update altcha ng update @types/node@20 ng update [email protected]
- Fixed dependencies who moved between packages - Special mention for the PlacementArray from @ng-bootstrap/ng-bootstrap which is not exposed by default so had to replace it with Placement[] - Fixed failing tests - Updated CI's node version to 20 & 22
ng generate @angular/core:cleanup-unused-imports Also fixed template urls of CreateCollectionParentSelectorComponent, EditCollectionSelectorComponent & EditCommunitySelectorComponent in the custom theme not pointing to the correct file Some tests did require those imports even if they were not used in the template. To prevent them from being automatically removed, I used them in the templates
alanorth
force-pushed
the
update-lru-cache
branch
from
b869d24 to
3a3c8be
Compare
tdonohue
added
code task
1 APPROVAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Use latest version of lru-cache.
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
lru-cacheto latest versionInclude guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Make sure the application installs, builds and runs in production mode with
cache.serverSide.debug: true. Check the log after making requests in the browser and via curl to see that the bot cache is working.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.