Sync Art and Buildings against Toady headers #763
Conversation
|
The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.
This is an automated comment. Please leave a reply if you think that the above information is incorrect. |
|
|
||
| <!-- <compound name='track_stop_info' comment='track_stop_profilest'> --> | ||
| <int32_t name='friction' init-value='50000' since='v0.34.08'/> | ||
| <int32_t name='use_dump' since='v0.34.08'/> |
There was a problem hiding this comment.
Note: breaks "blueprint" plugin
| <vmethod ret-type='bool' name='needsMagma'/> | ||
| <vmethod name='removeUses'> <bool name='noscatter'/> <bool name='lost'/> </vmethod> | ||
| <vmethod name='deconstructItems'> <bool name='noscatter'/> <bool name='lost'/> </vmethod> | ||
| <vmethod name='deconstructItems'> <bool name='noscatter'/> <bool name='lost'/> <bool name='from_damage'/> </vmethod> |
There was a problem hiding this comment.
could this be why we have crashed in the past while trying to forcibly deconstruct buildings? This was a key issue when I was trying to write quickfort regression tests since I couldn't test constructed buildings (since I couldn't clean those kinds of tests up afterwards)
There was a problem hiding this comment.
I suppose it's possible, though I don't recall whether any of our currently supported platforms still pass parameters on the stack and expect callee-cleanup (which is the only case where I'd expect something like this to cause a crash).
There was a problem hiding this comment.
would have caused stack alignment issues on msvc (windows) but not on gcc (linux) due to differences in the calling conventions: msvc passes the first four arguments in registers, while gcc passes the first six
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
I'll see if I can update the affected tools
|
|
||
| <int32_t name='use_links_only'/> | ||
| <bitfield name='stockpile_flag' base-type='uint32_t'> bay12: BUILDINGFLAG_STOCKPILE_FLAG_* | ||
| <flag-bit name='use_links_only'/> |
There was a problem hiding this comment.
will require updates to stockpiles and quickfort
|
|
||
| <struct-type type-name='hospital_supplies'> | ||
| <bitfield name='supplies_needed' base-type='uint32_t'> | ||
| <struct-type type-name='hospital_supplies' original-name='location_infost'> |
There was a problem hiding this comment.
no, no updates needed for this one
| </bitfield> | ||
| <compound name='pen'> | ||
| <int32_t name='unk' init-value='1'/> | ||
| <compound name='gather'> |
There was a problem hiding this comment.
quickfort will need updates here
3 participants
And fix a few minor errors in the process