Skip to content

Update TargetFrameworks (net6.0;net8.0 -> net8.0;net9.0) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Update TargetFrameworks (net6.0;net8.0 -> net8.0;net9.0) #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5008d97
Update TargetFrameworks (net6.0,net8.0 -> net8.0,net9.0)
mayuki Dec 27, 2024
0741da5
Fix warnings
mayuki Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/Multicaster.Distributed.Nats/KeyArrayFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ internal static class KeyArrayFormatter<TKey>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Serialize(ref MessagePackWriter writer, ReadOnlySpan<TKey> values)
{
if (values == null)
{
writer.WriteNil();
return;
}

writer.WriteArrayHeader(values.Length);
foreach (var value in values)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Multicaster.Distributed.Nats/Multicaster.Distributed.Nats.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand Down
6 changes: 0 additions & 6 deletions src/Multicaster.Distributed.Redis/KeyArrayFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ internal static class KeyArrayFormatter<TKey>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Serialize(ref MessagePackWriter writer, ReadOnlySpan<TKey> values)
{
if (values == null)
{
writer.WriteNil();
return;
}

writer.WriteArrayHeader(values.Length);
foreach (var value in values)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Multicaster.Distributed.Redis/Multicaster.Distributed.Redis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand Down
10 changes: 3 additions & 7 deletions src/Multicaster/Internal/FNV1A32.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,10 @@ public static int GetHashCode(string str)

public static int GetHashCode(ReadOnlySpan<byte> obj)
{
uint hash = 0;
if (obj != null)
uint hash = 2166136261;
for (int i = 0; i < obj.Length; i++)
{
hash = 2166136261;
for (int i = 0; i < obj.Length; i++)
{
hash = unchecked((obj[i] ^ hash) * 16777619);
}
hash = unchecked((obj[i] ^ hash) * 16777619);
}

return unchecked((int)hash);
Expand Down
7 changes: 1 addition & 6 deletions src/Multicaster/Multicaster.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand All @@ -10,11 +10,6 @@
<RootNamespace>Cysharp.Runtime.Multicast</RootNamespace>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
<PackageReference Include="Microsoft.Bcl.TimeProvider" Version="8.0.0" />
</ItemGroup>

<ItemGroup>
<None Update="Remoting\RemoteProxyBase.Invoke.tt">
<Generator>TextTemplatingFileGenerator</Generator>
Expand Down
2 changes: 1 addition & 1 deletion test/Multicaster.Tests/RemoteClientResultPendingTaskRegistryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void CancelImmediately_On_Register_When_Disposed()
}

[Fact]
public async Task Timeout()
public void Timeout()
{
// Arrange
var timeProvider = new FakeTimeProvider();
Expand Down
Loading