Skip to content

chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3302a2e
chore: Specify IsPackable=false on Directory.Build.props, explicitly …
guitarrapc Sep 24, 2025
46f4237
Simplify dotnet pack command in CI workflow
guitarrapc Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: Cysharp/Actions/.github/actions/setup-dotnet@main
- run: dotnet tool restore
- run: dotnet build -c Release -p:DefineConstants=RUNNING_IN_CI
- run: dotnet pack ./src/Multicaster/Multicaster.csproj -c Release --no-build -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
- run: dotnet pack -c Release --no-build -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
- run: dotnet retest -- -c Release --no-build
- uses: Cysharp/Actions/.github/actions/upload-artifact@main
with:
Expand Down
14 changes: 6 additions & 8 deletions src/Directory.Build.props → Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,14 @@
<LangVersion>12</LangVersion>

<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\Multicaster\opensource.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\opensource.snk</AssemblyOriginatorKeyFile>

<!-- Prevent local path leakage by artifacts -->
<PropertyGroup>
<!-- Prevent local path leakage by artifacts -->
<RepoRoot>$(MSBuildThisFileDirectory)</RepoRoot>
<PathMap>$(RepoRoot)=.</PathMap>
</PropertyGroup>

<PropertyGroup>
<!-- NuGet Package Information -->
<IsPackable>false</IsPackable>
<VersionPrefix>0.1.0</VersionPrefix>
<Company>Cysharp</Company>
<Authors>Cysharp</Authors>
Expand All @@ -35,8 +32,9 @@
</PropertyGroup>

<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)\..\README.md" Pack="true" PackagePath="/" />
<None Include="$(MSBuildThisFileDirectory)\Multicaster\Icon.png" Pack="true" PackagePath="/" />
<None Include="$(MSBuildThisFileDirectory)Icon.png" Pack="true" PackagePath="\" />
<None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
<EmbeddedResource Include="$(MSBuildThisFileDirectory)LICENSE" />
</ItemGroup>

<!--
Expand Down
0 src/Multicaster/Icon.png → Icon.png
View file
Open in desktop
File renamed without changes
0 src/Multicaster/opensource.snk → opensource.snk
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion perf/MicroBenchmark/MicroBenchmark.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/Multicaster.Distributed.Nats/Multicaster.Distributed.Nats.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Nullable>enable</Nullable>

<!-- NuGet -->
<IsPackable>true</IsPackable>
<PackageId>Multicaster.Distributed.Nats</PackageId>
<Description>An extension package that adds NATS backend support for Multicaster.</Description>

Expand All @@ -22,4 +23,4 @@
<ItemGroup>
<ProjectReference Include="..\Multicaster\Multicaster.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion src/Multicaster.Distributed.Redis/Multicaster.Distributed.Redis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Nullable>enable</Nullable>

<!-- NuGet-->
<IsPackable>true</IsPackable>
<PackageId>Multicaster.Distributed.Redis</PackageId>
<Description>An extension package that adds Redis backend support for Multicaster.</Description>

Expand All @@ -22,4 +23,4 @@
<ItemGroup>
<ProjectReference Include="..\Multicaster\Multicaster.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions src/Multicaster/Multicaster.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<Nullable>enable</Nullable>

<!-- NuGet -->
<IsPackable>true</IsPackable>
<PackageId>Multicaster</PackageId>
<Description>Provides a proxy for transparently invoking methods of multiple POCO instances or remote clients through an interface.</Description>

Expand Down
3 changes: 1 addition & 2 deletions test/Multicaster.Distributed.Nats.Tests/Multicaster.Distributed.Nats.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
</PropertyGroup>
<ItemGroup>
Expand All @@ -25,4 +24,4 @@
<ItemGroup>
<Using Include="Xunit" />
</ItemGroup>
</Project>
</Project>
3 changes: 1 addition & 2 deletions test/Multicaster.Distributed.Redis.Tests/Multicaster.Distributed.Redis.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
</PropertyGroup>
<ItemGroup>
Expand All @@ -25,4 +24,4 @@
<ItemGroup>
<Using Include="Xunit" />
</ItemGroup>
</Project>
</Project>
3 changes: 1 addition & 2 deletions test/Multicaster.Tests/Multicaster.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
</PropertyGroup>
<ItemGroup>
Expand All @@ -22,4 +21,4 @@
<ItemGroup>
<Using Include="Xunit" />
</ItemGroup>
</Project>
</Project>
Loading