Outcomerequirements #3329

BastLast · 2025-05-25T23:30:24Z

No description provided.

leuhvraiminoryo · 2025-05-28T15:08:36Z

Lang/fr/events.json

Sur l'évent 1

chopTree 3 : vous finissez par abandonner et vous reposez -> vous finissez par abandonner et vous reposer OU vous finissez par abandonner et vous vous reposez (je suis plus partiel au deuxième perso)

findPath 1 : répétition sémantique avec le "racines de l'arbre déraciné", je propose un qualificatif différent, pour un truc style "racines de l'arbre effondré", d'autant plus que "déraciné" a déjà été utilisé dans le texte d'intro de l'évent

texte d'intro de l'évent : sur le sentier sinueux -> sur un sentier sinueux
et aussi :
L'arbre ancestral, dont le tronc fait bien deux mètres de diamètre et barre complètement le passage.
Pourquoi cette phrase n'a aucun verbe dans sa première proposition ? Si on enlève le "dont le tronc fait bien [bla bla]", la phrase c'est "L'arbre ancestral", et ça n'a aucun sens. Peut-être l'intention ici est-elle plutôt de dire que c'est l'arbre ancestral qui barre la passage, auquel cas il faudrait remplacer le "et" par une virgule pour que ce qui barre soit effectivement l'arbre ancestral et non pas "le tronc".

romain22222 · 2025-06-04T06:15:50Z

Core/__tests__/core/eventsRequirements.test.ts

+}
+
+function getAllLevelBoundaries(outcomes: Record<string, Outcome>): number[] {
+	const boundaries = new Set<number>([0, 1]); // Always include level 0 and 1


Explique pourquoi ces valeurs là pour les tests, car je vois vraiment pas à quoi ca correspond exactement (same comment pour les autres Set en dessous)

romain22222 · 2025-06-04T06:17:03Z

Core/__tests__/core/eventsRequirements.test.ts

+}
+
+function getAllClasses(outcomes: Record<string, Outcome>): number[] {
+	const classes = new Set<number>([1, 2, 3, 4, 5]); // Assume common class IDs


test bugprone : Si une classe n'est pas incluse ici, elle pourrait être ignorée par les tests

je croyais qu'on lisais pas les constantes dans les tests

ok mon commentaire est stupide, je fixerai

romain22222 · 2025-06-04T06:21:49Z

Core/src/data/events/PossibilityOutcome.ts

 export interface PossibilityOutcome {

+	requirements?: {
+		level: {


romain22222 · 2025-06-04T06:22:08Z

Core/src/data/events/PossibilityOutcome.ts


 export interface PossibilityOutcome {

+	requirements?: {


requirements est pas présent dans tous les events ?

il va falloire que je le rajoute, cette pr est pas finie mdr

romain22222 · 2025-06-04T06:24:58Z

Core/__tests__/core/eventsRequirements.test.ts

+function isRangeValid(
+	range: { min?: number; max?: number } | undefined,
+	value: number
+): boolean {
+	if (!range) return true;
+	if (range.min !== undefined && value < range.min) return false;
+	if (range.max !== undefined && value > range.max) return false;
+	return true;
+}
+
+function isOutcomeValidForStats(
+	requirements: OutcomeRequirements | undefined,
+	stats: {
+		level: number;
+		health: number;
+		defense: number;
+		attack: number;
+		speed: number;
+		class: number;
+	}
+): boolean {
+	if (!requirements) return true;
+
+	return (
+		isRangeValid(requirements.level, stats.level) &&
+		isRangeValid(requirements.health, stats.health) &&
+		isRangeValid(requirements.defense, stats.defense) &&
+		isRangeValid(requirements.attack, stats.attack) &&
+		isRangeValid(requirements.speed, stats.speed) &&
+		(requirements.validClassIds === undefined || requirements.validClassIds.includes(stats.class))
+	);
+}


ces deux fonctions sont des copy paste de la vraie fonction, faut faire des valeurs en dur pour les tests

Co-authored-by: Ravenclaw <[email protected]>

Co-authored-by: Gabriel <[email protected]> Co-authored-by: Ravenclaw <[email protected]>

codescene-delta-analysis

Gates Failed
Prevent hotspot decline (1 hotspot with Large Method)
Enforce advisory code health rules (2 files with Complex Method, Large Method)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
Player.ts	1 rule in this hotspot	6.34 → 6.33	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
PossibilityOutcome.ts	1 advisory rule	8.55 → 8.50	Suppress
Player.ts	1 advisory rule	6.34 → 6.33	Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

romain22222 · 2025-12-03T07:53:31Z

pourquoi je sens que cette pr va être un enfer à merge ?

BastLast · 2025-12-03T08:38:10Z

pourquoi je sens que cette pr va être un enfer à merge ?

Nan tkt. CA ira

BastLast added this to the 5.0.3 milestone May 25, 2025

BastLast linked an issue May 25, 2025 that may be closed by this pull request

Add outcome requirements #3327

Open

82 tasks

BastLast added enhancement New feature or request event / mini event New event or fixes on an event file test Checking that something works as intended labels May 25, 2025

BastLast force-pushed the outcomerequirements branch 2 times, most recently from b6d4dc8 to 83a1326 Compare May 26, 2025 22:32

BastLast marked this pull request as ready for review May 26, 2025 22:33

BastLast modified the milestones: 5.0.3, 5.1.0 May 27, 2025

leuhvraiminoryo reviewed May 28, 2025

View reviewed changes

BastLast modified the milestones: 5.1.0, 5.2.0 Jun 1, 2025

romain22222 requested changes Jun 4, 2025

View reviewed changes

BastLast force-pushed the outcomerequirements branch from b86790c to 82cdda4 Compare June 7, 2025 21:45

BastLast force-pushed the develop branch from 958fcc5 to a4afa3a Compare June 25, 2025 18:27

BastLast force-pushed the outcomerequirements branch from b0aa659 to 73c1181 Compare July 23, 2025 21:02

This comment was marked as outdated.

Sign in to view

BastLast force-pushed the outcomerequirements branch from 73c1181 to f4503f4 Compare July 29, 2025 23:07

This comment was marked as outdated.

Sign in to view

BastLast force-pushed the outcomerequirements branch from 113aacc to 93206b1 Compare July 31, 2025 23:31

This comment was marked as outdated.

Sign in to view

BastLast and others added 25 commits October 26, 2025 22:34

v1 event 19 #3327

6aecc90

fix event 18 #3327

d6592f1

event 19 v2 #3327

1fabcfa

add test for translation to follow rules

7f8bcf6

english comments test

8e7981b

fix: standardize apostrophe usage in French translations

8b0f973

event 19 v3 #3327

9093d0e

Co-authored-by: Ravenclaw <[email protected]>

fix bug event 18 #3327

771a760

event 19 v4 #3327

0ab63fd

Co-authored-by: Gabriel <[email protected]> Co-authored-by: Ravenclaw <[email protected]>

fix capitalization issue with an item

640431d

event 19 v finale #3327

60ce492

Co-authored-by: Gabriel <[email protected]> Co-authored-by: Ravenclaw <[email protected]>

event 2 v1 #3327

84328c0

Event 2 v2 #3327

89725df

event 2 v2 #3327

1683707

event 2 v3 #3327

f54c459

rework event 2 et 1

74585a3

fix #3520

d2f7146

more work on event 2 #3327

0e7dbab

very little work on event 2 #3327

bdbfd30

scare dog event 2 finished #3327

83c9f6e

scare dog event 2 finished #3327

c746a0e

ct pas finished #3327

d15dff7

formatting files

3bdabab

rework event 20 v1 #3327

e5d64f5

refine negotiateBribe outcomes and narrative text for clarity #3327

61436d3

BastLast force-pushed the outcomerequirements branch from 03c1732 to 61436d3 Compare October 26, 2025 21:34

codescene-delta-analysis bot reviewed Oct 26, 2025

View reviewed changes

BastLast force-pushed the develop branch from 6b28bf1 to 5cd9c1a Compare December 11, 2025 19:18

Uh oh!

Outcomerequirements #3329

Are you sure you want to change the base?

Outcomerequirements #3329

Conversation

BastLast commented May 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

romain22222 commented Dec 3, 2025

Uh oh!

BastLast commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants