Total price calculation is wrong

[htulibacki]

It is not a good idea to round price with tax after summing it, becouse this could give you a wrong result. For example:

Product price	Tax	Product Price With Tax	Qty	Product Total
48.7	23%	59.901	3	179.703
40,57	23%	49.9011	5	249.5055
44.63	23%	54.8949	1	54.8949
-	-	-	-	484.1034

When you round the total price to two digits, it will give you 484.10, and that is ok.

But in your store you want to present clients prices rounded to two digits, and the above table will look like this:

Product price	Tax	Product Price With Tax	Qty	Product Total
48.7	23%	59.90	3	179.7
40,57	23%	49.90	5	249.5
44.63	23%	54.89	1	54.89
-	-	-	-	484.09

As you can see, the total price differs by 0.01, and there is no way to get the correct result.

Nevertheless, thank you for all your hard work, and i hope you will find a way to correct this soon :)

[johannesschobel]

I don't think this is a problem at all.
Considering the example above: The Product price with tax column - there is no way a customer could pay 49.9011 USD (or whatever currency you are using), because there are no smaller unit than cents. Therefore, rounding to 2 decimal points is applicable, I think..

The example below should be correct, right?

[olimortimer]

I believe this issue still exists.

If you have a product that's £291.67 exc 20% VAT / £350 inc VAT, this is what is displayed by the cart:

$item->price = 291.67
$item->subtotal = 291.67
$item->tax = 58.334
$item->total = 350.004

Cart::subtotal() = 291.67
Cart::tax() = 58.33
Cart::total() = 350.00

Increase the quantity to 2 in your basket, and you get:

$item->price = 291.67
$item->subtotal = 583.34
$item->tax = 116.668
$item->total = 700.008

Cart::subtotal() = 583.34
Cart::tax() = 116.67
Cart::total() = 700.01

I believe __get($attribute) in CartItem.php should be formatting the numbers using the included $this->numberFormat. This changes then outputs the values correctly:

$item->price = 291.67
$item->subtotal = 291.67
$item->tax = 58.33
$item->total = 350.00

Cart::subtotal() = 291.67
Cart::tax() = 58.33
Cart::total() = 350.00

Increase the quantity to 2 in your basket, and you now get:

$item->price = 291.67
$item->subtotal = 583.34
$item->tax = 116.66
$item->total = 700.00

Cart::subtotal() = 583.34
Cart::tax() = 116.66
Cart::total() = 700.00

[patrick-hertling]

Im having the same problem here. Do we know when this is getting merged?
Thank you very much.

[olimortimer]

This really needs to be merged...