Skip to content

"Modernize" codebase #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 28, 2020
Merged

"Modernize" codebase #259

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8642447
flag all methods that return nothing
Baptouuuu Sep 19, 2020
984d180
symfony commands expect to return the exit code
Baptouuuu Sep 19, 2020
164a294
add php types wherever possible
Baptouuuu Sep 19, 2020
1baa233
add psalm
Baptouuuu Sep 19, 2020
55eb1d8
run psalm in the CI
Baptouuuu Sep 19, 2020
b329976
use ::class pseudo constant instead of strings to references FQCNs
Baptouuuu Sep 19, 2020
6250984
add missing type declaration
Baptouuuu Sep 19, 2020
e17d9aa
remove redundant docblocks
Baptouuuu Sep 19, 2020
249156a
fix minimum required php version to run the webserver
Baptouuuu Sep 19, 2020
5bebd41
fix child class type declaration
Baptouuuu Sep 19, 2020
99284c0
use non namespaced twig environment to better reflect project require…
Baptouuuu Sep 26, 2020
6f5ccfd
remove no longer useful code check
Baptouuuu Sep 26, 2020
95d7137
use strict types
Baptouuuu Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Application/Cli/PreviewCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$cliConfig = $input->getOption('config');

if (!$this->isSupported()) {
$output->writeln('<error>PHP 5.4 or above is required to run the internal webserver</error>');
$output->writeln('<error>PHP 7.1 or above is required to run the internal webserver</error>');

return 1;
}
Expand Down Expand Up @@ -225,7 +225,7 @@ private function startLivereload(

private function isSupported(): bool
{
if (version_compare(phpversion(), '5.4.0', '<')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isSupported() is for checking that PHP >= 5.4 because that's the version they added the built-in webserver.

We could completely remove that check now instead of upgrading the error message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

if (version_compare(phpversion(), '7.1.0', '<')) {
return false;
}

Expand Down