Propagate kill signal to the child server process #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Couscous through Composer with scripts for example, Couscous might get killed once a given timeout is reached: the child server process might not be killed properly in this case. PHP lets us catch kill signals (using `pcntl_signal`). Using this function we can make Couscous propagate the signal it receives to its child process: the server will then be killed by Couscous before it dies and everything will be ok.
|
That's awesome! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Couscous through Composer with scripts for example, Couscous might
get killed once a given timeout is reached: the child server process might not
be killed properly in this case.
PHP lets us catch kill signals (using
pcntl_signal). Using this function we canmake Couscous propagate the signal it receives to its child process: the
server will then be killed by Couscous before it dies and everything will be ok.