feature/vue #1573
Merged
feature/vue #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOM-level component ids, new skins for tabs and checks, minor improvements
Style refactorings, SCSS, more regular names, theme support
[vue] Button style fixes
[vue] Button menu component, improvements, bug fixes
[vue] Merge next
[vue] Added vue-dropzone
[vue][cly-button-menu] New skin
|
Issues
======
+ Solved 1
- Added 4
Complexity increasing per file
==============================
- plugins/vue-example/frontend/public/javascripts/countly.models.js 2
- plugins/vue-example/api/api.js 4
- plugins/vue-example/frontend/app.js 1
- plugins/vue-example/frontend/public/javascripts/countly.views.js 5
- frontend/express/public/javascripts/countly/countly.vue.components.js 7
See the complete overview on Codacy |
ar2rsawseen
reviewed
Oct 15, 2020
| files.forEach(function(name) { | ||
| var file = path.join(stylesheets, name); | ||
| if (fs.statSync(file).isFile() && name !== 'pre-login.css' && name.indexOf('.') !== 0) { | ||
| if (fs.statSync(file).isFile() && name !== 'pre-login.css' && name.indexOf('.') !== 0 && name.indexOf('.scss') === -1) { |
There was a problem hiding this comment.
Codacy found an issue: Found fs.statSync with non literal argument at index 0
ar2rsawseen
reviewed
Oct 15, 2020
| @@ -0,0 +1,240 @@ | |||
| /*global $, countlyCommon, _, countlyVue */ | |||
There was a problem hiding this comment.
Codacy found an issue: '$' is already defined as a built-in global variable.
ar2rsawseen
reviewed
Oct 15, 2020
| @@ -0,0 +1,240 @@ | |||
| /*global $, countlyCommon, _, countlyVue */ | |||
|
|
|||
| (function(countlyVueExample) { | |||
There was a problem hiding this comment.
Codacy found an issue: Move the invocation into the parens that contain the function.
ar2rsawseen
reviewed
Oct 15, 2020
| methods: { | ||
| back: function() { | ||
| if (this.link) { |
There was a problem hiding this comment.
Codacy found an issue: Found fs.link with non literal argument at index 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.