-
Notifications
You must be signed in to change notification settings - Fork 11
[NOCSL] Adds extra url validation for android referrers #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code Review Results✅ StrengthsWell-tested implementation with comprehensive edge case coverage for Android app referrer transformation. 🚨 Critical IssuesNone
|
Code Review Results✅ StrengthsGood test coverage for the new functionality including edge cases like empty strings, null values, and URL trimming logic. 🚨 Critical Issues[File:
let processedUrl = url;
if (processedUrl?.startsWith('android-app')) {
processedUrl = processedUrl.replace('android-app', 'https');
}
const urlObj = new URL(processedUrl, baseUrl);[File:
trimUrl: (urlObj, maxLen = URL_MAX_LEN) => {
const clonedUrlObj = new URL(urlObj.toString());
let urlString = clonedUrlObj.toString();
// ... rest of the logic using clonedUrlObj
}
|
Code Review Results✅ StrengthsComprehensive test coverage with edge cases for Android app referrers, URL validation, and trimming logic. 🚨 Critical IssuesNone
|
Ex: android-app://com.google.android.googlequicksearchbox/