Introduce ExecutionPayloadBid for Gloas
#9912
Conversation
StefanBratanov
changed the title
ExecutionPayloadBid for Gloas
StefanBratanov
force-pushed
the
execution_payload_bid_gloas
branch
2 times, most recently
from
51d667f to
1c05a55
Compare
| */ | ||
|
|
||
| package tech.pegasys.teku.spec.datastructures.execution.versions.gloas; | ||
| package tech.pegasys.teku.spec.datastructures.epbs.versions.gloas; |
There was a problem hiding this comment.
it's a new package we introduced for all epbs objects, we could move them around in the future.
StefanBratanov
force-pushed
the
execution_payload_bid_gloas
branch
from
a3a8392 to
148e15e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| randomSlot(), | ||
| randomUInt64(), | ||
| randomBytes32()); | ||
| } |
There was a problem hiding this comment.
Bug: Fee Recipient Type Mismatch
The randomExecutionPayloadBid() method calls an undefined randomEth1Address() for the feeRecipient, causing a compilation error. This also introduces a type inconsistency in ExecutionPayloadBid, where the constructor expects Bytes20 for feeRecipient but the getter returns Eth1Address.
Additional Locations (1)
| // No SignedExecutionPayloadHeader in phase 0 | ||
| public BeaconBlockBodyBuilder signedExecutionPayloadBid( | ||
| final SignedExecutionPayloadBid signedExecutionPayloadBid) { | ||
| // No SignedExecutionPayloadBid in phase 0 |
There was a problem hiding this comment.
Bug: Builder Method Returns Null Instead Of This
The signedExecutionPayloadBid method in BeaconBlockBodyBuilderPhase0 returns null instead of this. This breaks the builder pattern, which could lead to NullPointerException if method calls are chained. Other unsupported builder methods in this class return this for consistency.
PR Description
Related to ethereum/consensus-specs#4525
Reference tests haven't been released yet, so ignored for Gloas. Can re-enable after we merge the
BeaconStatechange. Raised an issue for tracking #9915 . For the moment, we can ignore the failing check-specrefs.Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog