Skip to content

Conversation

@ThomasPiellard
Copy link
Contributor

@ThomasPiellard ThomasPiellard commented Jun 23, 2025

Description

SetState on a StateStorer now ensures that the size of the provided state corresponds to BlockSize.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard requested a review from Tabaie June 23, 2025 17:45
Copy link
Contributor

@Tabaie Tabaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pad on the left and error if the state parameter is too large.

@Tabaie Tabaie merged commit 4df6b1e into master Jun 24, 2025
6 checks passed
@Tabaie Tabaie deleted the fix/setState branch June 24, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants