Skip to content

Conversation

@yelhousni
Copy link
Collaborator

@yelhousni yelhousni commented Feb 20, 2025

Description

This PR:

  • corrects matMulExternalInPlace for width%4=0,
  • removes matMulM4InPlace in curves templates as only width=2,3 are supported,
  • adds diagonal of internal matrix for goldilocks when width=12 (sponge),
  • adds regression test for goldilocks when width=12.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

TODO:

  • implement cross tests with other libraries who share the same parameters.

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added the type: bug Something isn't working label Feb 20, 2025
@yelhousni yelhousni added this to the v0.10.0 milestone Feb 20, 2025
@yelhousni yelhousni changed the base branch from master to fix/pos2-comp-feedfwd February 20, 2025 19:46
Base automatically changed from fix/pos2-comp-feedfwd to master February 24, 2025 20:01
@Tabaie Tabaie merged commit d2fa915 into master Mar 1, 2025
5 checks passed
@Tabaie Tabaie deleted the fix/poseidon2-matMulExternal branch March 1, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants