Skip to content

Conversation

@yelhousni
Copy link
Collaborator

Description

Generify poseidon2 parameters for other curves/fr

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

N/A

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added the type: consolidate strengthen an existing feature label Feb 14, 2025
Copy link
Contributor

@Tabaie Tabaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for that commented block

@gbotrel
Copy link
Collaborator

gbotrel commented Feb 17, 2025

Can you rebase one top of #629 ? (i.e. update this PR to include small fields, and set it to merge on feat/poseidon2-koala+baby-bear instead of master). Then we will merge #629 first, and this one next

@yelhousni yelhousni changed the base branch from master to feat/poseidon2-koala+baby-bear February 17, 2025 22:26
Base automatically changed from feat/poseidon2-koala+baby-bear to master February 18, 2025 18:11
@Tabaie Tabaie merged commit 8a83584 into master Feb 18, 2025
5 checks passed
@Tabaie Tabaie deleted the gen-poseidon2 branch February 18, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: consolidate strengthen an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants