Skip to content

Conversation

@standstaff
Copy link
Contributor

Description

fix some function names in comment

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub changed the base branch from master to fix/typos-v0.15 December 11, 2024 08:57
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks good to me. I changed the base branch to typofix branch which will be merged to master soon. This allows to avoid merge conflicts for other PRs being worked on.

@ivokub ivokub added the type: typo Typo fixes label Dec 11, 2024
@ivokub ivokub merged commit fb53895 into Consensys:fix/typos-v0.15 Dec 11, 2024
ivokub pushed a commit that referenced this pull request Dec 25, 2024
ivokub pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: typo Typo fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants