Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented Apr 12, 2024

Description

This PR returns error constants when ECDSA signature is invalid due to r^3 + ax + b being quadratic non-residue. This is used in gnark for handling edge cases. This also allows to make an internal method private.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from yelhousni April 12, 2024 14:15
@ivokub ivokub self-assigned this Apr 12, 2024
@ivokub ivokub added type: new feature dep: linea Issues affecting downstream Linea priority: P1-high Issue priority: high labels Apr 12, 2024
Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge 👍

@yelhousni yelhousni merged commit 7edca0e into master Apr 23, 2024
@yelhousni yelhousni deleted the feat/ecdsa-errors branch April 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting downstream Linea priority: P1-high Issue priority: high type: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants