perf: improve fft domain memory footprint #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelhousni
approved these changes
Aug 16, 2023
Collaborator
yelhousni
left a comment
yelhousni
left a comment
There was a problem hiding this comment.
This makes sense for large zkEVM circuits indeed. What is the exact slowdown on small circuits, say a 2-chain Groth16 verifier?
Collaborator
Author
|
Benchmarked |
Collaborator
Author
|
1% slower for a larger circuit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes precompute of
CosetTableReversedandCosetTableInvReversedinfft.Domain.In practice these can be accessed from
CosetTableandCosetTableInv.New version may result in slightly slower FFT on small domains.
However, for large domains (think large plonk circuit), precomputing these and storing them in RAM contribute to a high memory load, hence the PR.