msm: semaphore to limit CPUs + better split strategy (up to 25% perf boost on 96cores) #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelhousni
approved these changes
May 17, 2023
Collaborator
yelhousni
left a comment
yelhousni
left a comment
There was a problem hiding this comment.
I get the logic of the split heuristics and the semaphore when NbTasks < NumCPU and it look good to me — but that's all ^^
I guess the PR might need an additional review of the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #269 by introducing a semaphore when the MSM has a
NbTasksparameter smaller than available CPUs.Additionally, it revisits the heuristic to decide if it's worth it to split a msm into 2 (parallelization) and this result in some noticeable gains on our reference machine (aws hpc w/ 96 cores);