Skip to content

Conversation

@gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Mar 22, 2023

Thanks to @asanso and @kevaundray for reporting;

IETF spec we followed states:

The serialization of a point at infinity comprises a string of zero bytes, except that the metadata bits may be nonzero.

Previously, we did check the metadata bits and if they were signaling a point at infinity, discarded the rest of the buffer. We now add an additional check to ensure all the bytes are at 0.

@gbotrel gbotrel added the type: bug Something isn't working label Mar 22, 2023
@gbotrel gbotrel requested a review from yelhousni March 22, 2023 19:27
Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbotrel gbotrel merged commit c27657a into develop Mar 23, 2023
@gbotrel gbotrel deleted the fix/infencoding branch March 23, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants