Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

feat: expose logs of detached instances via ganache instances logs command #4254

Draft
wants to merge 37 commits into
base: develop
Choose a base branch
from
Draft

feat: expose logs of detached instances via ganache instances logs command #4254

wants to merge 37 commits into from

Conversation

jeffsmale90
Copy link
Contributor

No description provided.

@jeffsmale90 jeffsmale90 changed the base branch from develop to feat/logging February 23, 2023 00:13
jeffsmale90 added 26 commits March 9, 2023 12:41
@jeffsmale90
Basic implementation of logging to file
c7f86d3
@jeffsmale90
Simplify logging
54b85c5
@jeffsmale90
Simplify regex for inserting timestamps
b0ca2e9
@jeffsmale90
Remove --timestamps argument
a397b6f
@jeffsmale90
Use a persistent filehandle instead of calling 'appendFile' each tile…
0f13a36 
… a log is written
@jeffsmale90
Introduce tests for logger, fail validation if path is not w
b206a42 
ritable
@jeffsmale90
Update tests to use per-test log files
d1ec4fe
@jeffsmale90
Resolve invalid path
feb57bd
@jeffsmale90
In windows, use reserved path 'c:\NUL' for invalid path
0b8673f
@jeffsmale90
Revert changes and just await the rejection
6d73be8
@jeffsmale90
Let's do use the NUL workaround for windows
8b4ae04
@jeffsmale90
Attempt to get tests to passing state
4b6159e
@jeffsmale90
Use current working directory as invalid file path
e2db28f
@jeffsmale90
Tidy up logging
d2db1a4
@jeffsmale90
Create file when validating logging.file path is writable.
4e64fc7
@jeffsmale90
Move logger into cli project, allow caller to close underlying fileha…
8423a65 
…ndle
@jeffsmale90
Revert unrelated changes, fix flaky initialisation of logger
fcf39ed
@jeffsmale90
Fix error when no logging config exists
22ec214
@jeffsmale90
Switch to use 'fs.openSync()' instead of 'fs.writeSync()' because win…
37e1616 
…dows won't if the content is empty :(
@jeffsmale90
Work in progress. Move logger into @ganache/utils, resolve filehandle…
44a7107 
… within logging-options.
@jeffsmale90
Improve tests, implementation, support for filecoin
b02821d
@jeffsmale90
Finish tidying up implementation. Broke the console.log tests though …
4e7ddd6 
…¯\_(ツ)_/¯
@jeffsmale90
Support setting both file and logger, refactor tangentially related test
f9aac47
@jeffsmale90
tidy up implementation, fix tests, don't accept filehandle as logging…
6cc6fb2 
….file because then it's impossible for us to now whether we should close it
@jeffsmale90
Update package-lock.json - adds reference to @ganache/utils
303330d
@jeffsmale90
Upgrade @ganache/utils
7edf108
jeffsmale90 added 10 commits March 9, 2023 13:14
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89ec342
Status: ✅  Deploy successful!
Preview URL: https://7cbb19ca.ganache.pages.dev
Branch Preview URL: https://feat-detached-logs.ganache.pages.dev

View logs

Base automatically changed from feat/logging to develop June 27, 2023 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeffsmale90