This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: log warning regarding transactions with future-nonces when mining in eager mode #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
commented
Jan 17, 2023
MicaiahReid
commented
Jan 17, 2023
MicaiahReid
commented
Jan 17, 2023
davidmurdoch
force-pushed
the
fix-eager-mining
branch
from
04b97a5 to
ee5d284
Compare
davidmurdoch
force-pushed
the
fix-eager-mining
branch
from
ee5d284 to
bc33250
Compare
davidmurdoch
changed the title
davidmurdoch
changed the title
davidmurdoch
changed the title
davidmurdoch
approved these changes
Feb 23, 2023
jeffsmale90
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benams ran into a confusing situation in which future-nonce transactions that are sent to Ganache running in eager mining mode appear to hang indefinitely, rather than being mined or rejected. This is expected behavior in eager mode, as Ganache does not return the hash until after it is mined. To help alleviate the confusion we now log a message about the status of these kinds of transactions.
Closes #4165