Skip to content

Conversation

@Sergio0694
Copy link
Member

See dotnet/runtime#82607 (comment)

This PR removes the dependency on System.Linq from CommunityToolkit.Diagnostics. This will help reduce binary size in NAOT builds using any of the Guard APIs, or the ToTypeString() extension directly, especially with default settings.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements diagnostics 🔬 Issues/PRs for the Diagnostics package labels Feb 27, 2023
@Sergio0694 Sergio0694 merged commit ee0587e into main Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/remove-diagnostics-linq branch February 28, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostics 🔬 Issues/PRs for the Diagnostics package optimization ☄ Performance or memory usage improvements

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant