Skip to content

Conversation

Sergio0694
Copy link
Member

This PR switches the new analyzers in the MVVM Toolkit to the preview of Roslyn 4.12 (not stable just yet).

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Nov 22, 2024
@Sergio0694 Sergio0694 merged commit df5ba86 into main Nov 23, 2024
3 checks passed
@Sergio0694 Sergio0694 deleted the dev/roslyn-4.12 branch November 23, 2024 20:39
@milesdream
Copy link

milesdream commented Nov 24, 2024

I stiil wait for something to have a small Letter as the public Property

at example
[ObservableProperty]
private bool _bReady ;

produces a public Property
public bool bReady;

its allready funny if I get Error CS0576 A partial method may not have multiple defining declarations

if I do

[ObservableProperty]
private bool _bNothing;

[ObservableProperty]
private bool bNothing;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants