Skip to content

Reinstate assembly versioning #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Reinstate assembly versioning #2837

merged 1 commit into from
Jul 29, 2025

Conversation

jfversluis
Copy link
Member

Reinstates the assembly versioning that was implemented with #2328 but got lost in the transition from Azure Pipelines to GitHub Actions

Fixes #2836

@jfversluis jfversluis marked this pull request as ready for review July 29, 2025 20:02
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 20:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reinstates assembly versioning functionality that was previously lost during the migration from Azure Pipelines to GitHub Actions. The changes ensure that each package component gets the correct version assignment for both PackageVersion and Version properties during build and pack operations.

  • Corrects version property assignments for Camera, MediaElement, and Maps packages during build steps
  • Adds missing Version property assignments for all packages during pack operations
  • Ensures consistent versioning across all CommunityToolkit.Maui components

@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) July 29, 2025 20:24
@TheCodeTraveler TheCodeTraveler merged commit d625a24 into main Jul 29, 2025
17 of 18 checks passed
@TheCodeTraveler TheCodeTraveler deleted the jfversluis-patch-1 branch July 29, 2025 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Assemblies have lower version (and fileversion) than 11.2 causing problems with the Windows Installer
3 participants