-
Notifications
You must be signed in to change notification settings - Fork 152
Add WithLogLevel extension method #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithLogLevel extension method #884
Conversation
aaronpowell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got one question about a change that I'm unsure if it's meant to be related or not - otherwise it's good to merge in.
| .WithEntrypoint("/go-feature-flag") | ||
| .WithArgs(args) | ||
| .WithOtlpExporter(); | ||
| .WithArgs(args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we won't do OTEL wire-up initially?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I have an issue with the new tests. Some dependencies that are not registered, so I had to remove this to ensure my tests are passing. Also, I still have an issue with the collector so I suppose removing it seems better.
Based on #827, add a
WithLogLevelextension method for the following integration:PR Checklist
Other information