Skip to content

Fix dapr using the wrong component annotations #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FullStackChef merged 1 commit into from
Sep 29, 2025
Merged

Fix dapr using the wrong component annotations #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions examples/dapr/CommunityToolkit.Aspire.Hosting.Dapr.AppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,23 @@
.WaitFor(redis);

var redisHost= redis.Resource.PrimaryEndpoint.Property(EndpointProperty.Host);
var redisTargetPort = redis.Resource.PrimaryEndpoint.Property(EndpointProperty.TargetPort);
var redisPort = redis.Resource.PrimaryEndpoint.Property(EndpointProperty.Port);

var pubSub = builder
.AddDaprPubSub("pubsub")
.WithMetadata(
"redisHost",
ReferenceExpression.Create(
$"{redisHost}:{redisTargetPort}"
$"{redisHost}:{redisPort}"
)
)
.WaitFor(redis);

if (redis.Resource.PasswordParameter is not null)
{
pubSub.WithMetadata("redisPassword", redis.Resource.PasswordParameter);
}

builder.AddProject<Projects.CommunityToolkit_Aspire_Hosting_Dapr_ServiceA>("servicea")
.WithDaprSidecar(sidecar =>
{
Expand Down
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public async Task BeforeStartAsync(DistributedApplicationModel appModel, Cancell

var aggregateResourcesPaths = sidecarOptions?.ResourcesPaths.Select(path => NormalizePath(path)).ToHashSet() ?? [];

var componentReferenceAnnotations = resource.Annotations.OfType<DaprComponentReferenceAnnotation>();
var componentReferenceAnnotations = daprSidecar.Annotations.OfType<DaprComponentReferenceAnnotation>();

var secrets = new Dictionary<string, string>();
var endpointEnvironmentVars = new Dictionary<string, IValueProvider>();
Expand Down
Loading