Remove implicit WaitFor in WithDbGate
#630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alirexaa
commented
Apr 13, 2025
| <!-- Workaround for https://github.com/dotnet/aspire/issues/7779 --> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'"> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" /> | ||
| <PackageReference Include="Microsoft.Extensions.Options"></PackageReference> |
There was a problem hiding this comment.
There was a problem hiding this comment.
That's a weird one. Would have to run the nuget why command to trace the package refs probably and find the conflict.
Or maybe it's a VS quirk. I only dev on the repo in VS Code, which should behave the same as VS, but I know there are quirks between them.
Alirexaa
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
Minimum allowed line rate is |
Alirexaa
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
aaronpowell
approved these changes
Apr 15, 2025
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let users explicitly use
WaitFor.