-
Notifications
You must be signed in to change notification settings - Fork 134
v9.3.0 release #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9.3.0 release #576
Conversation
|
@FullStackChef let's make sure we get all the Dapr stuff ready and we'll cut a stable with the changes |
|
@aaronpowell, Don't forget to merge #532 before this one. |
* backwards compatible fix for 568 * updated readme * updated readme
Yep, I'll merge that into |
|
@FullStackChef @WhitWaldo are there some deprecated API's that we're still using? |
|
@aaronpowell In the lifecycle hook we've got: #pragma warning disable CS0618 // Type or member is obsolete
string? maxBodySize = GetValueIfSet(sidecarOptions?.DaprMaxBodySize, sidecarOptions?.DaprHttpMaxRequestSize, "Mi");
string? readBufferSize = GetValueIfSet(sidecarOptions?.DaprReadBufferSize, sidecarOptions?.DaprHttpReadBufferSize, "Ki");
#pragma warning restore CS0618 // Type or member is obsolete
...
private static string? GetValueIfSet(string? newValue, int? obsoleteValue, string notation)
{
if (newValue is not null) return newValue;
if (obsoleteValue is not null) return $"{obsoleteValue}{notation}";
return null;
}In order to make things less breaking. DaprHttpMaxRequestSize & DaprHttpReadBufferSize are marked as Obsolete (error false) |
* backwards compatible fix for 568 * updated readme * updated readme * Use private fields to handle obsolete values
Remove code that slipped through
Adjust missed instances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dapr changes are as expected
Minimum allowed line rate is |
Closes #<ISSUE_NUMBER>
PR Checklist
Other information