Skip to content

Aspire-13.1 #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aaronpowell merged 19 commits into from
Jan 14, 2026
Merged

Aspire-13.1 #1056

aaronpowell merged 19 commits into from
Jan 14, 2026

Conversation

@aaronpowell
Copy link
Member

@aaronpowell aaronpowell commented Dec 11, 2025

  • Updated multiple test files to replace calls to GetEnvironmentVariableValuesAsync() with GetEnvironmentVariablesAsync().
  • Replaced calls to GetArgumentValuesAsync() with GetArgumentListAsync() in various test cases.
  • Introduced new utility methods in the CommunityToolkit.Aspire.Testing namespace for better argument and environment variable handling.

Closes #<ISSUE_NUMBER>

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@aaronpowell
Bumping to the current 13.1 preview for initial testing work
e887e25
@aaronpowell
Updating redis types due to obsoleting
ffb97b9
@aaronpowell
Refactor tests to use new environment variable and argument retrieval…
7cd5d0e 
… methods

- Updated multiple test files to replace calls to GetEnvironmentVariableValuesAsync() with GetEnvironmentVariablesAsync().
- Replaced calls to GetArgumentValuesAsync() with GetArgumentListAsync() in various test cases.
- Introduced new utility methods in the CommunityToolkit.Aspire.Testing namespace for better argument and environment variable handling.
@afscrome afscrome mentioned this pull request Dec 11, 2025
Open
@aaronpowell aaronpowell mentioned this pull request Dec 11, 2025
Closed
10 tasks
aaronpowell and others added 5 commits December 14, 2025 22:48
@aaronpowell
Updating to lastest 13.1 build
05a0c91
@aaronpowell
Evaluating the annotations directly
28221bc
@aaronpowell
Changing how to handle env vars in keycloak tests
9757fa6
@aaronpowell
Missed a test
91718ea
@FullStackChef
Switch to Azure Redis Enterprise for infra and tests
ed6333d 
Updated infrastructure and test code to use Azure Redis Enterprise (Microsoft.Cache/redisEnterprise) instead of the legacy Azure Redis Cache. Refactored connection string handling and key retrieval to use RedisEnterpriseCluster and RedisEnterpriseDatabase resources. Updated Bicep templates and test assertions accordingly. Removed obsolete test for non-SSL port, as Redis Enterprise always requires TLS. This modernizes the codebase to align with current Azure recommendations.
@github-actions github-actions bot added the Stale label Dec 21, 2025
@github-actions github-actions bot closed this Dec 24, 2025
@aaronpowell aaronpowell removed the Stale label Jan 12, 2026
@aaronpowell aaronpowell reopened this Jan 12, 2026
@aaronpowell aaronpowell marked this pull request as ready for review January 12, 2026 03:38
Copilot AI review requested due to automatic review settings January 12, 2026 03:38
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.GoFeatureFlag 100% 97% 74 ✔
CommunityToolkit.Aspire.Hosting.ActiveMQ 78% 40% 108 ➖
CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit 1% 0% 14 ❌
CommunityToolkit.Aspire.Hosting.Adminer 74% 50% 20 ➖
CommunityToolkit.Aspire.Hosting.Azure.Dapr 29% 7% 124 ❌
CommunityToolkit.Aspire.Hosting.Azure.Dapr.Redis 62% 38% 80 ➖
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 22 ✔
CommunityToolkit.Aspire.Hosting.Bun 96% 83% 28 ✔
CommunityToolkit.Aspire.Hosting.Dapr 60% 37% 856 ❌
CommunityToolkit.Aspire.Hosting.DbGate 94% 50% 18 ✔
CommunityToolkit.Aspire.Hosting.Deno 98% 85% 44 ✔
CommunityToolkit.Aspire.Hosting.Flagd 79% 100% 32 ➖
CommunityToolkit.Aspire.Hosting.GoFeatureFlag 88% 73% 36 ✔
CommunityToolkit.Aspire.Hosting.Golang 51% 40% 88 ❌
CommunityToolkit.Aspire.Hosting.Java 70% 75% 130 ➖
CommunityToolkit.Aspire.Hosting.JavaScript.Extensions 97% 85% 200 ✔
CommunityToolkit.Aspire.Hosting.k6 58% 12% 20 ❌
CommunityToolkit.Aspire.Hosting.Keycloak.Extensions 100% 100% 22 ✔
CommunityToolkit.Aspire.Hosting.KurrentDB 71% 75% 34 ➖
CommunityToolkit.Aspire.Hosting.LavinMQ 74% 50% 26 ➖
CommunityToolkit.Aspire.Hosting.LavinMQ.MassTransit 1% 0% 14 ❌
CommunityToolkit.Aspire.Hosting.MailPit 85% 50% 22 ✔
CommunityToolkit.Aspire.Hosting.McpInspector 78% 45% 210 ➖
CommunityToolkit.Aspire.Hosting.Meilisearch 71% 57% 58 ➖
CommunityToolkit.Aspire.Hosting.Minio 88% 75% 56 ✔
CommunityToolkit.Aspire.Hosting.MongoDB.Extensions 95% 90% 20 ✔
CommunityToolkit.Aspire.Hosting.MySql.Extensions 98% 92% 62 ✔
CommunityToolkit.Aspire.Hosting.Ngrok 52% 35% 82 ❌
CommunityToolkit.Aspire.Hosting.Ollama 65% 69% 260 ➖
CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector 78% 61% 77 ➖
CommunityToolkit.Aspire.Hosting.PapercutSmtp 81% 50% 18 ✔
CommunityToolkit.Aspire.Hosting.PostgreSQL.Extensions 97% 90% 68 ✔
CommunityToolkit.Aspire.Hosting.Python.Extensions 45% 29% 100 ❌
CommunityToolkit.Aspire.Hosting.RavenDB 62% 48% 148 ➖
CommunityToolkit.Aspire.Hosting.Redis.Extensions 100% 71% 28 ✔
CommunityToolkit.Aspire.Hosting.Rust 94% 83% 16 ✔
CommunityToolkit.Aspire.Hosting.Solr 72% 100% 22 ➖
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects 51% 48% 192 ❌
CommunityToolkit.Aspire.Hosting.Sqlite 89% 89% 52 ✔
CommunityToolkit.Aspire.Hosting.SqlServer.Extensions 98% 90% 62 ✔
CommunityToolkit.Aspire.Hosting.Stripe 51% 30% 82 ❌
CommunityToolkit.Aspire.Hosting.SurrealDb 55% 40% 256 ❌
CommunityToolkit.Aspire.KurrentDB 94% 92% 54 ✔
CommunityToolkit.Aspire.MassTransit.RabbitMQ 100% 100% 30 ✔
CommunityToolkit.Aspire.Meilisearch 97% 92% 68 ✔
CommunityToolkit.Aspire.Microsoft.Data.Sqlite 89% 85% 52 ✔
CommunityToolkit.Aspire.Microsoft.EntityFrameworkCore.Sqlite 61% 58% 114 ➖
CommunityToolkit.Aspire.Minio.Client 90% 85% 112 ✔
CommunityToolkit.Aspire.OllamaSharp 78% 71% 134 ➖
CommunityToolkit.Aspire.RavenDB.Client 60% 53% 237 ➖
CommunityToolkit.Aspire.SurrealDb 79% 63% 78 ➖
Summary 67% (7452 / 11076) 55% (2053 / 3734) 4760 ➖

Minimum allowed line rate is 60%

@aaronpowell aaronpowell merged commit 8dba511 into main Jan 14, 2026
341 of 344 checks passed
@aaronpowell aaronpowell deleted the aspire-13.1 branch January 14, 2026 04:35
This was referenced Jan 14, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Merged
Merged
Open
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ErikEJ ErikEJ ErikEJ approved these changes

@Harold-Morgan Harold-Morgan Harold-Morgan approved these changes

@tommasodotNET tommasodotNET tommasodotNET approved these changes

@martinjt martinjt Awaiting requested review from martinjt martinjt is a code owner

@Alirexaa Alirexaa Awaiting requested review from Alirexaa Alirexaa is a code owner

@shiranshalom shiranshalom Awaiting requested review from shiranshalom shiranshalom is a code owner

@FullStackChef FullStackChef Awaiting requested review from FullStackChef FullStackChef is a code owner

@WhitWaldo WhitWaldo Awaiting requested review from WhitWaldo WhitWaldo is a code owner

@paule96 paule96 Awaiting requested review from paule96 paule96 is a code owner

@esskar esskar Awaiting requested review from esskar esskar is a code owner

@MichielBrys MichielBrys Awaiting requested review from MichielBrys MichielBrys is a code owner

@jmezach jmezach Awaiting requested review from jmezach jmezach is a code owner

@fboucher fboucher Awaiting requested review from fboucher fboucher is a code owner

@justinyoo justinyoo Awaiting requested review from justinyoo justinyoo is a code owner

@aviv86 aviv86 Awaiting requested review from aviv86 aviv86 is a code owner

@karmeli87 karmeli87 Awaiting requested review from karmeli87 karmeli87 is a code owner

@ppekrol ppekrol Awaiting requested review from ppekrol ppekrol is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aaronpowell @ErikEJ @Harold-Morgan @tommasodotNET @FullStackChef